Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3011488yba; Tue, 16 Apr 2019 02:46:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfC139fxrIejxonM3NluuW3pnwCMKX9ydLciMchC9Ju/VB/cLMV+9HJg0fI+WeVb58IwEw X-Received: by 2002:a63:f40d:: with SMTP id g13mr77202370pgi.345.1555408003075; Tue, 16 Apr 2019 02:46:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555408003; cv=none; d=google.com; s=arc-20160816; b=irLjoBgjYYN0JkxyY3BdC2PydiDYfn6V4SxlXvJG8r4l5odZX7HLamyEMSAxFSfL+L Xe1fINoeQPShLX59altn42lKpEFR7tijR71aZ3x3W3IH1us/SxkI86gDekxlgc0bCTf2 Crk2xT0yH+41R1ahiskE2x7v+ouiXPNC6qwzcmhnsoXWqH+p+wVD8uJ8Xy/kLY4m3p6I 5AM+0b45+cnb6sHu5Zer0BfjxM7MTl6TpacoyizxCqwj0tsvjldUPEcMmHWYBJXL7hiz bp8HSTFbcICAGdwXI6x+3VOt7pnG1tvQSAWFS0YuUvJ/DNtPff6wTXaJ40FNDwdjYwUU IAKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=eJ0YH9ptS0Do7erQHVVtEeICKLGzyFnBQ2eXBaKWUJQ=; b=hDd9ey9B753cKtuWyqExA3C7i7oD6OBicyh3dp+JyKjvRsaBBKeTIZK8YD7CgcPML4 nbe6wcLHDsQGGM1ufTZCYdqlR4KoKySa0w2OrFZACMT79K8DfuqkGCPU9YW7tnzzJ7zQ JyCon2/nGIcZ0Ou68d/YPz1aWKEJNZVn4AHhLu3qTsvuD/rrlRDS2Vn6i7eJ+ZuuHc9j KGMg0+68ky0AHqgjT0uWpr916IvO9a61tv+qD38gnVgVjMGiGqZARf+EIYaTviuaSsYX jDXKpc43B+a09F9iyTioRlzZGNfv9Ddc4hFmWm9r3j5m0sQ1Niva7bfSG0nRe4KrgfIm vFHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bP90p6aA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si51533409pfd.93.2019.04.16.02.46.27; Tue, 16 Apr 2019 02:46:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bP90p6aA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbfDPJps (ORCPT + 99 others); Tue, 16 Apr 2019 05:45:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:35652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbfDPJps (ORCPT ); Tue, 16 Apr 2019 05:45:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6A18020684; Tue, 16 Apr 2019 09:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555407947; bh=BlHaJfX+k2skE3lCGc1AtyXKIgrIDTDVlB8GM+upJLw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bP90p6aArRpifF4Ml1slnpTGtQ3SSFBoSeR6E6qRbSXkxbbcmtdRf0V05qYoUREp6 3YH7C7sdiKNPlPQCI5zB+51ZlQe9tmAz4jfyVYwbfEnGtoh26w5vv++EOJtUnjP2o/ KGlFQDyZYXAxfhYowuagW+0vHXxB02MePBlkLTSg= Date: Tue, 16 Apr 2019 11:45:45 +0200 From: Greg KH To: zhuyan Cc: anton@enomsg.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb Message-ID: <20190416094545.GA896@kroah.com> References: <1554820632-13782-1-git-send-email-zhuyan34@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554820632-13782-1-git-send-email-zhuyan34@huawei.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 09, 2019 at 10:37:12PM +0800, zhuyan wrote: > In function fhci_queue_urb, the divisor of expression > (urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe, > usb_pipeout(urb->pipe))) may be zero. How can you hit that? > When it is zero, unexpected results may occur, so it is necessary to > ensure that the divisor is not zero. > > Signed-off-by: zhuyan I need a "Full" name here, not just a single name. Whatever you use to sign documents is good. thanks, greg k-h