Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3022745yba; Tue, 16 Apr 2019 03:03:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqyArcOHEYXpu7C391JrZFH9VVryoOm3+lMEccBQqJQPyd7bYFMKBYfnmLjquj141m74Bltq X-Received: by 2002:a17:902:a9c7:: with SMTP id b7mr77798280plr.145.1555409027028; Tue, 16 Apr 2019 03:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555409027; cv=none; d=google.com; s=arc-20160816; b=f7zfstbSTBIJXM+vgcRnpLqmmfto0YsTUuDGozrltR4HTQfr7GTspo1YuaagdE5Pdw Ulcl4i867eukrIWws3WNxg46YA7nLNF8zI3CCfYtc4Al1OrIeIIkJrnBmAS6OifKoqWq Ntq1VSpca9K5WnBVAuNx7deZt6mPpMesRUdWrOsKN8JF4orMrK9MVs9Ls4ESgDNwsUPI GlInRrZFWRmGBECXTDW9JG+I/LFfk0bu8ld2zmCjYJVJBvuskyh0mNcqcQueJ9uJBEgZ lrB64RrRZGhlpqfl3jRPLw6PYpFUPdDdyiGe6uXHqRAMyeRriCXIqNxHMQTbOdAFxS6s 0VxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IHFq9Weub1p+P1N8kbjYDQlb3WFyDWhI0+cUaRvsVNk=; b=uiQtliM5/ORjtEvyesKRsgyhuv035IR3Vm3dt0QqntvlJhVGA6+loUfy0UtugT5lao k8H+BBVB/PZ0kmrx/MNxO+97/IldD2f/ZWADFu53ZMtGnJzw8b8yRLyDkn1JqY88YhhB vlJhNa6+wmM08GjRkvinQzVWyix3gUdAWJYp0HGD5k6/eg38Gma3po4HQ3TH5t6n8jFe J0i1gtmxdYOagkev2GbsAYX2g4492ycl58ZVWwSofkoUX5EbZeN3cw5zG86Ct4wtUf6E /g67wEsebgwtCLGugJ8UbA6qSBIgabMN4JWUOaPpkSqctI9OcKh4ty+2yY+CumyIpAie t13Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=e6wdcpBT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r124si43741973pgr.201.2019.04.16.03.03.27; Tue, 16 Apr 2019 03:03:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=e6wdcpBT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbfDPKCb (ORCPT + 99 others); Tue, 16 Apr 2019 06:02:31 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:35201 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfDPKCb (ORCPT ); Tue, 16 Apr 2019 06:02:31 -0400 Received: by mail-wm1-f67.google.com with SMTP id y197so12699224wmd.0 for ; Tue, 16 Apr 2019 03:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IHFq9Weub1p+P1N8kbjYDQlb3WFyDWhI0+cUaRvsVNk=; b=e6wdcpBTUTNKsZbWqHQgdub0tvKvYKBRT0k4swollma8zZ4RCSG4QPd1fjS2InFQKJ 0CU+/OoH5fKAatOJ1VWI0tINd/BrITex1K2NNFCO9/jo+ZwBR9bM8I0eEAckBVT+X0p4 rOlLJvJjREv32OTpvpfvI50oqnklbA79w4wMSwVV4TxpZnrxVGFQ+emATRu6o8tRJjW3 JDTKIw+pS2+Y+PFXnqyiGnQeZogtTlm6PKbsOq7zG2PR1ZHkKizbIwtmwBFlFrYPFNT/ BiwX5KoNJDjfpMVbGCXVLrluH8Nuu6Rzd64IOQ5b5nDm8YbmJfNj4L6eql2wiXlfcjmY tjUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IHFq9Weub1p+P1N8kbjYDQlb3WFyDWhI0+cUaRvsVNk=; b=csQrVmyCRxeyWfcNQmpjz62uVs/Xr7xk5vNLfRBfFkSBifW84tWZCKtXt00KDxKzjg 9pXmil8FOSThcSQ4M87DfOeBRsrMV8kyXyiugpCcM5/q2UdiMESgPaP7gOxAl2ZNFyKT NEByHEVfVmusQfV25gTx4x+g+jPMxE9JkbxFjvPHT7P3riXwt4cOSpJV0zK9MfKpEZkW GQ8ex3xTMfffejtxqIs1sLdu0GcqE8z2iHCEExv5sU9ngQFnLPJDYZgp8OJOWWk9aFEI 5pCqQYTHlPidvstpYgcXrzb2ZAK579Y4ifAybCgQpUvMWa4nJhJ3T45r37/SB5nAKIVG eTIQ== X-Gm-Message-State: APjAAAVz0ExtxgBJxN6bo9Ho5ctn78DfKn2YPaidFmb1RqbWwGm8dgK/ 9SDC0DvN6RHj6Xn47LEFuDA= X-Received: by 2002:a1c:1a53:: with SMTP id a80mr25979131wma.15.1555408949889; Tue, 16 Apr 2019 03:02:29 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id a11sm16450155wmm.35.2019.04.16.03.02.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Apr 2019 03:02:29 -0700 (PDT) Date: Tue, 16 Apr 2019 12:02:26 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Junichi Nomura , Dave Young , Chao Fan , Baoquan He , Kairui Song , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Message-ID: <20190416100226.GA117053@gmail.com> References: <20190411125822.GE30080@zn.tnic> <20190412025416.GA11070@jeru.linux.bs1.fc.nec.co.jp> <20190412084956.GC19808@zn.tnic> <20190412133528.GD19808@zn.tnic> <20190415090717.GA29317@zn.tnic> <20190415102525.GB29317@zn.tnic> <23309b73-d135-a207-564b-6003cee39184@ce.jp.nec.com> <20190416094024.GE27892@zn.tnic> <20190416095209.GG27892@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416095209.GG27892@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > I'll queue the below in the next days if there are no more complaints: Just a minor style nit, this was inherited from existing code: > + efi_config_table_64_t *tbl = (efi_config_table_64_t *) config_tables + i; > + efi_config_table_32_t *tbl = (efi_config_table_32_t *) config_tables + i; You might want to update that to the canonical form of: > + efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables + i; > + efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables + i; Looks good otherwise. Thanks, Ingo