Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3044495yba; Tue, 16 Apr 2019 03:33:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqxmqSi/2Gh2iWFJUUrkcf7PidFXFWWgJM+zNO/JTefQF3UdW1nZaFs9FbSA/BhGCzQpZZ+q X-Received: by 2002:a65:4247:: with SMTP id d7mr71323952pgq.114.1555410811306; Tue, 16 Apr 2019 03:33:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555410811; cv=none; d=google.com; s=arc-20160816; b=EI7d5H4h07GBPuetMG5D1ZAO03cc3AwOWpm5sBenKXQ8jnvt4rbF85vSR64a3KWcf2 W97xp71JerZP1p1N1AA217VJTRaE8gLjKZYWhnrmv6ywQ893gKtPdxR+Iv5AKG1JGotF bf/Sl3tcepjTzPw+4Rdnd7JoYc1AIQQRtRDrJxcA7QmmIrb7UdkCjNMMrz7Nr5BHXOV0 0cFbivsvoAyr0/ke0Aj1BIdlrELVif3ru5t66SOUgr7cRRnkdMTGeTj4WVS0egTXGJ1k BH7bdEx2DoEmYbvhCmjIrYJiZWHiyEeo2Jw3lgVyB7+ZZyiTHVZ7lgJNiQ06O9vgEgEt GzQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LECkOkuhUcVrxdxxTmVMCwNfDHXpKkrXY/d7puf8lNY=; b=Ez7bYYpS98/32awA5BFE3CBOsysfx2zH6efbMOIvbJcf0xlzL1XYSPC2CrrgfU1Ykw lSosM7H83malcAh+ucSTZ7AWufKqHYaZ1feCYj+HAkfSqsQn1sK9C11I+XOissh9hz0r wcjSUWkfxwMDoWIILY+IvMS+MaSztr6mSaNkf3fdDsxlfOFCmxkxeg8rKktVixCCw832 I4PEWTj7BtdjZMANSD8YYMtl8a+h4P9IDN4LWpqI3IvXpmN5b4MsEIOcMsLVjDY3Z7mE iLKl12aqtxGOlcYwR9M6RqTaCUwqYJLB3NMeUU9wMPR3ppxzSgT9BzB8FeBm2zmqDWZJ Rkaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=q1mENjsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v1si45662152pgc.492.2019.04.16.03.33.14; Tue, 16 Apr 2019 03:33:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=q1mENjsM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbfDPKcB (ORCPT + 99 others); Tue, 16 Apr 2019 06:32:01 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53814 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726682AbfDPKcA (ORCPT ); Tue, 16 Apr 2019 06:32:00 -0400 Received: from zn.tnic (p200300EC2F0D6900D0FA583685BBD9D6.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:6900:d0fa:5836:85bb:d9d6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F16C01EC0513; Tue, 16 Apr 2019 12:31:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555410719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=LECkOkuhUcVrxdxxTmVMCwNfDHXpKkrXY/d7puf8lNY=; b=q1mENjsM3iNSK8/ZUJnyJyJ9pbFBxJmWnpOvSX+YlH0A6H5GvAYCDKVFqBx7AZM0gFyeMk Ie1gZzezC51zvzYBHRiwdUXk/7uuuJ1ADgKX2BpjFz70gyZWU5+6aGBs1TRN9EuPPf4c3Q JOxUoDIrIdh4ktRz9GzYS9i8o2Yac0k= Date: Tue, 16 Apr 2019 12:31:54 +0200 From: Borislav Petkov To: Ingo Molnar Cc: Junichi Nomura , Dave Young , Chao Fan , Baoquan He , Kairui Song , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Message-ID: <20190416103154.GC31772@zn.tnic> References: <20190412025416.GA11070@jeru.linux.bs1.fc.nec.co.jp> <20190412084956.GC19808@zn.tnic> <20190412133528.GD19808@zn.tnic> <20190415090717.GA29317@zn.tnic> <20190415102525.GB29317@zn.tnic> <23309b73-d135-a207-564b-6003cee39184@ce.jp.nec.com> <20190416094024.GE27892@zn.tnic> <20190416095209.GG27892@zn.tnic> <20190416100226.GA117053@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190416100226.GA117053@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2019 at 12:02:26PM +0200, Ingo Molnar wrote: > > * Borislav Petkov wrote: > > > I'll queue the below in the next days if there are no more complaints: > > Just a minor style nit, this was inherited from existing code: > > > + efi_config_table_64_t *tbl = (efi_config_table_64_t *) config_tables + i; > > + efi_config_table_32_t *tbl = (efi_config_table_32_t *) config_tables + i; > > You might want to update that to the canonical form of: > > > + efi_config_table_64_t *tbl = (efi_config_table_64_t *)config_tables + i; > > + efi_config_table_32_t *tbl = (efi_config_table_32_t *)config_tables + i; > > Looks good otherwise. Fixed, thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.