Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jason Gunthorpe <jgg@mellanox.com>
To:     Colin King <colin.king@canonical.com>
CC:     Potnuri Bharat Teja <bharat@chelsio.com>,
        Doug Ledford <dledford@redhat.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/cxgb4: fix null pointer dereference on alloc_skb
 failure
Thread-Topic: [PATCH] RDMA/cxgb4: fix null pointer dereference on alloc_skb
 failure
Thread-Index: AQHU9ERso+Yk52XNJEqqSJZt6k25ZA==
Date:   Tue, 16 Apr 2019 11:06:22 +0000
Message-ID: <20190416110618.GA15844@mellanox.com>
References: <20190413160026.5873-1-colin.king@canonical.com>
In-Reply-To: <20190413160026.5873-1-colin.king@canonical.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f14c9808-c01a-48b4-4519-08d6c25b8f0b
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:AM6PR05MB5624;
x-ms-traffictypediagnostic: AM6PR05MB5624:
x-microsoft-antispam-prvs: <AM6PR05MB56242D783FEB10B4B072AF85CF240@AM6PR05MB5624.eurprd05.prod.outlook.com>
x-forefront-prvs: 000947967F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(7736002)(102836004)(316002)(186003)(6512007)(4326008)(81156014)(6486002)(53936002)(81166006)(8676002)(36756003)(305945005)(99286004)(6246003)(26005)(33656002)(1076003)(54906003)(6506007)(386003)(478600001)(14454004)(3846002)(76176011)(2906002)(4744005)(105586002)(6116002)(52116002)(25786009)(86362001)(6916009)(71200400001)(71190400001)(5660300002)(97736004)(229853002)(11346002)(68736007)(476003)(486006)(2616005)(256004)(446003)(106356001)(8936002)(6436002)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB5624;H:AM6PR05MB4439.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Hw0eohQuK72iDSoD/2Zli2vbDMSuAt80tRlvi4oaNt94HI9m2y1ZjtWMqkhs9XFz759qvTdX5Vtwwn8dTGsiCyPLRf/e/W7wbDMt05+4ZP3QHlSulW/mI3jrpy5tl3iEeTqHjM+usFM0uGB6eGuFLEOM4VyxTRdDDsJvrL2UWQKsqd87UCvNavOJvMqRj3s5WR6AN67PgPjZOLykA0mogq7Z0SxOzpCgWW1XChbjT4qyNW7kQ28sj4hf+e7kxG8bqYcRRGq2aiAbK5Vt7blg0XtEb3hwq10WuSNFfXjJxib62CLIWYRPodFfdye5nzZXD+OGKk1ePBC4SWwffvEuyL0rIZZO5R7AS4sDciyO8qSv+e9zVGgkFqpqa7forC94Rb430gvEg/k3qbg0c3QhQiLUDcG4Yrvmx9IFwpG9arA=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3A441435B82E8A41B10EF6265175C80D@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f14c9808-c01a-48b4-4519-08d6c25b8f0b
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2019 11:06:22.0399
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5624
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Apr 13, 2019 at 05:00:26PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>=20
> Currently if alloc_skb fails to allocate the skb a null skb is passed
> to t4_set_arp_err_handler and this ends up dereferencing the null skb.
> Avoid the null pointer dereference by checking for a null skb and
> returning early.
>=20
> Addresses-Coverity: ("Dereference null return")
> Fixes: b38a0ad8ec11 ("RDMA/cxgb4: Set arp error handler for PASS_ACCEPT_R=
PL messages")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied to for-next

Thanks,
Jason