Date: Fri, 2 Apr 2004 21:23:50 -0800
From: Paul Jackson <pj@sgi.com>
To: colpatch@us.ibm.com
Cc: wli@holomorphy.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch 6/23] mask v2 - Replace cpumask_t with one using mask
Message-Id: <20040402212350.547eb77d.pj@sgi.com>
In-Reply-To: <1080944675.9787.113.camel@arrakis>
References: <20040401122802.23521599.pj@sgi.com>
	<20040401131136.792495fa.pj@sgi.com>
	<1080944675.9787.113.camel@arrakis>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 981
Lines: 26

Matthew wrote:
> a better way to do this for UP.
> +#define	cpu_online_map			\
> +({						\
> +	cpumask_t m = MASK_ALL1(NR_CPUS);	\
> +	m;					\
> +})

This only helps cpu_online_map and cpu_possible_map, and only on UP's.

My controversial patch 24/23 helps all MASK_ALL based initializations,
and all mask_of_bit based initializations, for all systems up to 32 CPUs
(or 64, depending on sizeof(long)).

In particular, grep for 'cpumask_of_cpu(0)' in the kernel. You will find
many hits.  This should be efficient for all 'normal' sized systems.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/