Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C48E260E75
Subject: Re: [PATCH v2] nvmem: core: add NVMEM_SYSFS Kconfig
To:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     gregkh@linuxfoundation.org, maxime.ripard@bootlin.com,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190416095924.17428-1-srinivas.kandagatla@linaro.org>
 <20190416110144.GS2654@lahna.fi.intel.com>
From:   Gaurav Kohli <gkohli@codeaurora.org>
Message-ID: <06b77a2d-a675-965d-224f-14ad8d9df106@codeaurora.org>
Date:   Tue, 16 Apr 2019 16:45:54 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190416110144.GS2654@lahna.fi.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi ,

I have reviewed and tested for both enabled and disabled and working as 
expected.

Please feel free to add:

Reviewed-by: Gaurav Kohli <gkohli@codeaurora.org>
Tested-by: Gaurav Kohli <gkohli@codeaurora.org>

Regards
Gaurav
On 4/16/2019 4:31 PM, Mika Westerberg wrote:
> On Tue, Apr 16, 2019 at 10:59:24AM +0100, Srinivas Kandagatla wrote:
>> Many nvmem providers are not very keen on having default sysfs
>> nvmem entry, as most of the usecases for them are inside kernel
>> itself. And in some cases read/writes to some areas in nvmem are
>> restricted and trapped at secure monitor level, so accessing them
>> from userspace would result in board reboots.
>>
>> This patch adds new NVMEM_SYSFS Kconfig to make binary sysfs entry
>> an optional one. This provision will give more flexibility to users.
>> This patch also moves existing sysfs code to a new file so that its
>> not compiled in when its not really required.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> 

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.