Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 16 Apr 2019 13:47:30 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Petr Mladek <pmladek@suse.com>
cc:     Josh Poimboeuf <jpoimboe@redhat.com>,
        Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH] livepatch: Enforce reliable stack trace as config
 dependency
In-Reply-To: <20190212094608.bzwc26j67daqnx6x@pathway.suse.cz>
Message-ID: <nycvar.YFH.7.76.1904161345560.9803@cbobk.fhfr.pm>
References: <20190209091728.23046-1-kamalesh@linux.vnet.ibm.com> <20190211140813.z7kap634gz3gp6a4@treble> <20190212094608.bzwc26j67daqnx6x@pathway.suse.cz>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 12 Feb 2019, Petr Mladek wrote:

> > I think I'd rather go in the opposite direction: allow the patches to be
> > loaded.  Then they can be forced, if needed.  That enables both compile
> > and runtime testing.  That way we don't make any backward progress,
> > until such arches get reliable stacktraces.
> 
> Do you mean to convert the error into warning?
> 
> For example, the change below. Note that I did not mention
> the possibility to force the transition by intention. It is risky
> and people should not get used to it.
> 
> Heh, I think that this was the main reason why it was the error.
> We did not want to get people used to forcing livepatches.
> 
> 
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index d1af69e9f0e3..8d9bce251516 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -1035,11 +1035,10 @@ int klp_enable_patch(struct klp_patch *patch)
>  		return -ENODEV;
>  
>  	if (!klp_have_reliable_stack()) {
> -		pr_err("This architecture doesn't have support for the livepatch consistency model.\n");
> -		return -EOPNOTSUPP;
> +		pr_warn("This architecture doesn't have support for the livepatch consistency model.\n");
> +		pr_warn("Only one livepatch can be installed.\n");
>  	}
>  
> -

This seems to have been lost.

I think we should take this aproach before Miroslav is ready with 
realiable stack traces for s390. At the same time, I'd suggest issuing a 
proper WARN() there instead of just pr_warn(). The kernel might be in a 
potentially funky state, so let's at least get the 'W' taint in place.

-- 
Jiri Kosina
SUSE Labs