Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3207212yba; Tue, 16 Apr 2019 06:55:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNmR3eGlJW6HEZ8WHEb97jbcPxnXy7qwS7PQM+YoD/7ueJY7ja7G9EgFPy/3aB9bTxcsQr X-Received: by 2002:a17:902:a7:: with SMTP id a36mr64246298pla.111.1555422931730; Tue, 16 Apr 2019 06:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555422931; cv=none; d=google.com; s=arc-20160816; b=zHMJyXn37JQ5+553P30t/da6SEXV6BNVQ2G0edFjvYhAzVqTH7/oMPpMNsqvuwXe3E 6ffWP/s+8x0FUpd4EPuKQBBdGaxMUkh2PboGpEGxZ/xhtx7GKQqzn276VCEOybN1wFTV DEeQXm+vcNo9OUzln92jRsQt6a2n63uZYV4IZuitldAnJuflxPl1CfGtvAHqcmeTa3t2 gVEEgLeD3+MO5QcNqytuA20ej2BystlKKTuPKIHcRJ7k2X8DxSloapaBuYVMxQ8V0FqJ 9jjh+yyvkLSSUTVmNqyG6zSHJDdskUQIoqD97yM8MDGPKpdIwUPsDnggL9C9PVfNzgSg Qa3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature; bh=PUEimrDkDNjafWQNoeSSGu0JOmhZ7XGlyAON9WIKy9c=; b=Qaa7cwTsLOEFcvJsKlbDbOHpO0XPQdE5cOLy+4u8PiUopZ6n2hefkgoxBTSnGVymv2 9dXZxb+4rGUY+HOuZdtW9GNuMpCm5mNsRJIfLosn5ZMnkulu5NiwoaKNI6ry+eVM0w0C z05nJvcdURiIjHbGsNFeMZdMoim72F/VORmUE+ZbV+q30W1vdHh6RQPFIhb5ZHAO2DJs pBU2mWJvXI5B9d+QeamGKxWdJ/vMEL0R+iSA2pf1z8YDiauLBiV83PoC+xio6kbbUzpz f1r8j0vhyk+eq3tJpkeTCcfjyewXVy3X8tmJQLjzM0tvMmpzNz6pmzVHkVfL2OxQSgAl SMfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fSBsnJzc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v77si50780499pfa.219.2019.04.16.06.55.14; Tue, 16 Apr 2019 06:55:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fSBsnJzc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728093AbfDPNyk (ORCPT + 99 others); Tue, 16 Apr 2019 09:54:40 -0400 Received: from mail-vs1-f54.google.com ([209.85.217.54]:40526 "EHLO mail-vs1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfDPNyj (ORCPT ); Tue, 16 Apr 2019 09:54:39 -0400 Received: by mail-vs1-f54.google.com with SMTP id f22so11560688vso.7 for ; Tue, 16 Apr 2019 06:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=PUEimrDkDNjafWQNoeSSGu0JOmhZ7XGlyAON9WIKy9c=; b=fSBsnJzcu8yFjp0TO0gh6UZqnpxN7tTfPVZKCI8ZbNVlCUDn+4kPvckitE1ZZV2MVt 7lg6id8SXC4kIrf27XzbGa9IP25HlKfVs4h900FATMyfgmW5C6KIknKH50QcVvAualbz SmPYFkVauvdvaEFAeUA+zsmDr30a8//WU4B4uLBRz79tQk2ziyg0u5r+ve4QLzbjHNT6 6FrtaZk4AGv+H6KVtOeC496RTPMUDvASPowWl1/vzLsph51PRYRGgVfKFOVfP4Vr5nIX A38ihMmYe+TztWS8xJKbc/5Dz/a2TpLzMb9wwKBZcCdIEPxP1XA7QPBf93IoicrCfGXt HZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=PUEimrDkDNjafWQNoeSSGu0JOmhZ7XGlyAON9WIKy9c=; b=C13RJYOTmf0iI6c6g6V9xkIuW8MFzOKFSAJljWtUSmwRenTN7ZKnj79I2QeeHHVnMm 6pWXnv9nT6MAkDR+AGWo7F/yQ2JwkGo70oAXtjHVspa4E0Q67q3MNl53I5dV+gwBdJSB aa/H1/9ogcrqG82cJs4wyce5ilwrsEzRJAvnWBHifqTzxPdKLrALssbL50H/ITnQ/Aol eLI+czklx1rO4DS0/jrlnu8HbhT/gJcFZ6EW5vl3oqkzml4NlKgYwoO1iWdFk+GVqAuS KDr7WAWI2SUpFwAxF1MhK1mKRkdYHmTCDxYNpCnRbC6XOMM6d/38MsJs1GO60I+041EX ZxvQ== X-Gm-Message-State: APjAAAVvGARdWiqTsitE3qm85c9cOdT76jrcYkIBxC+1GoLL1aUdK8by GxeUwPPd9oVW8ADdqCywU2SAvuCqHDlhRxvhZE0Zcg== X-Received: by 2002:a67:76c7:: with SMTP id r190mr13842839vsc.196.1555422878707; Tue, 16 Apr 2019 06:54:38 -0700 (PDT) MIME-Version: 1.0 From: Kees Cook Date: Tue, 16 Apr 2019 08:54:27 -0500 Message-ID: Subject: BPF RNG To: Daniel Borkmann Cc: Hannes Frederic Sowa , Alexei Starovoitov , LKML , Ingo Molnar , "Reshetova, Elena" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, In looking at prandom_u32() users, I noticed that BPF uses its own state variable with bpf_user_rnd_u32(). It appears that this state is never reseeded like regular prandom_u32(). (See __prandom_timer().) Is this intentional, or should reseeding be happening? -Kees -- Kees Cook