Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3255808yba; Tue, 16 Apr 2019 07:46:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVnZznF7CROE96ulaYN5UPViCKN3m5fJT7Y6j5Rhd9snPG1ZhP61a2sbBYY+ymtt2/+ywW X-Received: by 2002:a63:7154:: with SMTP id b20mr77537759pgn.359.1555425997769; Tue, 16 Apr 2019 07:46:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555425997; cv=none; d=google.com; s=arc-20160816; b=SP0Hx+X4337nB73xfeGCACTcXiYkps45AO4y0eNpFgU61ptymJd/+56BQn5R92dZi4 IUab28V3ko9uT3OaigCHYVsrQ1c2bBaUV1uYz3Bn/DlCqVanEh0oYch+7HGhbyln82LG jX5cvp1PB3exd/3BQd8tcxnguc0TYa0/lKZ5pbMfwrMpRuiQFyT7Yl9qUoqR+T68dX2f f2mdwcqUQWRiY4oDABkN+i4DpHKtALXbpapt8jEtnNKXE+W5Yy++l14cUZe0xTr4n4HN Pq/Ta2uiDhrcv/lzLfdV7svIFsGK+52oDeSKE0j1Su3mXrFJJSjYUhQDO2nBWw4IECdC +R8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+ahXP4g3my9l6v2MMO7HaUTHj2YfFCOiVjYVSCIvxiE=; b=cszX1l6/lZ5hy9F48Ab2dTTRK8kJ/6QZElCjVJ0N1KlbjSY2R2ugIaSoend3L9wRp7 gzX8D/3sGOCGlmQs1/uMN5bFoDcDqNbPlXAwulro0HXKDv2LWQjPUPh/M/1G4ubNKyQh Lb+A83Pb5gnZl6iVt5qNm2USw7pMZtLZ4UpSRrbtts2yxsgNokqSjB6cicctedHKudEO WtTjmpIj+JHZUS3hDC++SMWt3RXZjWxoktOJQXD4Z3FlVMFS6zWhhBhjjrf5IHgJL+AT nJ+4JnfhtxL6x7LV1S4fYgtUpqsxWFVuU5YqMTKRqk1PqTUm3ooVg3v2D7du+S3ltpci OEWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w71si38958672pgd.470.2019.04.16.07.46.21; Tue, 16 Apr 2019 07:46:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729685AbfDPOoQ (ORCPT + 99 others); Tue, 16 Apr 2019 10:44:16 -0400 Received: from muru.com ([72.249.23.125]:46280 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbfDPOoP (ORCPT ); Tue, 16 Apr 2019 10:44:15 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1CF4F8081; Tue, 16 Apr 2019 14:44:30 +0000 (UTC) Date: Tue, 16 Apr 2019 07:44:12 -0700 From: Tony Lindgren To: Pavel Machek Cc: Aaro Koskinen , linux-omap@vger.kernel.org, Janusz Krzysztofik , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: fix early boot crash when LED support is disabled Message-ID: <20190416144412.GF2839@atomide.com> References: <20190415233732.3612-1-aaro.koskinen@iki.fi> <20190416071420.GA14538@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416071420.GA14538@amd> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek [190416 07:14]: > On Tue 2019-04-16 02:37:32, Aaro Koskinen wrote: > > When we boot with the LED support (CONFIG_NEW_LEDS) disabled, > > gpio_led_register_device() will return a NULL pointer and we try > > to dereference it. Fix by checking also for a NULL pointer. > > > > Fixes: 19a2668a8ae3 ("ARM: OMAP1: ams-delta: Provide GPIO lookup table for LED device") > > Signed-off-by: Aaro Koskinen > > Acked-by: Pavel Machek Applying into omap-for-v5.1/fixes thanks. Tony