Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "zhuyan (M)" <zhuyan34@huawei.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "anton@enomsg.org" <anton@enomsg.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "zhuyan (M)" <zhuyan34@huawei.com>
Subject: Re: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb
Thread-Topic: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb
Thread-Index: AdT0UyQ3T4H9dWZMSiWXXsWu+YIp3w==
Date:   Tue, 16 Apr 2019 14:48:40 +0000
Message-ID: <c2bfec411cb742ec9aca66d278cca93f@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 16 Apr 2019 at 11:45:45 +0200, Greg KH wrote:
> On Tue, Apr 09, 2019 at 10:37:12PM +0800, zhuyan wrote:
> > In function fhci_queue_urb, the divisor of expression 
> > (urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe,
> > usb_pipeout(urb->pipe))) may be zero.
> 
> How can you hit that?
> 
> > When it is zero, unexpected results may occur, so it is necessary to 
> > ensure that the divisor is not zero.
> > 
> > Signed-off-by: zhuyan <zhuyan34@huawei.com>
> 
> I need a "Full" name here, not just a single name.  Whatever you use to sign documents is good.
> 
> thanks,
> 
> greg k-h

In function usb_maxpacket, when ep is NULL, its return value is 0.  
Then, in function fhci_queue_urb, the divisor of expression  
(urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe, usb_pipeout(urb->pipe))) 
is zero. It will lead to unpredictable results.

Thanks!

Yan Zhu