Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3289176yba; Tue, 16 Apr 2019 08:23:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqyAntG9lfoFYFy79ZrZpd4C3RqeXxv+pbSafzP3kLci4nl/s+zhpcqoxrX0qJnXJTkEBOki X-Received: by 2002:a65:4083:: with SMTP id t3mr50955840pgp.332.1555428198375; Tue, 16 Apr 2019 08:23:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555428198; cv=none; d=google.com; s=arc-20160816; b=obcOXMTxdTs3k0Hr83dFXEsu0HciH4g2ks7tOughNagFb5Nq2v2qH8Vrws6lZd86xk gCTPl/0FhVw3hOwO1jOOP/D2p2R9Y150tYYkYEHIcfXkByrmMMR25KHu+Nl47J/Vh5hF bIP5oFptMqVD91KNjC1CXFJLCfYPUAsLK0uw6Cpkj5BniKsff/w9Qub2Pbo1n8vX2OzP FDyj5FqK7FNvLer7s0wFV3vnoEMlY31krPbjaGnxT2fO7dc1edOpCLTKZUhbHm3oeFsN MQ1HvE1aVuEeTl/SA1ppjVbngff9q73uka3mv5EgaV1I2xx9rOCidFwwKlxl9LngzJSg ixcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vLLuQHa6ZN5VzEa4AG3xkGqyCrlPA3KYw6BHJ1DL9Ag=; b=iCOovhd8bLD0W0JhtL5wYWJq2GzA3dqFqs/0HHojWfiZg+PT85PSTWiolW44UK+Hnc 2ozYZ+cUWArA9Mfotvvq4nYDtN2ckFg2miLmLTnMGzZ0nqahgWPSDNC3f0AkUOqwikdC gDnHxzgYo3mNNYrqmah+73rZyKx3paSm80bnUX5HnW4lPyBD2CB1d0K6UrpcCkmsv3nq L9rEUdqNj06QOs+MVPxrSmxH3rJ0j3a3mn2sXev8wBHME8LBj5uYCIZt9CbjUhHty1sW f7f49BB7sLu+v3IYxQbw4s/Ficv1izGqpWuVXtl13/zhT58Y7Hw3XMvRakn4DRMjZaQ/ QP5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QNLFn50U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si31384718pfh.87.2019.04.16.08.23.02; Tue, 16 Apr 2019 08:23:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QNLFn50U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbfDPPVK (ORCPT + 99 others); Tue, 16 Apr 2019 11:21:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:36110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727902AbfDPPVI (ORCPT ); Tue, 16 Apr 2019 11:21:08 -0400 Received: from localhost (lfbn-1-18355-218.w90-101.abo.wanadoo.fr [90.101.143.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E306B20656; Tue, 16 Apr 2019 15:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555428067; bh=6557F7FAe7Nccx60JnRafhCiWm1l+A2CQfVigujl1FY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QNLFn50U8/ZbkzDCX3vClVO1Awzj05VaHDIUITg5yLUVF2nTmRUYafgbjzdp++cay +OwW+sEytUGtqhvwFtOveiEl1lMk3U20Gyf3i78YT3hNfG3fdSASfB/8oLCOPeE6bw /EYfqaeEKn8rJviwv+Y5FGQ30/c6j2LM+ax4FoPQ= Date: Tue, 16 Apr 2019 17:21:04 +0200 From: Frederic Weisbecker To: Peter Zijlstra Cc: LKML , Ingo Molnar Subject: Re: [PATCH 4/4] locking/lockdep: Test all incompatible scenario at once in check_irq_usage() Message-ID: <20190416152102.GA3501@lenoir> References: <20190402160244.32434-1-frederic@kernel.org> <20190402160244.32434-5-frederic@kernel.org> <20190409130352.GV4038@hirez.programming.kicks-ass.net> <20190410022846.GA30602@lenoir> <20190411104632.GH4038@hirez.programming.kicks-ass.net> <20190413003543.GA9544@lenoir> <20190416112009.GT11158@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190416112009.GT11158@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 16, 2019 at 01:20:09PM +0200, Peter Zijlstra wrote: > On Sat, Apr 13, 2019 at 02:35:45AM +0200, Frederic Weisbecker wrote: > > On Thu, Apr 11, 2019 at 12:46:32PM +0200, Peter Zijlstra wrote: > > Same here: > > > > As above, we clear bitnr0 (LOCK_*_READ off) with bitmask ops. First, for all bits > > with bitnr1 set (LOCK_ENABLED_*) , add those with bitnr1 cleared (LOCK_USED_IN_*). > > And then mask out all bitnr1. > > Ha! you failed to spot my failure, all the above should be bitnr0 of > course :/ Ooops, right. > Find updated below. Very good now, thanks a lot!