Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3305123yba; Tue, 16 Apr 2019 08:40:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhLA67EIXDApx1M35DyaIj/BiMGwcejwjRd7Kk1YYfETpDqf9yFNDyleMAoHHf+D1043A8 X-Received: by 2002:a65:64c8:: with SMTP id t8mr76411499pgv.248.1555429255294; Tue, 16 Apr 2019 08:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555429255; cv=none; d=google.com; s=arc-20160816; b=z54SDjQx/tJ2JZoSYCd70ZMnoLMvZVY1eit/LAsR5BaF6NdhpbE4HfAXohuZMWUTGR dbNnIOSZftDxokbjvKfsZPC7u2YI7U36ZqrWAMpSIsez1wXXeMPVruh61ZpGaw7sbuUn tW1R1nr+qjYdft0sYVF+uMNfTsAS3HuUAIgqIvTvJCvaYd9Ujqnz/5oAuJG+345QWkXW 5sVA8pOZCULZTCQc10yuOkIWT0nWVSz9D90bj2xJNRSqOzh+2GPGZiTnKspk3mVOJakP p8w8dDqHfWUWCyrqHLjLIMat3RcV91f/dZPZDTAYxMryBJIx5gpFkm5Ufm4C6moUzF66 punQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=INIycX6BY/8l1v+SJGb74HEJYYo8BeU0ZwECHq2wKvk=; b=qdj6O7y0QCNS/lIbR+AfRGfTp9a4FdXMP/rW4Kf94cjj2trkjWNHJ1Y/P2DCn5641i mf3prLHeDWOC+kj8r4zNzfiFPfyp32D+toABh55cFS6ARa0eStJZ9RY/C6gkDjVQgMeh l1GDWtSK6BmCp2ypSKOEJ/hdr8gr2wOz7MlDOs4KQ8WcCOVHBmSLs0M+PCNCuecIZJP9 IMt4/d4Cf7nbr5X/JsPFmPzLH4qGVxNt2WOgh8Am6rlalMBjskRjhTnuPkxyDld2ceyp +nMq/XaThB4Az92dJEXpdn1Wddg50Oxp6uQvJ8Xr7H+MG9cn4WLuC83kmXNNIqmwoZIc 4O5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=h31t181S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5si47783480plr.5.2019.04.16.08.40.38; Tue, 16 Apr 2019 08:40:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=h31t181S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726178AbfDPPkC (ORCPT + 99 others); Tue, 16 Apr 2019 11:40:02 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56588 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbfDPPkB (ORCPT ); Tue, 16 Apr 2019 11:40:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=INIycX6BY/8l1v+SJGb74HEJYYo8BeU0ZwECHq2wKvk=; b=h31t181SMb9HuGzAIFD7t8wSq OWxUFxHn7lS+S4+bmQVgotWbqiUEP6MBjGGUeOWehcB8o0NaIhIe3HBGB03n23JYcwUW+684qwg0o fix0bZYC6+yW/IlG/hdTvD8r0XJO2EiYZW0cFi99KY8iEvkoD0GGx6+0Ip3DvIjJNhFro=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hGQBY-0007W0-Hd; Tue, 16 Apr 2019 15:39:48 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 1C8FA1127BAE; Tue, 16 Apr 2019 16:39:48 +0100 (BST) Date: Tue, 16 Apr 2019 16:39:48 +0100 From: Mark Brown To: Vitor Soares Cc: linux-iio@vger.kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, lars@metafoo.de, knaack.h@gmx.de, jic23@kernel.org, lorenzo.bianconi83@gmail.com, bbrezillon@kernel.org, rafael@kernel.org, gregkh@linuxfoundation.org, joao.pinto@synopsys.com Subject: Re: [PATCH 1/3] remap: Add I3C bus support Message-ID: <20190416153948.GF4834@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: X-Cookie: Who messed with my anti-paranoia shot? User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 15, 2019 at 09:19:39PM +0200, Vitor Soares wrote: > +++ b/drivers/base/regmap/regmap-i3c.c > @@ -0,0 +1,62 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates. Please make the entire header C++ style so it looks more consistent. Otherwise this looks good modulo Boris' comment; I'm fine with leaving extra modes for later so long as they can be introduced without disrupting existing users so the only question there would be if we should name the init function in some way that's specific to the I/O mode being used here. --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAly190MACgkQJNaLcl1U h9DH+gf+OZQm2X5EmdYvxQVJJHvMkOfr4/bdMEClhyqxihcdEuHsGX7QDR1nOmoV nF4/QXoiYl9So2AGriD74jcq2IZzBvw5dEKuLCHus0TOF5hLFQjtdLuRdtxEP3y9 V7Q3aioi/RW8ukOjDRFBVXbzKiMwQ8QNM0P+0cZWjrp5HEG6t0qodhI6TKyq6X3g ngnb7r1L5TZxgcE8oT7J17TowCc0jPqCj8DQMiDM+EOGDftnXXp8KK8wPXc/QwoB xvuNoC9kIrbgIjbqyvbNYDkquIukHYOqzYVhLFm10WLEUySc0ImSh1JrDMn3WAoc Jdm4iJV3Nc5Nn2c1BpBlHQ4D4iaWKg== =bbEG -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8--