Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3322870yba; Tue, 16 Apr 2019 09:03:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHCY4eRHoN+CN/yi41n9cZSE0Wu4ky9Yt5PGvOMgrjOSVW3n+u10HYY7euR0XAz9nkRbOX X-Received: by 2002:a63:5149:: with SMTP id r9mr74214535pgl.177.1555430598510; Tue, 16 Apr 2019 09:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555430598; cv=none; d=google.com; s=arc-20160816; b=h12ikD5bUYmbO2ERw3oX5Yfj1aONhLh+oiNoHJHB2uzCCxbWgtkvLvkCThn+aOuG/6 1WIb+5yrYO69+C4+sDBtpnC5lDn4V/Tz4ZzRHoQ7/QN6KvEUQyWf7nTL9pN6cZCKbH4d GjTpnv80cD3DQs1IHrp7seOYQEB9IyZaa9JHoFTeJvUaUxcXDYazpTEsCW7Bp11XYmXy J1m/R7J24DUcNXrWO3HGxWqpJX16uz/qYzSGn00upeuYaJdjNrmX+pnAL27nKbf2XUQS bsEHgQ3mAFqMSQ7iquVhe1Wh5OGGj6ZY/5vkXXvBYt+OgNfXqOIiceJJ4fpZioyoTOkq yOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=mFuZmGGW89s9+UVIxWNHio64Zs6B1FDjLUApby3oGVE=; b=JGq+HwzjKTuAYqTIsCYgkEPWbWlugMRJcrX5n/KLVbLriAE1+mj1+zypIdQOHcGPFJ rEP7OA7Sajn3VjeqGnzbjzg4hghQBAckIb+UgnsWJbWOikSUfbeMb59uIzspqEisW5ro OwsBgDAknF6ISrQB4soyhjogdIK1KmKpjrTjCg9kHRXwTdkmJGiL/5shHh7AZUdYBeeH u6gtCjIL8aFkaJfplT8mgXcSoYYBBYb8bUAi4FZiCF8U9IsRTVxm2QGt91wqCe7B5GPg A76k0qXUsiVnh6gMWibWSlfno6x6IWgN9hZTcEQZHzLi1jcCN/lWLJfPVjBw2GhylFXU s+OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12si48645277pgh.303.2019.04.16.09.03.01; Tue, 16 Apr 2019 09:03:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730004AbfDPQB4 (ORCPT + 99 others); Tue, 16 Apr 2019 12:01:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44340 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729984AbfDPQBx (ORCPT ); Tue, 16 Apr 2019 12:01:53 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8AE2830842A0; Tue, 16 Apr 2019 16:01:52 +0000 (UTC) Received: from krava.brq.redhat.com (unknown [10.43.17.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 405005D71B; Tue, 16 Apr 2019 16:01:50 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Andi Kleen , Adrian Hunter , Song Liu , Alexei Starovoitov , Daniel Borkmann Subject: [PATCH 06/12] perf tools: Do not erase uncovered maps by kcore Date: Tue, 16 Apr 2019 18:01:21 +0200 Message-Id: <20190416160127.30203-7-jolsa@kernel.org> In-Reply-To: <20190416160127.30203-1-jolsa@kernel.org> References: <20190416160127.30203-1-jolsa@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 16 Apr 2019 16:01:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maps in kcore do not cover bpf maps, so we can't just remove everything. Keeping all kernel maps, which are not covered by kcore maps. Link: http://lkml.kernel.org/n/tip-9eytka8wofp0a047ul6lmejk@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/symbol.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 5cbad55cd99d..96738a7a8c14 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1166,6 +1166,18 @@ static int kcore_mapfn(u64 start, u64 len, u64 pgoff, void *data) return 0; } +static bool in_kcore(struct kcore_mapfn_data *md, struct map *map) +{ + struct map *iter; + + list_for_each_entry(iter, &md->maps, node) { + if ((map->start >= iter->start) && (map->start < iter->end)) + return true; + } + + return false; +} + static int dso__load_kcore(struct dso *dso, struct map *map, const char *kallsyms_filename) { @@ -1222,7 +1234,7 @@ static int dso__load_kcore(struct dso *dso, struct map *map, while (old_map) { struct map *next = map_groups__next(old_map); - if (old_map != map) + if (old_map != map && !in_kcore(&md, old_map)) map_groups__remove(kmaps, old_map); old_map = next; } -- 2.17.2