Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3418343yba; Tue, 16 Apr 2019 10:55:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxCfNqyXfgNY4sB33MbTgpTz0VM9e589ShuZNZLCnEHzNwHZIZaYtO1N/I1pUauwojKqBPG X-Received: by 2002:a62:e816:: with SMTP id c22mr84350201pfi.54.1555437319159; Tue, 16 Apr 2019 10:55:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555437319; cv=none; d=google.com; s=arc-20160816; b=yYamPlYtu5q0Ri963Y7dOhPZgmRkqDKvRQCpMx71vy0pxc8bzCf1O6WzC/LLCbzxp5 pQh0heRhYyScZ/jyuhLCqvshmmP3ifBAEJ2XxuU752Yc39C0TFwQ/Tc+WMYseq+IgkgB vBZ40zhFxScX9hXOa6gXSEeVEhjc+UdaT3qH5t0C98eJQyCOEZ290oxuSs/uQYwCc32R wD9HYkQGxkuNaaTKXSoBVA8tW2h7ACf3gPS1sunM3EgVcGk9SN3C6Qrq+RBLTbM81VE/ x4zikRRHJ3AAmWMa3cBhOz8iHSSr8IOV5SbAKTu3LIiXmBmeGrVLGnv3iPiMuCznr3sz 4Xrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3F2bOCtmHB8Cy2EkSC7cssi6ct9/LziqZ6qSu75PPlY=; b=cCFPL97qc2lNBktxUhLTKkZwlWZFZ1IKHCijoNry6SeBwCT+nTT8IC491SualChDzg gjNn0QzARY7M2lw6WtTlGgoGbyKvhI5qzKHSraMGBzjWjKgylVsLCnTFnY2FN4UxQFhx 7tHSjZobJmYpXd0B3r4fkpyrkpdhGXK4PByRTCqoRPtIWmh6FM59bd0jI8N0+moJTY/m 3OTdauqm208RN8qk0Lu4pv2UuVjeQolmEuT3BSBLa1vwPHu+9iz5FIXlqhAMmC299Yob s1pF8RmwuUVItgRkF+i2jWfR5VapZdS8odju41Te3iYGBRIap36sf3BM6K4HtVfdfP45 RCBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si48081645pgh.356.2019.04.16.10.55.03; Tue, 16 Apr 2019 10:55:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730549AbfDPRyJ (ORCPT + 99 others); Tue, 16 Apr 2019 13:54:09 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:57698 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730350AbfDPRxt (ORCPT ); Tue, 16 Apr 2019 13:53:49 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hGSHE-0005Zt-6k; Tue, 16 Apr 2019 17:53:48 +0000 From: Al Viro To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC PATCH 54/62] ext4: make use of ->free_inode() Date: Tue, 16 Apr 2019 18:53:32 +0100 Message-Id: <20190416175340.21068-54-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190416175340.21068-1-viro@ZenIV.linux.org.uk> References: <20190416174900.GT2217@ZenIV.linux.org.uk> <20190416175340.21068-1-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro the rest of this ->destroy_inode() instance could probably be folded into ext4_evict_inode() Signed-off-by: Al Viro --- fs/ext4/super.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 6ed4eb81e674..981f702848e7 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1107,9 +1107,8 @@ static int ext4_drop_inode(struct inode *inode) return drop; } -static void ext4_i_callback(struct rcu_head *head) +static void ext4_free_in_core_inode(struct inode *inode) { - struct inode *inode = container_of(head, struct inode, i_rcu); kmem_cache_free(ext4_inode_cachep, EXT4_I(inode)); } @@ -1124,7 +1123,6 @@ static void ext4_destroy_inode(struct inode *inode) true); dump_stack(); } - call_rcu(&inode->i_rcu, ext4_i_callback); } static void init_once(void *foo) @@ -1402,6 +1400,7 @@ static const struct quotactl_ops ext4_qctl_operations = { static const struct super_operations ext4_sops = { .alloc_inode = ext4_alloc_inode, + .free_inode = ext4_free_in_core_inode, .destroy_inode = ext4_destroy_inode, .write_inode = ext4_write_inode, .dirty_inode = ext4_dirty_inode, -- 2.11.0