Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3421414yba; Tue, 16 Apr 2019 10:59:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDIcvPwhtm5/MQDwZ1d9WCJVOFvFx7066PGWFg8TfftwqK51uj3GRnSylcAeITwUMTdE0E X-Received: by 2002:a62:305:: with SMTP id 5mr83423146pfd.65.1555437547897; Tue, 16 Apr 2019 10:59:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555437547; cv=none; d=google.com; s=arc-20160816; b=Q6tJVmCFxcR2FcH66WFrtG7NNaQkM9HeVxMVXv62UtQhNNm2eHT1Xc6gbsr+fv1hnO zEk6DZVT5RwT8izMFP2ODRMroVY1M2lunvxK8lX1G+WabUNUkXFZWQLiqY0yql+8NxSO MNt5HWhz3Lp9bTADJtFADGCnGjPi4YOUAB2xjQQrcrtdzawzu5qyq9izaN6E5Yhd+IFg V2I+Q2iSmvVF2SjiyI9WnCG1tpW3qTEqdMr3OXF8o0cx//EtQmKMQ7RM8UJikbYplqav 6v0B3mN29E0SUJItyapu/ELEoFa5dFcrnqnYttR9EFeyp+8S62WkAafyCuHADGe6AwVS vU4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cB0vGuNuPC6Ru3ye9GpBJvOP63+SZtbozRGA4PflzxI=; b=znXIcj+lYoqaLhWxpXSOHEz3aPy1inPnskE3A1Ikz+zTTiSu7Ef4o6cEeRB5CAswsy bio/g31MERbFny3Y7l68NgjAFOu0pTLOSSic/5UbH2FscRStZjzZRUNtGJasUcEf4b/K HzwzLEVXY2oD0pEOhHn2HOBOeZ6YdICk5AmysD5RSFuCUovVzOlVxinpvuH8kLjG/YGd 5Gz0a/YT8uDakOJIJADAtQBRdPds40ei6Nq1QLS9rN6Z8rqgFCO7ggNx5zffJpralMnR suD8wxkRJ0WGeExM6ojK0d8qndh9RHHrH7d7n97G27qKSd6rMWlGN23qTXik75+pKTYp hEtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k76si35687750pfj.199.2019.04.16.10.58.52; Tue, 16 Apr 2019 10:59:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730556AbfDPR5o (ORCPT + 99 others); Tue, 16 Apr 2019 13:57:44 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:57594 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730271AbfDPRxq (ORCPT ); Tue, 16 Apr 2019 13:53:46 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hGSHA-0005XB-Do; Tue, 16 Apr 2019 17:53:44 +0000 From: Al Viro To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC PATCH 28/62] nilfs2: switch to ->free_inode() Date: Tue, 16 Apr 2019 18:53:06 +0100 Message-Id: <20190416175340.21068-28-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190416175340.21068-1-viro@ZenIV.linux.org.uk> References: <20190416174900.GT2217@ZenIV.linux.org.uk> <20190416175340.21068-1-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro kill an extern that went stale 9 years ago, while we are at it... Signed-off-by: Al Viro --- fs/nilfs2/nilfs.h | 2 -- fs/nilfs2/super.c | 11 ++--------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/fs/nilfs2/nilfs.h b/fs/nilfs2/nilfs.h index a2f247b6a209..42395ba52da6 100644 --- a/fs/nilfs2/nilfs.h +++ b/fs/nilfs2/nilfs.h @@ -252,7 +252,6 @@ int nilfs_ioctl_prepare_clean_segments(struct the_nilfs *, struct nilfs_argv *, void nilfs_inode_add_blocks(struct inode *inode, int n); void nilfs_inode_sub_blocks(struct inode *inode, int n); extern struct inode *nilfs_new_inode(struct inode *, umode_t); -extern void nilfs_free_inode(struct inode *); extern int nilfs_get_block(struct inode *, sector_t, struct buffer_head *, int); extern void nilfs_set_inode_flags(struct inode *); extern int nilfs_read_inode_common(struct inode *, struct nilfs_inode *); @@ -289,7 +288,6 @@ static inline int nilfs_mark_inode_dirty_sync(struct inode *inode) /* super.c */ extern struct inode *nilfs_alloc_inode(struct super_block *); -extern void nilfs_destroy_inode(struct inode *); extern __printf(3, 4) void __nilfs_msg(struct super_block *sb, const char *level, diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 26290aa1023f..5729ee86da9a 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -155,21 +155,14 @@ struct inode *nilfs_alloc_inode(struct super_block *sb) return &ii->vfs_inode; } -static void nilfs_i_callback(struct rcu_head *head) +static void nilfs_free_inode(struct inode *inode) { - struct inode *inode = container_of(head, struct inode, i_rcu); - if (nilfs_is_metadata_file_inode(inode)) nilfs_mdt_destroy(inode); kmem_cache_free(nilfs_inode_cachep, NILFS_I(inode)); } -void nilfs_destroy_inode(struct inode *inode) -{ - call_rcu(&inode->i_rcu, nilfs_i_callback); -} - static int nilfs_sync_super(struct super_block *sb, int flag) { struct the_nilfs *nilfs = sb->s_fs_info; @@ -686,7 +679,7 @@ static int nilfs_show_options(struct seq_file *seq, struct dentry *dentry) static const struct super_operations nilfs_sops = { .alloc_inode = nilfs_alloc_inode, - .destroy_inode = nilfs_destroy_inode, + .free_inode = nilfs_free_inode, .dirty_inode = nilfs_dirty_inode, .evict_inode = nilfs_evict_inode, .put_super = nilfs_put_super, -- 2.11.0