Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3492393yba;
        Tue, 16 Apr 2019 12:29:21 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwTjfImApkXxaLkdMUEoNWrwNmxQNSs0JwrkcWXqPoL8DvHehJ2ph8ZcRX/P3CD8IULn+I1
X-Received: by 2002:a62:b40b:: with SMTP id h11mr85068144pfn.133.1555442960933;
        Tue, 16 Apr 2019 12:29:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1555442960; cv=none;
        d=google.com; s=arc-20160816;
        b=w9EM3q6mXzxFRWPDhPS8lsVczRCKi+R4b077yd36f8hbBJWEns6NYJG/iLUM90sXtX
         Yp+m5ZwIUi4k8RyfL/4cx8ray1s2JlYYbKa7TxH7hjK4Yze+Dwf6fQysfcR5pKyOVV9J
         qlSNI8URshSeS+pb4E5Bw6OzEGL+CB8jZU3KXw9gDqy3oUoCq8R2GSmjn3kNjvIMnCbt
         vu1TF9/H7mfDRSYLj+vmG4bJTIkVdqkETpfRtTLqYaeSVK7ID5/l7ap/IIijWUrbqi92
         LkniLftXbM9yBHjZ+c9u5d14HfC83wKVvAOd1h/9EVqS3NHmR3v4nuraBIj73kDc8X7Q
         wqPA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:mime-version:references
         :in-reply-to:message-id:date:subject:cc:to:from;
        bh=d2fraG+ooOhN52P8jEntvECSgoDTCGy+5RiecCjDr60=;
        b=sHOegKTDM4Lt1HzD3ZnV3w8mc08vuCStlPIitc4yZWSstAIHvpAg5e2JAYv1Rl4/O2
         IHbEbp2FdHXtAV2hZ22cSuESEX33TbsZlAEiji8ku0ZtdXkpzT/LCKvL+x4a4TgNyIHH
         sS6R0qfMwbtDqd9O1ZL0zlbrrwi80fitf6Kxy4DzRCB6y3xIwPKFE/rp0qJUquyoR2jx
         ECv8t1V78TlFcKzOMQ3UYmxzoXSEHMUYv5zjApedHnTQltXyGLRNGmVfmeHGuemwEVTn
         s3Nk+zi5Jf4XHScOJvhCmQWf0S7mwKikFmVrJAnU1zJdd9Cm+33e9G5Z20d1c1Vv/D32
         3Tow==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=qWzzIBLS;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f1si50672105pld.32.2019.04.16.12.29.05;
        Tue, 16 Apr 2019 12:29:20 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=qWzzIBLS;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730402AbfDPT2L (ORCPT <rfc822;rruigrok1@gmail.com> + 99 others);
        Tue, 16 Apr 2019 15:28:11 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:12040 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727997AbfDPT2L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Apr 2019 15:28:11 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5cb62ccf0000>; Tue, 16 Apr 2019 12:28:15 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 16 Apr 2019 12:28:10 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 16 Apr 2019 12:28:10 -0700
Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL104.nvidia.com
 (172.18.146.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 16 Apr
 2019 19:28:09 +0000
Received: from hqnvemgw01.nvidia.com (172.20.150.20) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend
 Transport; Tue, 16 Apr 2019 19:28:09 +0000
Received: from vidyas-desktop.nvidia.com (Not Verified[10.24.37.38]) by hqnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121)
        id <B5cb62cc50000>; Tue, 16 Apr 2019 12:28:09 -0700
From:   Vidya Sagar <vidyas@nvidia.com>
To:     <bhelgaas@google.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <kishon@ti.com>, <catalin.marinas@arm.com>,
        <will.deacon@arm.com>, <lorenzo.pieralisi@arm.com>,
        <jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>
CC:     <mperttunen@nvidia.com>, <linux-pci@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <kthota@nvidia.com>,
        <mmaddireddy@nvidia.com>, <vidyas@nvidia.com>, <sagar.tv@gmail.com>
Subject: [PATCH V3 04/16] PCI: dwc: Perform dbi regs write lock towards the end
Date:   Wed, 17 Apr 2019 00:57:18 +0530
Message-ID: <20190416192730.15681-5-vidyas@nvidia.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20190416192730.15681-1-vidyas@nvidia.com>
References: <20190416192730.15681-1-vidyas@nvidia.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1555442895; bh=d2fraG+ooOhN52P8jEntvECSgoDTCGy+5RiecCjDr60=;
        h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer:
         In-Reply-To:References:X-NVConfidentiality:MIME-Version:
         Content-Type;
        b=qWzzIBLSXChGgUpnOvcx/QUWgZpzZFCZnpPPqfxuQkmAUIZ4hAWBGju4NWCmpx//W
         DeqHAd/pzgHfAybLf6yO8nY140gYhd7s7yqdEGOlVfQpqzPDGLFujGVCneJrG8ABZH
         n/8zcIiDfS0w5oyyf1f93P2/JVhR5ck0O3BK9PdAGTSQowmdUsYnkTcSsTjg8nOW/d
         Jzsi5MUblEpQ3PpVpdsddKT6TdYlszE7/ApPhBp9oU2gAm7h3rA0UPPZVeNEmWJTMS
         9zdrIxt0xXOBpoI97tpDW10m+3JhpPprBK3UhQsmNrCbYq8OCDtm1cYChA+HDV83Hw
         AEyLEYvzqKtBQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove multiple write enable and disable sequences of dbi registers as
Tegra194 implements writes to BAR-0 register (offset: 0x10) controlled by
DBI write-lock enable bit thereby not allowing any further writes to BAR-0
register in config space to take place. Hence disabling write permission
only towards the end.

Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
Changes since [v2]:
* None

Changes since [v1]:
* None

 drivers/pci/controller/dwc/pcie-designware-host.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 2a5332e5ccfa..c0334c92c1a6 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -683,7 +683,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
 	val &= 0xffff00ff;
 	val |= 0x00000100;
 	dw_pcie_writel_dbi(pci, PCI_INTERRUPT_LINE, val);
-	dw_pcie_dbi_ro_wr_dis(pci);
 
 	/* Setup bus numbers */
 	val = dw_pcie_readl_dbi(pci, PCI_PRIMARY_BUS);
@@ -723,8 +722,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
 
 	dw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0);
 
-	/* Enable write permission for the DBI read-only register */
-	dw_pcie_dbi_ro_wr_en(pci);
 	/* Program correct class for RC */
 	dw_pcie_wr_own_conf(pp, PCI_CLASS_DEVICE, 2, PCI_CLASS_BRIDGE_PCI);
 	/* Better disable write permission right after the update */
-- 
2.17.1