Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3554403yba; Tue, 16 Apr 2019 13:56:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxHFJPVX+pIndDWlhBsYolwgi8KwVMjKKT5KFY4xDEYsXqnFS7rhimd5xCnDFDoUxawYz4h X-Received: by 2002:a63:c112:: with SMTP id w18mr79869906pgf.200.1555448188620; Tue, 16 Apr 2019 13:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555448188; cv=none; d=google.com; s=arc-20160816; b=HoR9AWU9LMDA4TZ+W4egG7s7fpp5SYbMHgY/ytsMjyDUcaO1RlrfaFblPQ8E/Vb8c4 eWxkk73vh5XDOsn4Q8nRRK1VeZ7Y0WOjJFPFKBj6BS7ZPfPO0JqIfbynDo1FoOLZCwbV hHFwGGuRKM3KfTUWYgSXNdN2v2fOaQDOWg70Ae38FvK8E5hbHglrQ1Cm9+CXCWRFgEn0 i8w+ztpIxTI5i5T66bjQQUtmO02rzRnmne68q5+RwuQrJUQGDORdu5c1TNdkAU+Kltsh YMU2wblOp9DVoqJB/jK7m4xRbt8JJdpaHytP5nmb3RGHSw+dKkRqsuBROI5ykz20iihW SnnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Tv5FX+PgV80oH32ogynuAnKcyb9VGwSztW/YpWFjenI=; b=ijZGtj9VyWfglgEcjORahunYYDGABcNVzKH8hf1RFpvaNIrEAb8TmCanOteFStwVxU urvP60qpVoMlSt+v0ulES4bUOjTrakUuTtRgMGA9zAGtZ7L88oIs8/d5Rm6x3YZfDAA2 QmgQ/giomSGcHSK2Cp34sKoJgpFAN/7wOfdhec2jZOr6tbd3tkhbpN/3Llw64GvSJ/sv YNKqDrukOYb25ynP0UICZMlWbxqpa6N4mawvIozI3A6eILn45XOwrz/ERQDsZjeZxyf3 0Bxu/3VkmhxrL97LhYaJcbpp9O7kRoVuH1FLWMtSnOUaDibOWuJSzQU2nvTr4O7GmMnX BzRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si33966528pgg.573.2019.04.16.13.56.11; Tue, 16 Apr 2019 13:56:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728939AbfDPUzg (ORCPT + 99 others); Tue, 16 Apr 2019 16:55:36 -0400 Received: from sauhun.de ([88.99.104.3]:52662 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726686AbfDPUzf (ORCPT ); Tue, 16 Apr 2019 16:55:35 -0400 Received: from localhost (p54B332D3.dip0.t-ipconnect.de [84.179.50.211]) by pokefinder.org (Postfix) with ESMTPSA id C12652C3637; Tue, 16 Apr 2019 22:55:33 +0200 (CEST) Date: Tue, 16 Apr 2019 22:55:33 +0200 From: Wolfram Sang To: Guenter Roeck Cc: Jerry Hoemann , Wolfram Sang , linux-watchdog@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wim Van Sebroeck , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/16] watchdog: hpwdt: drop warning after calling watchdog_init_timeout Message-ID: <20190416205533.GB8268@kunai> References: <20190416102515.12269-1-wsa+renesas@sang-engineering.com> <20190416102515.12269-7-wsa+renesas@sang-engineering.com> <20190416203431.GA20072@anatevka> <20190416204814.GA26442@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw" Content-Disposition: inline In-Reply-To: <20190416204814.GA26442@roeck-us.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XOIedfhf+7KOe/yw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > That is indeed a problem: the pointer will be NULL if there is no parent > device (such as in softdog.c). Otherwise it should never be NULL. Okay, this spoils my err_dev solution. So, we probably go this route then: pr_("watchdog%d: \n", wdd->id); ? --XOIedfhf+7KOe/yw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAly2QUUACgkQFA3kzBSg KbYumg/+M6eJR8P4Ytfq/Td9QpEV9hdIc8422y/SRy2fU0eiyJ4zktPc0ZMLLl6D TeXnSwfwn86ABsrRRjDokMRMS/J8PibPn1CNNNe5OG7YZmr2k8fl1K+RBed5Hdcx H4l33imF+wx8PlMmFT5I5WyafSGYJnS5zsA7Yr85g0hGLrg/nDNqubZqnYJnIj5X tHxNc4Nb+wL78bHMX8Lb7ua+1hIZqhT845FALmB7adaWKQlJ+vBnPRf3ZsYH5rC5 gm7+Bkm4W4O0KRROc7z96HtvepArzAQ+OeyL6xUE/i1J13NyUXeRva6zVpGaF7NN HwzQUPXWdwAfS1uGd7+W3FgVSuPhwZ6OBQd1mhoQnG88a1xmHfq6Dmbd7TQp2+kK YSr8F/rHTCb4zoemhpF2jmEc8sJEkA30rpzfOX4QNtW5sg7yvQg8xq00UzxJhYQJ Cn7tgbqhr8Fc8e9HoFG+BNVOv/nPOYuaEokjI0sbAzY7ZihMQQUfAOlrTL3We8X4 oGjksD6+rZmiZ/W3k8c/OhvW157cZziJotyFS5FrEmNf94IkH92QXWgnBpJYVgeM VoRphI/XfcF+Gk96ZVfJ+rL1OsKDQcA8X0UtukD6QZKx9Z+U/6BWtKYETYWRKC+Y LaOR6UNpYdPIOSmDgzZeD0v0efQSPKEQ7PZFWqDjQJQu152RfSQ= =SUL0 -----END PGP SIGNATURE----- --XOIedfhf+7KOe/yw--