Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] x86/resctrl: Initialize new resource group with
 default MBA values
To:     Borislav Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        tony.luck@intel.com, fenghua.yu@intel.com,
        reinette.chatre@intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, pei.p.jia@intel.com,
        xiaochen.shen@intel.com
References: <1554839728-5544-1-git-send-email-xiaochen.shen@intel.com>
 <20190415113405.GC29317@zn.tnic>
 <9e99ed5f-d60a-717c-9322-c6f0b8090d6b@intel.com>
 <20190416205926.GO31772@zn.tnic>
From:   Xiaochen Shen <xiaochen.shen@intel.com>
Message-ID: <2817a0d5-fcaf-dc6c-8b01-4a423bd2e961@intel.com>
Date:   Wed, 17 Apr 2019 05:11:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20190416205926.GO31772@zn.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Boris,

On 4/17/2019 4:59, Borislav Petkov wrote:
> I guess but be conservative when adding too many words to a function's
> name - that might get heavy when reading the code later.
> 
> For example, there's an argument to not suffix it with "_cat": it is
> only called by rdtgroup_init_cat() - rdtgroup_init_mba() will not call
> it - so the path will remain unique anyway...
> 

I got it. I will use the function name "__init_one_rdt_domain()" you 
suggested.

Thank you.

> Anyway, something to think about - I personally don't have a strong
> preference here.


Best regards,
Xiaochen