Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416174900.GT2217@ZenIV.linux.org.uk> <20190416175340.21068-1-viro@ZenIV.linux.org.uk>
 <20190416175340.21068-44-viro@ZenIV.linux.org.uk> <CAADnVQJTQXcxckKMZQ4Lg9R++=618wEsymjTUsVQVMce7CfdZg@mail.gmail.com>
In-Reply-To: <CAADnVQJTQXcxckKMZQ4Lg9R++=618wEsymjTUsVQVMce7CfdZg@mail.gmail.com>
From:   Song Liu <liu.song.a23@gmail.com>
Date:   Tue, 16 Apr 2019 14:34:35 -0700
Message-ID: <CAPhsuW5+7SdYERewTQFjp7pDSwzP9p9j=K71Cf4O96vxCqAf-Q@mail.gmail.com>
Subject: Re: [RFC PATCH 44/62] bpf: switch to ->free_inode()
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Daniel Borkmann <daniel@iogearbox.net>,
        bpf <bpf@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 16, 2019 at 11:07 AM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Apr 16, 2019 at 10:55 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > From: Al Viro <viro@zeniv.linux.org.uk>
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Acked-by: Alexei Starovoitov <ast@kernel.org>

Acked-by: Song Liu <songliubraving@fb.com>

>
> > ---
> >  kernel/bpf/inode.c | 10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c
> > index 4a8f390a2b82..bc53e5b20ddc 100644
> > --- a/kernel/bpf/inode.c
> > +++ b/kernel/bpf/inode.c
> > @@ -566,9 +566,8 @@ static int bpf_show_options(struct seq_file *m, struct dentry *root)
> >         return 0;
> >  }
> >
> > -static void bpf_destroy_inode_deferred(struct rcu_head *head)
> > +static void bpf_free_inode(struct inode *inode)
> >  {
> > -       struct inode *inode = container_of(head, struct inode, i_rcu);
> >         enum bpf_type type;
> >
> >         if (S_ISLNK(inode->i_mode))
> > @@ -578,16 +577,11 @@ static void bpf_destroy_inode_deferred(struct rcu_head *head)
> >         free_inode_nonrcu(inode);
> >  }
> >
> > -static void bpf_destroy_inode(struct inode *inode)
> > -{
> > -       call_rcu(&inode->i_rcu, bpf_destroy_inode_deferred);
> > -}
> > -
> >  static const struct super_operations bpf_super_ops = {
> >         .statfs         = simple_statfs,
> >         .drop_inode     = generic_delete_inode,
> >         .show_options   = bpf_show_options,
> > -       .destroy_inode  = bpf_destroy_inode,
> > +       .free_inode     = bpf_free_inode,
> >  };
> >
> >  enum {
> > --
> > 2.11.0
> >