Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3639078yba; Tue, 16 Apr 2019 16:01:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8jixz3R3dxOmls2BCAjq39dhJBtJeSWTb8cDKc0X5Zer8xl90kdu006GWowqRNqEMBtTU X-Received: by 2002:a17:902:e391:: with SMTP id ch17mr87039597plb.196.1555455690328; Tue, 16 Apr 2019 16:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555455690; cv=none; d=google.com; s=arc-20160816; b=iviDDvbt1Im0T+b5k4blrI0EVg83Z5smT5BdW/1TiLHUVG1GzqUtXnzU20/gF1G9Su t3I7mImSuJ63VMf7n+K11bF2E/GQGdtJw5lywNAq+XvGJb3qoX+sAXA8jQ9+FcjOKSwh 0S8SdmHJQvTDysjtSzcZ6SYDLw+YNv4xfwLwVwQvklPg110lmaq79TVPHk49onaiITXQ qWQ1kyVYt2xyupo1pX1HM2iWlLbNKIOnjfo1tetfAexzcfLoa3H7Mc3LBvA2ZVkCQRV1 nWMPdQnpjZ19p1VfZk/Kk/E1C27S3PCMrFl5JgAMrHjmBOzS39ZKu3/nM3AaNNWQGDA6 9P6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=pFGV7rqbXcBQWd2RZANPquj4TlY5VVx2qUeZImxbEcA=; b=wlAmGYLNAEQ/OndpgBXXhAQEvKRHu4FvysZp5XUBhoQHW/OT4YBaZQ39COrLY/kaUd anurM49dl1QO+GHkbxQqQXVeMeHpha1w6jI1wPHJSgqtFUQQ78dRq13Td1Ce2bzozgCM Bmi33xgUAobXVOau6jyEEMzzxEOJD01CfoiuG/yDeJjvWQkqAD7bhsFoDpuE6+Eem0cI glpJz87ggCARkqgz1lki6kMYKmP556JnRX4YveijMMYVfeM2AR7kB9bBgstVBmbyPCoh Hm/sWnM7WVpoZUe32AVLLh9bb2fFk8Aulwqw78acy/lPUUZlT9hYlo1Rfj+l5PvxGfAA f8xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i63si24271143pli.195.2019.04.16.16.01.14; Tue, 16 Apr 2019 16:01:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730927AbfDPW7N (ORCPT + 99 others); Tue, 16 Apr 2019 18:59:13 -0400 Received: from anholt.net ([50.246.234.109]:54090 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730844AbfDPW7M (ORCPT ); Tue, 16 Apr 2019 18:59:12 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 5DF5E10A3385; Tue, 16 Apr 2019 15:59:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Fj9Bxh6tIVvm; Tue, 16 Apr 2019 15:59:09 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 9A04110A3388; Tue, 16 Apr 2019 15:58:58 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id CEF442FE4633; Tue, 16 Apr 2019 15:58:56 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Paul Kocialkowski , Maxime Ripard , david.emett@broadcom.com, thomas.spurden@broadcom.com, Eric Anholt Subject: [PATCH v2 4/5] drm/v3d: Drop reservation of a shared slot in the dma-buf reservations. Date: Tue, 16 Apr 2019 15:58:55 -0700 Message-Id: <20190416225856.20264-5-eric@anholt.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190416225856.20264-1-eric@anholt.net> References: <20190416225856.20264-1-eric@anholt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We only set the excl (possible-writing) fence pointer and never add a shared (read-only) fence. Signed-off-by: Eric Anholt --- drivers/gpu/drm/v3d/v3d_gem.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 8bd6fa69f566..6873b14a0d38 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -253,18 +253,6 @@ v3d_lock_bo_reservations(struct drm_gem_object **bos, if (ret) return ret; - /* Reserve space for our shared (read-only) fence references, - * before we commit the CL to the hardware. - */ - for (i = 0; i < bo_count; i++) { - ret = reservation_object_reserve_shared(bos[i]->resv, 1); - if (ret) { - drm_gem_unlock_reservations(bos, bo_count, - acquire_ctx); - return ret; - } - } - return 0; } -- 2.20.1