Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] xpad.c: Send necessary control transfer to certain Xbox
 controllers
From:   Mike Salvatore <mike.salvatore@canonical.com>
To:     dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Cc:     ramzeto@gmail.com, marcus.folkesson@gmail.com,
        flibitijibibo@gmail.com, aicommander@gmail.com,
        leosperling97@gmail.com, gottox@voidlinux.eu, frtherien@gmail.com,
        linux-kernel@vger.kernel.org,
        Mike Salvatore <mike.salvatore@canonical.com>,
        mike.s.salvatore@gmail.com
References: <eff45453-f105-d713-1e77-a8fa9850c8fa@canonical.com>
Openpgp: preference=signencrypt
Autocrypt: addr=mike.salvatore@canonical.com; keydata=
 xsFNBFtOHV4BEADAIuSzHrb7cmg24E0MGMRrIPQ/CxdHXs2aQi49SeYR+5HZO7Co9qh6k9/O
 pBsMgq3DflchsKpAEoB125S+riF2F3wdd22aXXQwainKWiGXX0kJRYaNM8uxIFtBEKq+Wco3
 D3QedtG7Is8NNP0e/M0FbN1FlNFJGyIHvm3/bd4g7o7A4AAqlsgD0u9dh24HOlitdJwiQHvg
 c0kPKmpTStpC7l0OxH6/ljlHM3UIlGYLUIQz837jIvr/L3E8Ytgxk5K3jwwvIIhLoHLl4xN0
 3bzzMUAddUnTOCfSp1v7oB/zHUenOIkNi7FSUTU4G3+gC2rigIx0Tijs1GPYjIkUsfNoH0sP
 aBSLmRirGObYlNPWLS2J1mSXBQsFcaIvHF4/vuiQUFudth/vgltdhjI0xsL8pQQ4VmC2dfZs
 0S3v3T3brrOwGE7T4XwgL1HmveBVnnyMB6YvW2puv8+B4vmqG2A6ildpqLXSpSioo1ZmFG6H
 /XXwTaRDgAyLC0KzTLSSYwFgQU4w3hp8WFFKhBMVG5FM5YlpaVBV0IVbiwzfO1fB1D0+l8gR
 4jt+1BHHfwRXhD8fzgiRHiMY+CcfEikpMRyfwKrWt18BWmUL13JU/7pV8772uFcLkielb7/k
 j1GcTFI3e2YA7iQycJY8YTntkn2iKgfMX39ZtiKcz4z+LNGyTQARAQABzS1NaWtlIFNhbHZh
 dG9yZSA8bWlrZS5zYWx2YXRvcmVAY2Fub25pY2FsLmNvbT7CwY4EEwEKADgWIQTBlt73qQl5
 aHY4hNF3KDVDPShdfQUCW04dXgIbAwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB3KDVD
 PShdfWr1D/9OXL8s143lnBb2DdGA1nVhoHvmmJl6tdWtxj0InmsUfgzaN5fRWC8n78hnwu76
 qHKUw7hZV+bmq/BLCJLU4WpfaK/vxyQKCJOlqF3XpRZhndOYn1NVf31KpGTcLIiB91ntFHPv
 5yYH/6caFSto9NbR/TTADyOnx/g7AD3p//e7QmpDzDlRQHwj4E7DFTAAVVhUydVN3eCsZZ78
 qKH2d394Q+KeH5+JmwrfhR34NGWSnFm2SZzicLFPFAtZZa1B/eh1wMRdiY1sCL1RzjCGYn/a
 tvqQnrH3LdVCcC83sSPRqPedpCKQMX3UQqn8OPsL6ZMAiWrCMU/Wa7+g0riPhi9XwmI5WTW3
 BA/mTaDF7/cAmSXz6Lvx4GjiRLZBKdUYsG2zcFI06jljOW7d/szGty0AP/A8jfo4LXfn/wy2
 VG7KljNTv2RZHcXvfKTt9XYCnYmZ9jLJ7OLOBys3cjiJgq9pBpSRf6qOPwIg+EnbXo0Q+vcs
 PVvklKzf2bs48kl8DMJk8jeDpBecGzZRxzf3ubgGMpSYn3QVCevnORv1k8eOIbojwNiBlHg/
 uQUndVoTmJ+0RwyzZTmCBuOOgUuNxeMYefNwVhp3aiSE6jmzP215CAIlhkvU17FewDT1bh7C
 bahT2UTBC2KoBtB3msfzpak4jc3oKTVNc1cMqKyyKjdsjc7BTQRbTh1eARAAlxeLru4aw48l
 rKFZdEcn0dHvSEFcBCWq2pHNZ+5lIm6gEoSh7+GkY8Y8rhJJYE7E76h2f4AhZUKjdWbpE//l
 z46kIvG0LGBO1eDOvIF2LDvpI7YkXUCL+VlxHivnXInOrgOJOmaFSilEJQVW1vsHk4QmcZbN
 VGHbNLtqfhG1zRH+F0vpG8CnR1gtIPRXOAmEojHVd32fZtnlHt5jmI+dO9J7ZX7l1PWtvhRV
 HIlTJWCdaXmK58GzDmKg3g5hegNdtCeo9TYvkQ6SASTewL8ZKmOoE6qQO/UCgxsR5AHB/Nf5
 Ge2lcoiz1QR8Vk/bvABz5pFuIi+NK96LH3SSF3kF/zT5mABUmvYnB2okwj7WuEKz8priHMwg
 WS+aCrc47jBmtlxX1fwjbfBccdtMhrw1YLlJWz7HK7Lj3xtqAwyZrx947bS0dUzcd1xlYmc3
 xHHV7bfmktPJBYRNCRKAR8EPtx7lEDVe6ykUL9f2c+4maAIEM17Irf4JCjXW2aJnnR/7Xyr0
 yhCJ1G+hmvrDJeno/qFTyC5IMxpQfbdHUPGZBH3fg9DSGk/yTFUD8AWB8DRbiWFVo97AuHBu
 h7zQhx59TyvuVG8bthN6NK8NKvOualTig9okhixz5854Zfp+zngYurFepOdveFITR0OCj7mN
 6+T/feyN9ErTqKWKTtlKdUUAEQEAAcLBdgQYAQoAIBYhBMGW3vepCXlodjiE0XcoNUM9KF19
 BQJbTh1eAhsMAAoJEHcoNUM9KF192tIP/RdBvin4pNEkqx1mYw7GB2l+vcx3UBtGccntlFzC
 O7xBWrs+ZEgpHrEVLSXBphlogCCS1Kbro1iQYxrMLRGEOfiQtXPRXOMdnfEvmGwPEuqlvzLL
 J3Yr8IzkgzadkeDTMzW3o5dpgVVjpXklRATcFMEA5TaYNayzeK+C2S6tcFJDCgnvcZGmiVTb
 tSE3FPSc4IueMCUo8MOG4ScLtEilBhhYcdjojxGY+2Dcmqc7O0kUMfVh37DyI04LJA+q7vBF
 ViRTtNnjpw0vxCx0s148foX6aNucEgo38RtV4G9ny5xqR0nkdDZBgMLEb2bDsuecy9vCXjZ3
 zEXCyr0pO5Ytac6Q4wHFaLFGr+r9aybouv0l2gLIPunvyP/cmKq3Dz3M8W+eCAwExchKijeM
 TaDCzr/EfLI6AqUvMfbytcXBRan71sswixbkS6NsZ90TMfGJ7HiJ9muCZE9Wz2eYDvFf5LrT
 1wHvtN2Qa5rIZ9928l3/3rjI1lQmmg77oanrqxMiIYNY1xTa3iYdBEYQgm7BNEWfs0yMQmj0
 929aV/bkh7i36vcPud06DnV0Y45Pk1pyYmFrl9r95TbdtgzTA4LlkufEiTVIztJwh8FUOKiJ
 5tc7NiImHPIIq0zKGpLuEum9DkMa9KmsISYB4wkS7H2suO74umCmFo74E9FyJGOPAVbI
Message-ID: <d3a51004-8242-1983-03a3-1b7848546d7d@canonical.com>
Date:   Tue, 16 Apr 2019 19:31:28 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <eff45453-f105-d713-1e77-a8fa9850c8fa@canonical.com>
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature";
 boundary="8uHkYsIYol5J88yK6ryzxH1EmTQES0bvJ"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8uHkYsIYol5J88yK6ryzxH1EmTQES0bvJ
Content-Type: multipart/mixed; boundary="ofXCy1rdBMWpxCcNJAZ41qZUjLLLyvSu0";
 protected-headers="v1"
From: Mike Salvatore <mike.salvatore@canonical.com>
To: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Cc: ramzeto@gmail.com, marcus.folkesson@gmail.com, flibitijibibo@gmail.com,
 aicommander@gmail.com, leosperling97@gmail.com, gottox@voidlinux.eu,
 frtherien@gmail.com, linux-kernel@vger.kernel.org,
 Mike Salvatore <mike.salvatore@canonical.com>, mike.s.salvatore@gmail.com
Message-ID: <d3a51004-8242-1983-03a3-1b7848546d7d@canonical.com>
Subject: Re: [PATCH] xpad.c: Send necessary control transfer to certain Xbox
 controllers
References: <eff45453-f105-d713-1e77-a8fa9850c8fa@canonical.com>
In-Reply-To: <eff45453-f105-d713-1e77-a8fa9850c8fa@canonical.com>

--ofXCy1rdBMWpxCcNJAZ41qZUjLLLyvSu0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

All,

I took another look at this patch and realized it was missing a #include.=

I've added the appropriate #include to a new version of the patch.

Thanks,
Mike Salvatore


=46rom 6fbf80fa3d5bc39fa054350a663080e1380046f8 Mon Sep 17 00:00:00 2001
From: Mike Salvatore <mike.salvatore@canonical.com>
Date: Wed, 13 Mar 2019 22:11:37 -0400
Subject: [PATCH] Input: xpad - send control init message to certain Xbox
 controllers

The Xbox controller with idVendor =3D=3D 0x045e and idProduct =3D=3D 0x02=
8e
requires that a specific control transfer be sent from the host to the
device before the device will send data to the host.

This patch introduces an xboxone_control_packet struct and a mechanism
for sending control packets to devices that require them at
initialization.

Signed-off-by: Mike Salvatore <mike.salvatore@canonical.com>
---
 drivers/input/joystick/xpad.c | 57 +++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.=
c
index cfc8b94527b9..756df325bfa6 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -81,6 +81,7 @@
 #include <linux/slab.h>
 #include <linux/stat.h>
 #include <linux/module.h>
+#include <linux/usb/ch9.h>
 #include <linux/usb/input.h>
 #include <linux/usb/quirks.h>
=20
@@ -460,6 +461,25 @@ struct xboxone_init_packet {
 		.len		=3D ARRAY_SIZE(_data),	\
 	}
=20
+struct xboxone_control_packet {
+	u16 idVendor;
+	u16 idProduct;
+	struct usb_ctrlrequest ctrlrequest;
+};
+
+#define XBOXONE_CONTROL_PKT(_vid, _pid, _reqtype, _req, _value, _index, =
_len)  \
+	{						\
+		.idVendor	=3D (_vid),		\
+		.idProduct	=3D (_pid),		\
+		.ctrlrequest    =3D {			\
+			.bRequestType	=3D (_reqtype),	\
+			.bRequest	=3D (_req),	\
+			.wValue		=3D (_value),	\
+			.wIndex		=3D (_index),	\
+			.wLength	=3D (_len),	\
+		},					\
+	}
+
=20
 /*
  * This packet is required for all Xbox One pads with 2015
@@ -537,6 +557,13 @@ static const struct xboxone_init_packet xboxone_init=
_packets[] =3D {
 	XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumbleend_init),
 };
=20
+static const struct xboxone_control_packet xboxone_control_packets[] =3D=
 {
+	XBOXONE_CONTROL_PKT(0x045e, 0x028e,
+			USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
+			USB_REQ_CLEAR_FEATURE,
+			USB_DEVICE_REMOTE_WAKEUP, 0, 0),
+};
+
 struct xpad_output_packet {
 	u8 data[XPAD_PKT_LEN];
 	u8 len;
@@ -1119,6 +1146,31 @@ static int xpad_init_output(struct usb_interface *=
intf, struct usb_xpad *xpad,
 	return error;
 }
=20
+static int xpad_init_control_msg(struct usb_xpad *xpad)
+{
+	struct usb_device *udev =3D xpad->udev;
+	size_t i;
+
+	for (i =3D 0; i < ARRAY_SIZE(xboxone_control_packets); i++) {
+		u16 idVendor =3D xboxone_control_packets[i].idVendor;
+		u16 idProduct =3D xboxone_control_packets[i].idProduct;
+
+		if (le16_to_cpu(udev->descriptor.idVendor) =3D=3D idVendor
+		    && le16_to_cpu(udev->descriptor.idProduct) =3D=3D idProduct) {
+			const struct usb_ctrlrequest *ctrlrequest =3D
+				&(xboxone_control_packets[i].ctrlrequest);
+
+			return usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
+				ctrlrequest->bRequest,
+				ctrlrequest->bRequestType, ctrlrequest->wValue,
+				ctrlrequest->wIndex, NULL, ctrlrequest->wLength,
+				2 * HZ);
+		}
+	}
+
+	return 0;
+}
+
 static void xpad_stop_output(struct usb_xpad *xpad)
 {
 	if (xpad->xtype !=3D XTYPE_UNKNOWN) {
@@ -1839,6 +1891,11 @@ static int xpad_probe(struct usb_interface *intf, =
const struct usb_device_id *id
 		if (error)
 			goto err_deinit_output;
 	}
+
+	error =3D xpad_init_control_msg(xpad);
+	if (error)
+		goto err_deinit_output;
+
 	return 0;
=20
 err_deinit_output:
--=20
2.17.1


On 3/23/19 12:46 PM, Mike Salvatore wrote:
> From 3051524e62d68b920019bcb50a713e736fcf4234 Mon Sep 17 00:00:00 2001
> From: Mike Salvatore <mike.salvatore@canonical.com>
> Date: Wed, 13 Mar 2019 22:11:37 -0400
> Subject: [PATCH] Input: xpad - send control init message to certain Xbo=
x
>  controllers
>=20
> The Xbox controller with idVendor =3D=3D 0x045e and idProduct =3D=3D 0x=
028e
> requires that a specific control transfer be sent from the host to the
> device before the device will send data to the host.
>=20
> This patch introduces an xboxone_control_packet struct and a mechanism
> for sending control packets to devices that require them at
> initialization.
>=20
> Signed-off-by: Mike Salvatore <mike.salvatore@canonical.com>
> ---
>  drivers/input/joystick/xpad.c | 56 +++++++++++++++++++++++++++++++++++=

>  1 file changed, 56 insertions(+)
>=20
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpa=
d.c
> index cfc8b94527b9..f45522b9ff1f 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -460,6 +460,25 @@ struct xboxone_init_packet {
>  		.len		=3D ARRAY_SIZE(_data),	\
>  	}
> =20
> +struct xboxone_control_packet {
> +	u16 idVendor;
> +	u16 idProduct;
> +	struct usb_ctrlrequest ctrlrequest;
> +};
> +
> +#define XBOXONE_CONTROL_PKT(_vid, _pid, _reqtype, _req, _value, _index=
, _len)  \
> +	{						\
> +		.idVendor	=3D (_vid),		\
> +		.idProduct	=3D (_pid),		\
> +		.ctrlrequest    =3D {			\
> +			.bRequestType	=3D (_reqtype),	\
> +			.bRequest	=3D (_req),	\
> +			.wValue		=3D (_value),	\
> +			.wIndex		=3D (_index),	\
> +			.wLength	=3D (_len),	\
> +		},					\
> +	}
> +
> =20
>  /*
>   * This packet is required for all Xbox One pads with 2015
> @@ -537,6 +556,13 @@ static const struct xboxone_init_packet xboxone_in=
it_packets[] =3D {
>  	XBOXONE_INIT_PKT(0x24c6, 0x543a, xboxone_rumbleend_init),
>  };
> =20
> +static const struct xboxone_control_packet xboxone_control_packets[] =3D=
 {
> +	XBOXONE_CONTROL_PKT(0x045e, 0x028e,
> +			USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
> +			USB_REQ_CLEAR_FEATURE,
> +			USB_DEVICE_REMOTE_WAKEUP, 0, 0),
> +};
> +
>  struct xpad_output_packet {
>  	u8 data[XPAD_PKT_LEN];
>  	u8 len;
> @@ -1119,6 +1145,31 @@ static int xpad_init_output(struct usb_interface=
 *intf, struct usb_xpad *xpad,
>  	return error;
>  }
> =20
> +static int xpad_init_control_msg(struct usb_xpad *xpad)
> +{
> +	struct usb_device *udev =3D xpad->udev;
> +	size_t i;
> +
> +	for (i =3D 0; i < ARRAY_SIZE(xboxone_control_packets); i++) {
> +		u16 idVendor =3D xboxone_control_packets[i].idVendor;
> +		u16 idProduct =3D xboxone_control_packets[i].idProduct;
> +
> +		if (le16_to_cpu(udev->descriptor.idVendor) =3D=3D idVendor
> +		    && le16_to_cpu(udev->descriptor.idProduct) =3D=3D idProduct) {
> +			const struct usb_ctrlrequest *ctrlrequest =3D
> +				&(xboxone_control_packets[i].ctrlrequest);
> +
> +			return usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> +				ctrlrequest->bRequest,
> +				ctrlrequest->bRequestType, ctrlrequest->wValue,
> +				ctrlrequest->wIndex, NULL, ctrlrequest->wLength,
> +				2 * HZ);
> +		}
> +	}
> +
> +	return 0;
> +}
> +
>  static void xpad_stop_output(struct usb_xpad *xpad)
>  {
>  	if (xpad->xtype !=3D XTYPE_UNKNOWN) {
> @@ -1839,6 +1890,11 @@ static int xpad_probe(struct usb_interface *intf=
, const struct usb_device_id *id
>  		if (error)
>  			goto err_deinit_output;
>  	}
> +
> +	error =3D xpad_init_control_msg(xpad);
> +	if (error)
> +		goto err_deinit_output;
> +
>  	return 0;
> =20
>  err_deinit_output:
> -- 2.17.1


--ofXCy1rdBMWpxCcNJAZ41qZUjLLLyvSu0--

--8uHkYsIYol5J88yK6ryzxH1EmTQES0bvJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEwZbe96kJeWh2OITRdyg1Qz0oXX0FAly2ZdAACgkQdyg1Qz0o
XX24oQ/7BV3glS2hdqVnHzJb05CA0Mp6qHSdxakRAePkIkhjuwU5KaNCwcwDUyEx
Haj6AG+BpVQB67SQYs94AwN5bmtzSN1WszCiyYqmHzhOtem0MGevxy2Cu8Z6/Ezt
drmMOCVftwiFcmcKaxXCE+v5Sn7pbZ1U9anb15kG7FTirvzbLVZGa4i33N9XpkqV
CoyGuw6ZKpJf8akD223TxYkN2vgLP0OL+b/IYksYm/eHjebq7RvDX1vvhj+60N0m
kAkRjq33sORcE04DqHKE+a1ZFPDzOnl2DCe3kPlASPqeRe3iqEUojuIWpdQSxo2E
QbIGFdB+U3PI4gaQnBxQjxnODk5FaVc/s9cl7xWbmomXKuWke7RaPCUS4OL+Jzug
Lh3TbDKADW8ZkaH6Ni25w+DmCmOAxaZwPoyjNXyrug0qkBYiyFRArZPZfujNT3qB
7IrCPGaSxxhQBNcTb8uykc+wLlrW8XeJE4UN0WvpiejrJ4pNzEtXqLqjQKXsBKD8
/2/mQpl/vs6Grquhn8yRVntwABoDdhVpXlSYVrMxExiIOlaw+M8bKjTbK34ug/O1
QlBsDn9pqh5tZqA4Nepvs0yZQ1xzjTxvv6iuKugRxtda3pHLNO/huDDzlT5wbtO1
6NBBqqCo6hAbnKWF7IkwMu2WfOEJxxskdo0RdgWFYkNyV5kD7k4=
=26cY
-----END PGP SIGNATURE-----

--8uHkYsIYol5J88yK6ryzxH1EmTQES0bvJ--