Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3665754yba; Tue, 16 Apr 2019 16:47:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqygvTJr9gbCfzKGt5uqNXGDY1fiojW9/Qx1iZJZMs+KpYUNKxzTiSoWmPo/mMPPf7JPhmZX X-Received: by 2002:a17:902:b713:: with SMTP id d19mr86144621pls.54.1555458453043; Tue, 16 Apr 2019 16:47:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555458453; cv=none; d=google.com; s=arc-20160816; b=FhVi55OZZScwZI7pT1bQRtNkYmTMO1JR7Xbso55xEHF3SgVaHLd+Z7D3+7ld+R1Ahb SjTuAWUx5+AEwMGdDYjxN17kL1KzmOrQldC/RRwynJhxkKvMhOmyQnb/WVYxysdTY8Qt AksNIoYgDiz+NewtQWje6cQMLz5NGltqmyeCegFRLtlQL22WBCnTuN3gj0ngmN7hk0hx zznDO73WdCAaL6SjQsehVZVU6CLY/rIGcGo7fBhJSDWBdOObbpqEFjvboSrVZ2kcS2uR jyIM+zVPlhYJ+eId2XSqOtgqDsF8iyD1YxamjJ21AQxoCOBg+4uUyGOF+xCmQ4WRmEJ6 zibA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=xLkj2li5zBnNf7sHLy/2n/r4YF1ow9GVyaQZHYZQuk0=; b=Iw7cdYXgPpWqy+ssEXNGK9NEWxxCwRWyWrW7VIkyFx9aQhWJFL/jKDpAhAHLMmdvZn W067KfwN8vTO14P92ageObKCV4kzg/9wBrRwR5ThOMlatW64tNR2TBQX/2rkABLmxbvl i4A8WrlP1USe6AvJELImBP5A0O3jRBNtROU7irpI14HMcfFhtaCoEYBUgkplUmV7fmsq YFarjNSZvbEdQflT2gAQqg6bS2EvK02y2iItGP4hpcPfHwt7YMgJv41n4JrxSWABzGXT h3MJ9YCUOBqtcOpcWuWPXoVEGVFSaxvpDVxEH/bjZmJSAy38vtJbETWbKgWB+TkEHpkY amNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m17si49656298pgi.514.2019.04.16.16.47.16; Tue, 16 Apr 2019 16:47:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730266AbfDPXp0 (ORCPT + 99 others); Tue, 16 Apr 2019 19:45:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:41058 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729291AbfDPXp0 (ORCPT ); Tue, 16 Apr 2019 19:45:26 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 897ACE2C; Tue, 16 Apr 2019 23:45:25 +0000 (UTC) Date: Tue, 16 Apr 2019 16:45:24 -0700 From: Andrew Morton To: Kees Cook Cc: Matteo Croce , LKML , "linux-fsdevel@vger.kernel.org" , Luis Chamberlain , Alexey Dobriyan Subject: Re: [PATCH 2/2] kernel: use sysctl shared variables for range check Message-Id: <20190416164524.ac661d71f22e0126da31ef98@linux-foundation.org> In-Reply-To: References: <20190408220925.13077-1-mcroce@redhat.com> <20190408220925.13077-3-mcroce@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Apr 2019 15:59:55 -0700 Kees Cook wrote: > On Wed, Apr 10, 2019 at 3:54 PM Matteo Croce wrote: > > > > On Thu, Apr 11, 2019 at 12:34 AM Kees Cook wrote: > > > > > > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > > > > > > > FYI, this are the stats from my local repo, just to let you the size > > > > of a series with all the changes in it: > > > > > > > > $ git --no-pager log --stat --oneline linus/master > > > > 2 files changed, 4 insertions(+), 9 deletions(-) > > > > 2 files changed, 7 insertions(+), 14 deletions(-) > > > > 6 files changed, 15 insertions(+), 30 deletions(-) > > > > 1 file changed, 16 insertions(+), 19 deletions(-) > > > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > 3 files changed, 15 insertions(+), 20 deletions(-) > > > > 12 files changed, 93 insertions(+), 116 deletions(-) > > > > 3 files changed, 98 insertions(+), 104 deletions(-) > > > > 2 files changed, 9 insertions(+) > > > > > > Tiny! :) Seriously, though, I think this should be fine to take > > > directly to Linus after patch 1 lands, or see if akpm wants to carry > > > it directly. > > > > > > -- > > > Kees Cook > > > > Nice. Still as an 8 patches series, or squashed into a bigger one? > > I suspect a single patch would be fine, but let's wait to hear from akpm. Bring it!