Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3897182yba; Tue, 16 Apr 2019 23:35:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7PYOoaNNEhuq6tFaIoleoOuOvXpeqh2Hzm6CPXKCdMcgoj7lQ+nB/nIahsT5hmKXtoo/F X-Received: by 2002:a17:902:b481:: with SMTP id y1mr48519175plr.161.1555482920742; Tue, 16 Apr 2019 23:35:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555482920; cv=none; d=google.com; s=arc-20160816; b=ZbUxgIuD1cdumlphcI93XNyb3vt6oADEWJ2t8ETMfMX8UybQQlxnnUnSPlgm2WA5Nk KfhxIh0FiduCHrBGTdHnCi7nZTXdQqeAS7oe+f4iTTzJIgTkAQ3fYBEFVsWuxA3c7kZy 4lQQDxO9UDMQncvtdxAMMhAvF52DvJwt5Afp4QW7vJYXKApIXpMHXpP95VLROTWbxU58 6Wpjz/LeOMNb2YqQFdAHAhS9a4R8UZEf96eHwmPFpjuy41um4jsMuIQuBZtXYsiOcv4W yJL8gQHLnBjAYIvSgvbL1kbkNvfwyzeIyESvnGrBQXrvfy4ceIunVnI7gDEUhzy5Mzuw m2qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=IjUdgu2Jv7jCy/CEFC/2LDf6bobqan2DMvgQ1ifC3F8=; b=Op5L4qGHn79dEEglA+efsW34XUWiEfDaIjV/SU8OpkZ17qZRIyo5LAtEO446voFTNe t4IOeGfcw6aI46n45eMAbEoyHes41WSuIUW2Kj0b38t/VgbgBrgkfDMXRgNUUzyqdfBQ fWjIks4gr9TJmG4ex5BXPojOoWCjrhSzaSaw7S+l5rbAlpPVe5+SjuwqPTSnhaMA6u79 qTbRVRYw/ZbzFHpHjzpOd4pSmcpLlW3NxvKLsQB2/Yff9fDkfXhaLY4bdRj6/B9yCumv HYi05w36T12ld3CUuRhQJcMZiavDDxhD3TpMJgIfzAsL7UiMuQRVOSpV+F/Ux6gqG498 egeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si49647703plr.229.2019.04.16.23.35.05; Tue, 16 Apr 2019 23:35:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729417AbfDQGeN (ORCPT + 99 others); Wed, 17 Apr 2019 02:34:13 -0400 Received: from verein.lst.de ([213.95.11.211]:40537 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbfDQGeM (ORCPT ); Wed, 17 Apr 2019 02:34:12 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id B66FE68AFE; Wed, 17 Apr 2019 08:33:58 +0200 (CEST) Date: Wed, 17 Apr 2019 08:33:58 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Joerg Roedel , Catalin Marinas , Will Deacon , Tom Lendacky , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/21] dma-iommu: factor atomic pool allocations into helpers Message-ID: <20190417063358.GA24139@lst.de> References: <20190327080448.5500-1-hch@lst.de> <20190327080448.5500-13-hch@lst.de> <20190410061157.GA5278@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410061157.GA5278@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 10, 2019 at 08:11:57AM +0200, Christoph Hellwig wrote: > On Tue, Apr 09, 2019 at 06:59:32PM +0100, Robin Murphy wrote: > > On 27/03/2019 08:04, Christoph Hellwig wrote: > >> This keeps the code together and will simplify compiling the code > >> out on architectures that are always dma coherent. > > > > And this is where things take a turn in the direction I just can't get on > > with - I'm looking at the final result and the twisty maze of little > > disjoint helpers all overlapping each other in functionality is really > > difficult to follow. And I would *much* rather have things rely on > > compile-time constant optimisation than spend the future having to fix the > > #ifdefed parts for arm64 whenever x86-centric changes fail to test them. > > Can you draft up a patch on top of my series to show me what you > want? I can take care of finishing it up and moving the changes > into the right patches in the series. Any chance to make some progress on this? Or at least a better description of what you want?