Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 08:51:27 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andi Kleen <ak@linux.intel.com>,
        Song Liu <songliubraving@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH 11/12] perf tools: Reuse shared eBPF dso objects
Message-ID: <20190417065127.GA17024@krava>
References: <20190416160127.30203-1-jolsa@kernel.org>
 <20190416160127.30203-12-jolsa@kernel.org>
 <746f02e3-a509-5081-8427-b610e52c1fb0@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <746f02e3-a509-5081-8427-b610e52c1fb0@intel.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 09:35:32AM +0300, Adrian Hunter wrote:
> On 16/04/19 7:01 PM, Jiri Olsa wrote:
> > The eBPF program can be loaded multiple times
> > with the same name (tag). We can share dso
> > objects for those programs.
> 
> Doesn't a eBPF program get recompiled differently every time it is loaded?

yes, but those with same tag are identical

jirka

> 
> > 
> > Link: http://lkml.kernel.org/n/tip-3damf8vq1dryhtpbk5b06jpt@git.kernel.org
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > ---
> >  tools/perf/util/machine.c | 14 +++++++++++---
> >  1 file changed, 11 insertions(+), 3 deletions(-)
> > 
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> > index d4aa44489011..a60653827891 100644
> > --- a/tools/perf/util/machine.c
> > +++ b/tools/perf/util/machine.c
> > @@ -23,6 +23,7 @@
> >  #include "linux/hash.h"
> >  #include "asm/bug.h"
> >  #include "bpf-event.h"
> > +#include "dso.h"
> >  
> >  #include "sane_ctype.h"
> >  #include <symbol/kallsyms.h>
> > @@ -699,11 +700,18 @@ static int machine__process_ksymbol_register(struct machine *machine,
> >  
> >  	map = map_groups__find(&machine->kmaps, event->ksymbol_event.addr);
> >  	if (!map) {
> > -		map = dso__new_map(event->ksymbol_event.name);
> > -		if (!map)
> > +		struct dso *dso;
> > +
> > +		dso = dsos__findnew(&machine->dsos, event->ksymbol_event.name);
> > +		if (!dso)
> >  			return -ENOMEM;
> >  
> > -		map->start = event->ksymbol_event.addr;
> > +		map = map__new2(event->ksymbol_event.addr, dso);
> > +		if (!map) {
> > +			dso__put(dso);
> > +			return -ENOMEM;
> > +		}
> > +
> >  		map->end = map->start + event->ksymbol_event.len;
> >  		map_groups__insert(&machine->kmaps, map);
> >  	}
> > 
>