Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 13:50:25 +0200
From:   Romain Izard <romain.izard.pro@gmail.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Daniel Lezcano <daniel.lezcano@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Alexander Dahl <ada@thorsis.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 9/9] misc: atmel_tclib: do not probe already used TCBs
Message-ID: <20190417114934.GA28520@5WDYG62>
References: <20190415150856.9384-1-alexandre.belloni@bootlin.com>
 <20190415150856.9384-10-alexandre.belloni@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190415150856.9384-10-alexandre.belloni@bootlin.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 15, 2019 at 05:08:56PM +0200, Alexandre Belloni wrote:
> The TCBs that have children are using the proper DT bindings and don't need
> to be handled by tclib.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>  drivers/misc/atmel_tclib.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/misc/atmel_tclib.c b/drivers/misc/atmel_tclib.c
> index 194f774ab3a1..c1f5aba1c6f2 100644
> --- a/drivers/misc/atmel_tclib.c
> +++ b/drivers/misc/atmel_tclib.c
> @@ -111,6 +111,9 @@ static int __init tc_probe(struct platform_device *pdev)
>  	struct resource	*r;
>  	unsigned int	i;
>  
> +	if (of_get_child_count(pdev->dev.of_node))
> +		return 0;
> +
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0)
>  		return -EINVAL;

This lead to a panic during shutdown, as tc_shutdown is called on the
device that has not been initialized and it has not been designed for
this.

-- 
Romain Izard