Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416131746.1303495-1-arnd@arndb.de> <20190417041250.nbqy2ltjw77wlnts@tarshish>
In-Reply-To: <20190417041250.nbqy2ltjw77wlnts@tarshish>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 17 Apr 2019 14:50:22 +0200
Message-ID: <CAK8P3a36NGB3V6Feve5PdhyEHuh+g0FOHqttu149V2ApwWp3=w@mail.gmail.com>
Subject: Re: [PATCH] ARM: debug-ll: add default address for digicolor
To:     Baruch Siach <baruch@tkos.co.il>
Cc:     arm-soc <arm@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Russell King <linux@armlinux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 6:12 AM Baruch Siach <baruch@tkos.co.il> wrote:
> On Tue, Apr 16, 2019 at 03:17:30PM +0200, Arnd Bergmann wrote:
> > The digicolor platform has three UARTs, but the Kconfig.debug
> > file explicitly lists port zero as the one to be used for the
> > console, while not providing any default values.
> >
> > This can get an automated randconfig build stuck in a loop
> > waiting for the user to input the number. As we already know
> > the physical address, this patch provides that number as
> > default, along with a reasonable default value for the virtual
> > address.
> >
> > Cc: Baruch Siach <baruch@tkos.co.il>
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  arch/arm/Kconfig.debug | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index a8a1e14f20ab..e5f0b36d797f 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -1676,6 +1676,7 @@ config DEBUG_UART_PHYS
> >       default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1
> >       default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4
> >       default 0xe8008000 if DEBUG_R7S72100_SCIF2
> > +     default 0xf0000740 if DEBUG_DIGICOLOR_UA0
>
> The addruart macro in arch/arm/include/debug/digicolor.S adds the 0x740 offset.
> So CONFIG_DEBUG_UART_PHYS should be 0xf0000000.

Ok, fixed.

> >       default 0xf0000be0 if ARCH_EBSA110
> >       default 0xf1012000 if DEBUG_MVEBU_UART0_ALTERNATE
> >       default 0xf1012100 if DEBUG_MVEBU_UART1_ALTERNATE
> > @@ -1785,6 +1786,7 @@ config DEBUG_UART_VIRT
> >       default 0xfd012000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_MV78XX0
> >       default 0xfd883000 if DEBUG_ALPINE_UART0
> >       default 0xfde12000 if DEBUG_MVEBU_UART0_ALTERNATE && ARCH_DOVE
> > +     default 0xfe000740 if DEBUG_DIGICOLOR_UA0
>
> The value I used when testing used to be 0xf0100000.

Ok, using that now. It shouldn't matter either way here, we only care
about that there is nothing else at that address.

     Arnd