Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416144353.34024-1-yuehaibing@huawei.com>
In-Reply-To: <20190416144353.34024-1-yuehaibing@huawei.com>
From:   Qiang Yu <yuq825@gmail.com>
Date:   Wed, 17 Apr 2019 21:06:07 +0800
Message-ID: <CAKGbVbv0NBP=bMznWmb+RLz+ndCQY6eLQ4_vmGTsBkC-0L4dAQ@mail.gmail.com>
Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static
To:     Yue Haibing <yuehaibing@huawei.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        lima@lists.freedesktop.org,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Pushed to drm-misc-next.

Thanks,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
>  symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpu/drm/lima/lima_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
>         kmem_cache_free(pipe->task_slab, task);
>  }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
>         .dependency = lima_sched_dependency,
>         .run_job = lima_sched_run_job,
>         .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>