Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 09:45:04 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     "zhuyan (M)" <zhuyan34@huawei.com>
cc:     Greg KH <gregkh@linuxfoundation.org>,
        "anton@enomsg.org" <anton@enomsg.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb:host: fix divide-by-zero in function fhci_queue_urb
In-Reply-To: <cb1b585652b54d3d9ff8ef6548094d3b@huawei.com>
Message-ID: <Pine.LNX.4.44L0.1904170942530.27339-100000@netrider.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 17 Apr 2019, zhuyan (M) wrote:

> On Tue, 16 Apr 2019 11:07:56 -0400, Alan Stern wrote:
> 
> > On Tue, 16 Apr 2019, zhuyan (M) wrote:
> > > On Tue, 16 Apr 2019 at 11:45:45 +0200, Greg KH wrote:
> > > > On Tue, Apr 09, 2019 at 10:37:12PM +0800, zhuyan wrote:
> > > > > In function fhci_queue_urb, the divisor of expression 
> > > > > (urb->transfer_buffer_length % usb_maxpacket(urb->dev, urb->pipe,
> > > > > usb_pipeout(urb->pipe))) may be zero.
> > > > 
> > > > How can you hit that?
> > > > 
> > > > > When it is zero, unexpected results may occur, so it is necessary 
> > > > > to ensure that the divisor is not zero.
> > > > > 
> > > > > Signed-off-by: zhuyan <zhuyan34@huawei.com>
> > > > 
> > > > I need a "Full" name here, not just a single name.  Whatever you use to sign documents is good.
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > In function usb_maxpacket, when ep is NULL, its return value is 0.  
> > 
> > fhci_queue_urb() shouldn't use urb->pipe to compute the maxpacket size 
> > anyway.  It should use usb_endpoint_maxp(&urb->ep->desc).
> 
> Currently, fhci_queue_urb(), call usb_maxpacket() multiple times to calculate
>  the maxpacket size. The usb_maxpacket() will call usb_endpoint_maxp() to 
> compute the maxpacket size.

I know that.  What fhci_queue_urb() is doing is wrong.  You should
change it: Make it call usb_endpoint_maxp directly instead of calling
usb_maxpacket.

Alan Stern