Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 16:46:38 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
        khasim.mohammed@linaro.org
Subject: Re: [PATCH] regulator: core: do not report EPROBE_DEFER as error.
Message-ID: <20190417154638.GC5703@sirena.org.uk>
References: <20190417085411.14552-1-jorge.ramirez-ortiz@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VywGB/WGlW4DM4P8"
Content-Disposition: inline
In-Reply-To: <20190417085411.14552-1-jorge.ramirez-ortiz@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--VywGB/WGlW4DM4P8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 17, 2019 at 10:54:11AM +0200, Jorge Ramirez-Ortiz wrote:
> Do not log a temporary failure to get a regulator (EPROBE_DEFER) while
> the driver is requesting retries.

> -			dev_err(dev, "Failed to get supply '%s': %d\n",
> -				consumers[i].supply, ret);
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(dev, "Failed to get supply '%s': %d\n",
> +					consumers[i].supply, ret);

Please leave at least a debug log in place, it's not good to just
silently fail - even if we will retry someone might still need some help
debugging (eg, figuring out that they need to enable whatever driver is
providing the supply in their config) so we should tell them why we're
deferring.

BTW does an e-mail address need updating somewhere here?

--VywGB/WGlW4DM4P8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAly3Sl0ACgkQJNaLcl1U
h9CSpgf+NXPRp/QvJ5ozA3U8QPuDTm7eZHHlacZ4cK/9GDwxkWzDHqqQpvF59Nrp
v09pxwgHUzJ679E0f+atyuJj5drJpxmWnL1eFnZjirqv6oIbYzHFt4/9xpdblT/T
O/vH0nT/JQsYv8H7dmcRPzR9L22kxr0PcW+ZrbRFTn3Cf1mYcq8o2oQFNDiBTmyK
O9L0lT5VB2+wvQ46t0EbZP/L2QaCSzfslxy5I+k02dntnfw28dW36d31KxmzoHH9
ZpOMOd8O8z6UyYyHRL93L8qbKqfnGressJ3fbQgvPIvIvDQ3wLSBS+9KmZNPKMw0
zvorX87+nFmdGA0SFMwMwPqgBGdQ+g==
=M/ed
-----END PGP SIGNATURE-----

--VywGB/WGlW4DM4P8--