Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4373308yba; Wed, 17 Apr 2019 10:06:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxk7n8tQ+Bcj0YsLCIye5QwBqqe2ivTYHN3+V4jZpxcg7Xp0pqWMGipgH9WHcBzJF59JTaX X-Received: by 2002:a63:10c:: with SMTP id 12mr80938864pgb.276.1555520763681; Wed, 17 Apr 2019 10:06:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555520763; cv=none; d=google.com; s=arc-20160816; b=d7ZY8Mow6undIpe7Gtjx02vkzYXsGAX4IzwNZm3TIb06sOd5+T5B4o6BjTKlrFT49H KcBpkBy1lsZraxcYJ3X5msPqBtJ4f+SESv0+/iFIAk5SrX26W33OQhKM7y28iKDvqcOP yZbqsO85rwClVEEdz0zuZd+sU4MFfvhNQRyQwKffJgnJu0SVJbcIHQdA82tXhrcQTsvT mPUYhfVN0iH7XZC0k+S8P6eJOlg6MIIR1W6mPy2hg5bAdYcw6M68whF3Gm1e6FZyNUkE Y8lpaGWD2ebwR5xjtOUXNOLXVUNPjxmqfKqw4CZSN/088kaU651wN5rxL5jXXdu4CWpq ZJkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:openpgp:from:references:cc:to:subject; bh=Z4FegVNAuvCj4RGxPYA+KpwUjOPpzDVJJ+fU91bVjC4=; b=g2PH5tn+JpuASEdaL4AQCO8GG8hUIQZsjzbGpaQMxon6yA9wvkv0vULLgdDW7Sa4+q lg0aIfHNRKwbBRSQv6gM3gUyiGbr7tHlr+AyKtQPBOg8cZzVxjguvxrUrA3yvEb4fwWe Uz4Utq6D/E/q0h64XlMr9eS9N3eLyvCXQXGWawhqP/uc2qX6V3sBHqhSQB4Xk0i6nBuA RqXOKrVFIkOkN6+IBgXg4EyLI9LzBrrMfGj7raeYh+l6WzXZi9FSXLMP4uNXjRl1e5Cd G02PKmnWG/+XBGZoIIpQj8sspXPsYViV54RfUmdmpHD036deFTvclv7gh5t3J+wXfL+b kXsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2si50192582pgh.231.2019.04.17.10.05.47; Wed, 17 Apr 2019 10:06:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732860AbfDQREm (ORCPT + 99 others); Wed, 17 Apr 2019 13:04:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:60470 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729512AbfDQREm (ORCPT ); Wed, 17 Apr 2019 13:04:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2C54DADC1; Wed, 17 Apr 2019 17:04:40 +0000 (UTC) Subject: Re: [PATCH v10 0/7] Add Fieldbus subsystem + support HMS Profinet card To: "Enrico Weigelt, metux IT consult" Cc: Sven Van Asbroeck , Rob Herring , Linus Walleij , Lee Jones , mark.rutland@arm.com, treding@nvidia.com, David Lechner , noralf@tronnes.org, johan@kernel.org, Michal Simek , michal.vokac@ysoft.com, Arnd Bergmann , Greg KH , john.garry@huawei.com, geert+renesas@glider.be, robin.murphy@arm.com, Paul Gortmaker , sebastien.bourdelin@savoirfairelinux.com, icenowy@aosc.io, Stuart Yoder , "J. Kiszka" , maxime.ripard@bootlin.com, Linux Kernel Mailing List , netdev References: <20190409144250.7237-1-TheSven73@gmail.com> <982e69c6-4e68-6f62-8bed-cd5a1802272b@metux.net> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Organization: SUSE Linux GmbH Message-ID: <31245f21-ae98-f10f-9484-a1719164ce16@suse.de> Date: Wed, 17 Apr 2019 19:04:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enrico, Am 16.04.19 um 18:49 schrieb Enrico Weigelt, metux IT consult: > On 15.04.19 20:31, Sven Van Asbroeck wrote: >>> Maybe it would be better calling it "IEC-61158" instead of "fieldbus" ?>>> > Yes, we are certainly open to that, if it is more correct and/or > better> accepted by users. > Thanks, I'd really appreciate that :) > > Maybe I'm a bit beaurocratic here, but I really believe that precise > naming is important, eg. for avoiding potential conflicts w/ different > fieldbus classes (eg. mvb) that might come in the future. I somewhat see your point, but I would not have recognized iec61158 as something relevant to my hardware, whereas fieldbus is understandable. If you see specific conflicts or differences, please explain them instead of just throwing around bus names. :) Then we can more easily discuss whether to make changes to this framework or whether we indeed need some fieldbus/iec61158/ subdirectory. For your RS-485 I don't see a conflict as that'll just go via tty/serial/ and optionally serdev, no? However, I'd be curious how I/O Link might relate to this, it seems to have no public specifications. > By the way: any special reason for doing this via device instead of > socket (like we have w/ can) ? > > I'm, personally, pretty undecided which way is better. Device nodes give > us easy access control via fs permissions, while socket allows > firewalling. While I do like sockets, they seem more useful for packet-based communication, which may be an implementation detail of fieldbus_dev drivers, but AFAIU that's unrelated to Sven's memory-focused subsystem representing a view of the data received, which may be different from the last packet received. Also, when a packet is received via socket, it gets dequeued, whereas you'll want to access the device's memory without restrictions. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)