Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 14:26:18 -0400
From:   Jerome Glisse <jglisse@redhat.com>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Leon Romanovsky <leonro@mellanox.com>,
        Jason Gunthorpe <jgg@mellanox.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ralph Campbell <rcampbell@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH] mm/hmm: kconfig split HMM address space mirroring from
 device memory
Message-ID: <20190417182618.GA11499@redhat.com>
References: <20190411180326.18958-1-jglisse@redhat.com>
 <20190417182118.GA1477@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190417182118.GA1477@roeck-us.net>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 11:21:18AM -0700, Guenter Roeck wrote:
> On Thu, Apr 11, 2019 at 02:03:26PM -0400, jglisse@redhat.com wrote:
> > From: J?r?me Glisse <jglisse@redhat.com>
> > 
> > To allow building device driver that only care about address space
> > mirroring (like RDMA ODP) on platform that do not have all the pre-
> > requisite for HMM device memory (like ZONE_DEVICE on ARM) split the
> > HMM_MIRROR option dependency from the HMM_DEVICE dependency.
> > 
> > Signed-off-by: J?r?me Glisse <jglisse@redhat.com>
> > Cc: Leon Romanovsky <leonro@mellanox.com>
> > Cc: Jason Gunthorpe <jgg@mellanox.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Ralph Campbell <rcampbell@nvidia.com>
> > Cc: John Hubbard <jhubbard@nvidia.com>
> > Tested-by: Leon Romanovsky <leonro@mellanox.com>
> 
> In case it hasn't been reported already:
> 
> mm/hmm.c: In function 'hmm_vma_handle_pmd':
> mm/hmm.c:537:8: error: implicit declaration of function 'pmd_pfn'; did you mean 'pte_pfn'?

No it is pmd_pfn

> 
> and similar errors when building alpha:allmodconfig (and maybe others).

Does HMM_MIRROR get enabled in your config ? It should not
does adding depends on (X86_64 || PPC64) to ARCH_HAS_HMM
fix it ? I should just add that there for arch i do build.

Cheers,
J?r?me