Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 21:18:09 +0200
Message-ID: <s5hh8awqw3y.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Geoff Levand" <geoff@infradead.org>
Cc:     <mpe@ellerman.id.au>, "Yue Haibing" <yuehaibing@huawei.com>,
        <benh@kernel.crashing.org>, <perex@perex.cz>, <paulus@samba.org>,
        <alsa-devel@alsa-project.org>, <linuxppc-dev@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ALSA: ps3: Remove set but not used variables 'start_vaddr' and 'pcm_index'
In-Reply-To: <1078ccec-2cc9-f16d-caca-32ac9c3cce4d@infradead.org>
References: <20190417145722.20448-1-yuehaibing@huawei.com>
        <1078ccec-2cc9-f16d-caca-32ac9c3cce4d@infradead.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 17 Apr 2019 20:19:30 +0200,
Geoff Levand wrote:
> 
> On 4/17/19 7:57 AM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> > 
> > Fixes gcc '-Wunused-but-set-variable' warnings:
> > 
> > sound/ppc/snd_ps3.c: In function 'snd_ps3_program_dma':
> > sound/ppc/snd_ps3.c:236:8: warning: variable 'start_vaddr' set but not used [-Wunused-but-set-variable]
> > sound/ppc/snd_ps3.c: In function 'snd_ps3_pcm_open':
> > sound/ppc/snd_ps3.c:529:6: warning: variable 'pcm_index' set but not used [-Wunused-but-set-variable]
> > 
> > They are never used and can be removed.
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  sound/ppc/snd_ps3.c | 4 ----
> >  1 file changed, 4 deletions(-)
> 
> Seems OK.  Thanks for submitting.
> 
> Acked-by: Geoff Levand <geoff@infradead.org>

Applied now.  Thanks.


Takashi