Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202013.4034148-9-arnd@arndb.de>
 <20190417211934.GW2217@ZenIV.linux.org.uk>
In-Reply-To: <20190417211934.GW2217@ZenIV.linux.org.uk>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 17 Apr 2019 23:34:48 +0200
Message-ID: <CAK8P3a3A1i90htc5GgFnJNQepbdvF9eDZ05xftzFcSMK7CXs_w@mail.gmail.com>
Subject: Re: [PATCH v3 08/26] compat_ioctl: add compat_ptr_ioctl()
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        y2038 Mailman List <y2038@lists.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 11:19 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Tue, Apr 16, 2019 at 10:19:46PM +0200, Arnd Bergmann wrote:
> > Many drivers have ioctl() handlers that are completely compatible between
> > 32-bit and 64-bit architectures, except for the argument that is passed
> > down from user space and may have to be passed through compat_ptr()
> > in order to become a valid 64-bit pointer.
> >
> > Using ".compat_ptr = compat_ptr_ioctl" in file operations should let
> > us simplify a lot of those drivers to avoid #ifdef checks, and convert
> > additional drivers that don't have proper compat handling yet.
>
> You forgot to mention that it even gets the previous commit to build ;-)
> IOW, that needs to be reordered.

Right. I had reordered the series multiple times and got this part wrong
in the end.

       Arnd