Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 23:05:47 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v9 07/11] power: supply: max77650: add support for
 battery charger
Message-ID: <20190417210547.r6u2hiciytzfmvqv@earth.universe>
References: <20190411124212.7612-1-brgl@bgdev.pl>
 <20190411124212.7612-8-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iv63luv6q6gtugy6"
Content-Disposition: inline
In-Reply-To: <20190411124212.7612-8-brgl@bgdev.pl>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--iv63luv6q6gtugy6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Apr 11, 2019 at 02:42:08PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>=20
> Add basic support for the battery charger for max77650 PMIC.
>=20
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/power/supply/Kconfig            |   7 +
>  drivers/power/supply/Makefile           |   1 +
>  drivers/power/supply/max77650-charger.c | 368 ++++++++++++++++++++++++
>  3 files changed, 376 insertions(+)
>  create mode 100644 drivers/power/supply/max77650-charger.c
>=20
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index e901b9879e7e..0230c96fa94d 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -499,6 +499,13 @@ config CHARGER_DETECTOR_MAX14656
>  	  Revision 1.2 and can be found e.g. in Kindle 4/5th generation
>  	  readers and certain LG devices.
> =20
> +config CHARGER_MAX77650
> +	tristate "Maxim MAX77650 battery charger driver"
> +	depends on MFD_MAX77650
> +	help
> +	  Say Y to enable support for the battery charger control of MAX77650
> +	  PMICs.
> +
>  config CHARGER_MAX77693
>  	tristate "Maxim MAX77693 battery charger driver"
>  	depends on MFD_MAX77693
> diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile
> index b731c2a9b695..b73eb8c5c1a9 100644
> --- a/drivers/power/supply/Makefile
> +++ b/drivers/power/supply/Makefile
> @@ -70,6 +70,7 @@ obj-$(CONFIG_CHARGER_MANAGER)	+=3D charger-manager.o
>  obj-$(CONFIG_CHARGER_LTC3651)	+=3D ltc3651-charger.o
>  obj-$(CONFIG_CHARGER_MAX14577)	+=3D max14577_charger.o
>  obj-$(CONFIG_CHARGER_DETECTOR_MAX14656)	+=3D max14656_charger_detector.o
> +obj-$(CONFIG_CHARGER_MAX77650)	+=3D max77650-charger.o
>  obj-$(CONFIG_CHARGER_MAX77693)	+=3D max77693_charger.o
>  obj-$(CONFIG_CHARGER_MAX8997)	+=3D max8997_charger.o
>  obj-$(CONFIG_CHARGER_MAX8998)	+=3D max8998_charger.o
> diff --git a/drivers/power/supply/max77650-charger.c b/drivers/power/supp=
ly/max77650-charger.c
> new file mode 100644
> index 000000000000..e34714cb05ec
> --- /dev/null
> +++ b/drivers/power/supply/max77650-charger.c
> @@ -0,0 +1,368 @@
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Copyright (C) 2018 BayLibre SAS
> +// Author: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> +//
> +// Battery charger driver for MAXIM 77650/77651 charger/power-supply.
> +
> +#include <linux/i2c.h>
> +#include <linux/interrupt.h>
> +#include <linux/mfd/max77650.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/power_supply.h>
> +#include <linux/regmap.h>
> +
> +#define MAX77650_CHARGER_ENABLED		BIT(0)
> +#define MAX77650_CHARGER_DISABLED		0x00
> +#define MAX77650_CHARGER_CHG_EN_MASK		BIT(0)
> +
> +#define MAX77650_CHG_DETAILS_MASK		GENMASK(7, 4)
> +#define MAX77650_CHG_DETAILS_BITS(_reg) \
> +		(((_reg) & MAX77650_CHG_DETAILS_MASK) >> 4)
> +
> +/* Charger is OFF. */
> +#define MAX77650_CHG_OFF			0x00
> +/* Charger is in prequalification mode. */
> +#define MAX77650_CHG_PREQ			0x01
> +/* Charger is in fast-charge constant current mode. */
> +#define MAX77650_CHG_ON_CURR			0x02
> +/* Charger is in JEITA modified fast-charge constant-current mode. */
> +#define MAX77650_CHG_ON_CURR_JEITA		0x03
> +/* Charger is in fast-charge constant-voltage mode. */
> +#define MAX77650_CHG_ON_VOLT			0x04
> +/* Charger is in JEITA modified fast-charge constant-voltage mode. */
> +#define MAX77650_CHG_ON_VOLT_JEITA		0x05
> +/* Charger is in top-off mode. */
> +#define MAX77650_CHG_ON_TOPOFF			0x06
> +/* Charger is in JEITA modified top-off mode. */
> +#define MAX77650_CHG_ON_TOPOFF_JEITA		0x07
> +/* Charger is done. */
> +#define MAX77650_CHG_DONE			0x08
> +/* Charger is JEITA modified done. */
> +#define MAX77650_CHG_DONE_JEITA			0x09
> +/* Charger is suspended due to a prequalification timer fault. */
> +#define MAX77650_CHG_SUSP_PREQ_TIM_FAULT	0x0a
> +/* Charger is suspended due to a fast-charge timer fault. */
> +#define MAX77650_CHG_SUSP_FAST_CHG_TIM_FAULT	0x0b
> +/* Charger is suspended due to a battery temperature fault. */
> +#define MAX77650_CHG_SUSP_BATT_TEMP_FAULT	0x0c
> +
> +#define MAX77650_CHGIN_DETAILS_MASK		GENMASK(3, 2)
> +#define MAX77650_CHGIN_DETAILS_BITS(_reg) \
> +		(((_reg) & MAX77650_CHGIN_DETAILS_MASK) >> 2)
> +
> +#define MAX77650_CHGIN_UNDERVOLTAGE_LOCKOUT	0x00
> +#define MAX77650_CHGIN_OVERVOLTAGE_LOCKOUT	0x01
> +#define MAX77650_CHGIN_OKAY			0x11
> +
> +#define MAX77650_CHARGER_CHG_MASK	BIT(1)
> +#define MAX77650_CHARGER_CHG_CHARGING(_reg) \
> +		(((_reg) & MAX77650_CHARGER_CHG_MASK) > 1)
> +
> +#define MAX77650_CHARGER_VCHGIN_MIN_MASK	0xc0
> +#define MAX77650_CHARGER_VCHGIN_MIN_SHIFT(_val)	((_val) << 5)
> +
> +#define MAX77650_CHARGER_ICHGIN_LIM_MASK	0x1c
> +#define MAX77650_CHARGER_ICHGIN_LIM_SHIFT(_val)	((_val) << 2)
> +
> +struct max77650_charger_data {
> +	struct regmap *map;
> +	struct device *dev;
> +};
> +
> +static enum power_supply_property max77650_charger_properties[] =3D {
> +	POWER_SUPPLY_PROP_STATUS,
> +	POWER_SUPPLY_PROP_ONLINE,
> +	POWER_SUPPLY_PROP_CHARGE_TYPE
> +};
> +
> +static const unsigned int max77650_charger_vchgin_min_table[] =3D {
> +	4000000, 4100000, 4200000, 4300000, 4400000, 4500000, 4600000, 4700000
> +};
> +
> +static const unsigned int max77650_charger_ichgin_lim_table[] =3D {
> +	95000, 190000, 285000, 380000, 475000
> +};
> +
> +static int max77650_charger_set_vchgin_min(struct max77650_charger_data =
*chg,
> +					   unsigned int val)
> +{
> +	int i, rv;
> +
> +	for (i =3D 0; i < ARRAY_SIZE(max77650_charger_vchgin_min_table); i++) {
> +		if (val =3D=3D max77650_charger_vchgin_min_table[i]) {
> +			rv =3D regmap_update_bits(chg->map,
> +					MAX77650_REG_CNFG_CHG_B,
> +					MAX77650_CHARGER_VCHGIN_MIN_MASK,
> +					MAX77650_CHARGER_VCHGIN_MIN_SHIFT(i));
> +			if (rv)
> +				return rv;
> +
> +			return 0;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +static int max77650_charger_set_ichgin_lim(struct max77650_charger_data =
*chg,
> +					   unsigned int val)
> +{
> +	int i, rv;
> +
> +	for (i =3D 0; i < ARRAY_SIZE(max77650_charger_ichgin_lim_table); i++) {
> +		if (val =3D=3D max77650_charger_ichgin_lim_table[i]) {
> +			rv =3D regmap_update_bits(chg->map,
> +					MAX77650_REG_CNFG_CHG_B,
> +					MAX77650_CHARGER_ICHGIN_LIM_MASK,
> +					MAX77650_CHARGER_ICHGIN_LIM_SHIFT(i));
> +			if (rv)
> +				return rv;
> +
> +			return 0;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +static int max77650_charger_enable(struct max77650_charger_data *chg)
> +{
> +	int rv;
> +
> +	rv =3D regmap_update_bits(chg->map,
> +				MAX77650_REG_CNFG_CHG_B,
> +				MAX77650_CHARGER_CHG_EN_MASK,
> +				MAX77650_CHARGER_ENABLED);
> +	if (rv)
> +		dev_err(chg->dev, "unable to enable the charger: %d\n", rv);
> +
> +	return rv;
> +}
> +
> +static int max77650_charger_disable(struct max77650_charger_data *chg)
> +{
> +	int rv;
> +
> +	rv =3D regmap_update_bits(chg->map,
> +				MAX77650_REG_CNFG_CHG_B,
> +				MAX77650_CHARGER_CHG_EN_MASK,
> +				MAX77650_CHARGER_DISABLED);
> +	if (rv)
> +		dev_err(chg->dev, "unable to disable the charger: %d\n", rv);
> +
> +	return rv;
> +}
> +
> +static irqreturn_t max77650_charger_check_status(int irq, void *data)
> +{
> +	struct max77650_charger_data *chg =3D data;
> +	int rv, reg;
> +
> +	rv =3D regmap_read(chg->map, MAX77650_REG_STAT_CHG_B, &reg);
> +	if (rv) {
> +		dev_err(chg->dev,
> +			"unable to read the charger status: %d\n", rv);
> +		return IRQ_HANDLED;
> +	}
> +
> +	switch (MAX77650_CHGIN_DETAILS_BITS(reg)) {
> +	case MAX77650_CHGIN_UNDERVOLTAGE_LOCKOUT:
> +		dev_err(chg->dev, "undervoltage lockout detected, disabling charger\n"=
);
> +		max77650_charger_disable(chg);
> +		break;
> +	case MAX77650_CHGIN_OVERVOLTAGE_LOCKOUT:
> +		dev_err(chg->dev, "overvoltage lockout detected, disabling charger\n");
> +		max77650_charger_disable(chg);
> +		break;
> +	case MAX77650_CHGIN_OKAY:
> +		max77650_charger_enable(chg);
> +		break;
> +	default:
> +		/* May be 0x10 - debouncing */
> +		break;
> +	}
> +
> +	return IRQ_HANDLED;
> +}
> +
> +static int max77650_charger_get_property(struct power_supply *psy,
> +					 enum power_supply_property psp,
> +					 union power_supply_propval *val)
> +{
> +	struct max77650_charger_data *chg =3D power_supply_get_drvdata(psy);
> +	int rv, reg;
> +
> +	switch (psp) {
> +	case POWER_SUPPLY_PROP_STATUS:
> +		rv =3D regmap_read(chg->map, MAX77650_REG_STAT_CHG_B, &reg);
> +		if (rv)
> +			return rv;
> +
> +		if (MAX77650_CHARGER_CHG_CHARGING(reg)) {
> +			val->intval =3D POWER_SUPPLY_STATUS_CHARGING;
> +			break;
> +		}
> +
> +		switch (MAX77650_CHG_DETAILS_BITS(reg)) {
> +		case MAX77650_CHG_OFF:
> +		case MAX77650_CHG_SUSP_PREQ_TIM_FAULT:
> +		case MAX77650_CHG_SUSP_FAST_CHG_TIM_FAULT:
> +		case MAX77650_CHG_SUSP_BATT_TEMP_FAULT:
> +			val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING;
> +			break;
> +		case MAX77650_CHG_PREQ:
> +		case MAX77650_CHG_ON_CURR:
> +		case MAX77650_CHG_ON_CURR_JEITA:
> +		case MAX77650_CHG_ON_VOLT:
> +		case MAX77650_CHG_ON_VOLT_JEITA:
> +		case MAX77650_CHG_ON_TOPOFF:
> +		case MAX77650_CHG_ON_TOPOFF_JEITA:
> +			val->intval =3D POWER_SUPPLY_STATUS_CHARGING;
> +			break;
> +		case MAX77650_CHG_DONE:
> +			val->intval =3D POWER_SUPPLY_STATUS_FULL;
> +			break;
> +		default:
> +			val->intval =3D POWER_SUPPLY_STATUS_UNKNOWN;
> +		}
> +		break;
> +	case POWER_SUPPLY_PROP_ONLINE:
> +		rv =3D regmap_read(chg->map, MAX77650_REG_STAT_CHG_B, &reg);
> +		if (rv)
> +			return rv;
> +
> +		val->intval =3D MAX77650_CHARGER_CHG_CHARGING(reg);
> +		break;
> +	case POWER_SUPPLY_PROP_CHARGE_TYPE:
> +		rv =3D regmap_read(chg->map, MAX77650_REG_STAT_CHG_B, &reg);
> +		if (rv)
> +			return rv;
> +
> +		if (!MAX77650_CHARGER_CHG_CHARGING(reg)) {
> +			val->intval =3D POWER_SUPPLY_CHARGE_TYPE_NONE;
> +			break;
> +		}
> +
> +		switch (MAX77650_CHG_DETAILS_BITS(reg)) {
> +		case MAX77650_CHG_PREQ:
> +		case MAX77650_CHG_ON_CURR:
> +		case MAX77650_CHG_ON_CURR_JEITA:
> +		case MAX77650_CHG_ON_VOLT:
> +		case MAX77650_CHG_ON_VOLT_JEITA:
> +			val->intval =3D POWER_SUPPLY_CHARGE_TYPE_FAST;
> +			break;
> +		case MAX77650_CHG_ON_TOPOFF:
> +		case MAX77650_CHG_ON_TOPOFF_JEITA:
> +			val->intval =3D POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
> +			break;
> +		default:
> +			val->intval =3D POWER_SUPPLY_CHARGE_TYPE_UNKNOWN;
> +		}
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	return 0;
> +}
> +
> +static const struct power_supply_desc max77650_battery_desc =3D {
> +	.name		=3D "max77650",
> +	.type		=3D POWER_SUPPLY_TYPE_USB,
> +	.get_property	=3D max77650_charger_get_property,
> +	.properties	=3D max77650_charger_properties,
> +	.num_properties	=3D ARRAY_SIZE(max77650_charger_properties),
> +};
> +
> +static int max77650_charger_probe(struct platform_device *pdev)
> +{
> +	struct power_supply_config pscfg =3D {};
> +	struct max77650_charger_data *chg;
> +	struct power_supply *battery;
> +	struct device *dev, *parent;
> +	int rv, chg_irq, chgin_irq;
> +	unsigned int prop;
> +
> +	dev =3D &pdev->dev;
> +	parent =3D dev->parent;
> +
> +	chg =3D devm_kzalloc(dev, sizeof(*chg), GFP_KERNEL);
> +	if (!chg)
> +		return -ENOMEM;
> +
> +	platform_set_drvdata(pdev, chg);
> +
> +	chg->map =3D dev_get_regmap(parent, NULL);
> +	if (!chg->map)
> +		return -ENODEV;
> +
> +	chg->dev =3D dev;
> +
> +	pscfg.of_node =3D dev->of_node;
> +	pscfg.drv_data =3D chg;
> +
> +	chg_irq =3D platform_get_irq_byname(pdev, "CHG");
> +	if (chg_irq < 0)
> +		return chg_irq;
> +
> +	chgin_irq =3D platform_get_irq_byname(pdev, "CHGIN");
> +	if (chgin_irq < 0)
> +		return chgin_irq;
> +
> +	rv =3D devm_request_any_context_irq(dev, chg_irq,
> +					  max77650_charger_check_status,
> +					  IRQF_ONESHOT, "chg", chg);
> +	if (rv < 0)
> +		return rv;
> +
> +	rv =3D devm_request_any_context_irq(dev, chgin_irq,
> +					  max77650_charger_check_status,
> +					  IRQF_ONESHOT, "chgin", chg);
> +	if (rv < 0)
> +		return rv;
> +
> +	battery =3D devm_power_supply_register(dev,
> +					     &max77650_battery_desc, &pscfg);
> +	if (IS_ERR(battery))
> +		return PTR_ERR(battery);
> +
> +	rv =3D of_property_read_u32(dev->of_node,
> +				  "input-voltage-min-microvolt", &prop);
> +	if (rv =3D=3D 0) {
> +		rv =3D max77650_charger_set_vchgin_min(chg, prop);
> +		if (rv)
> +			return rv;
> +	}
> +
> +	rv =3D of_property_read_u32(dev->of_node,
> +				  "input-current-limit-microamp", &prop);
> +	if (rv =3D=3D 0) {
> +		rv =3D max77650_charger_set_ichgin_lim(chg, prop);
> +		if (rv)
> +			return rv;
> +	}
> +
> +	return max77650_charger_enable(chg);
> +}
> +
> +static int max77650_charger_remove(struct platform_device *pdev)
> +{
> +	struct max77650_charger_data *chg =3D platform_get_drvdata(pdev);
> +
> +	return max77650_charger_disable(chg);
> +}
> +
> +static struct platform_driver max77650_charger_driver =3D {
> +	.driver =3D {
> +		.name =3D "max77650-charger",
> +	},
> +	.probe =3D max77650_charger_probe,
> +	.remove =3D max77650_charger_remove,
> +};
> +module_platform_driver(max77650_charger_driver);
> +
> +MODULE_DESCRIPTION("MAXIM 77650/77651 charger driver");
> +MODULE_AUTHOR("Bartosz Golaszewski <bgolaszewski@baylibre.com>");
> +MODULE_LICENSE("GPL v2");
> --=20
> 2.21.0
>=20

--iv63luv6q6gtugy6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAly3lSgACgkQ2O7X88g7
+poGKA//VshDwxA5VlH8WiOSKhNmeLGcjsiWmJoasiQdLr/ZkMAqbZ5PgjCtKJxw
2M86g+Coz+xtqroOpxpaFLbsWRT3HQf00ondOcg1s4TdT/IFsKFnRqnfUKaUGS+R
U/paNiRCFPrJjYsowABTwXyxzZTvbxYUmyUQARxbcH2sMXIpBVzebxvDUf4iIq4H
IPU9NUyAsYQCq56G6bD1naum8vfizlp1vDTbYUYoC5OoKXTo0w+HbkkIr1XEVNzQ
3weY4JvqTO7i+X9G5apWB814dlMUQGK602eSyqrya8PJF6jh1B07Zr1KRiu0LjR1
JSHFtRCFBYLBXzkmv0GUiSACp+IrsdZOBIx87B2Ai8LudkR2pg7fE+fA3PMssRH5
OmYObqZTWx691V3XBaZYGMjaUs2LJvoT8txtRW+PDEi5/NUaiEF7vob68ckeX8LY
8VaI37Yz5pVZKD0gxURnTQkJuOtcMB3YSQVsKQTb2Y1VKAkv0Du7oCD4cZ/AtUSw
qs1Zqdyw9MeAFk4olQd4wtYUDg8Gw6L8kDrtj/5Qs3nYc9rl6AgxxDUOQjHe/She
swA6mWjjomKo4muO8oYMDr2nnn9rL/0aCQcKQ9qkqV+/dJAYPDKGD7YflRnPfDCa
3L6Zh3eQjnlJe7H70kdd2h+7cKFEU3ImKtn66kE21HLt4h+X3Ks=
=aJPl
-----END PGP SIGNATURE-----

--iv63luv6q6gtugy6--