Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 17 Apr 2019 22:30:09 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Lee Jones <lee.jones@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v9 02/11] dt-bindings: power: supply: add DT bindings for
 max77650
Message-ID: <20190417203009.saoa63glegq4eb3v@earth.universe>
References: <20190411124212.7612-1-brgl@bgdev.pl>
 <20190411124212.7612-3-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7fhkjxtdavvca5ie"
Content-Disposition: inline
In-Reply-To: <20190411124212.7612-3-brgl@bgdev.pl>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--7fhkjxtdavvca5ie
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Apr 11, 2019 at 02:42:03PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>=20
> Add the DT binding document for the battery charger module of max77650.
>=20
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  .../power/supply/max77650-charger.txt         | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/max776=
50-charger.txt
>=20
> diff --git a/Documentation/devicetree/bindings/power/supply/max77650-char=
ger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.t=
xt
> new file mode 100644
> index 000000000000..821a2240e70f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> @@ -0,0 +1,28 @@
> +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> +
> +This module is part of the MAX77650 MFD device. For more details
> +see Documentation/devicetree/bindings/mfd/max77650.txt.
> +
> +The charger is represented as a sub-node of the PMIC node on the device =
tree.
> +
> +Required properties:
> +--------------------
> +- compatible:		Must be "maxim,max77650-charger"
> +
> +Optional properties:
> +--------------------
> +- input-voltage-min-microvolt:	Minimum CHGIN regulation voltage. Must be=
 one
> +				of: 4000000, 4100000, 4200000, 4300000,
> +				4400000, 4500000, 4600000, 4700000.
> +- input-current-limit-microamp:	CHGIN input current limit (in microamps)=
=2E Must
> +				be one of: 95000, 190000, 285000, 380000,
> +				475000.

The binding looks good to me.

> +Example:
> +--------
> +
> +	charger {
> +		compatible =3D "maxim,max77650-charger";
> +		min-microvolt =3D <4200000>;
> +		curr-lim-microamp =3D <285000>;
> +	};

The example does not match the binding.

-- Sebastian

--7fhkjxtdavvca5ie
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAly3jMUACgkQ2O7X88g7
+poRyxAAlC312T7qc3WLeS8sgNYvcN2jm8slesimGubCyfHSTmE5uHQkIWF9tTnr
piMNbali+wQmePuzKQgrdPMRljrVIS0K+3OUatTEitWnMrJsLbNLeAnCkmiN/6v4
KJEf8MvJGJmmTv6VzENcZPzUR8W25piJdB9qQO9snTh+c250VHwqiL9WAJnC3rhy
Lz+PQishmNyw5/B2VOICjFKmsFfK1FzO41kmfTjXwJYY6PIsl/IHrT98ph/dz0Ng
X7mfv4bq1aem6uicG+qMIhZUtcBwsLW79TF16HLYbrpPXtBMdXuHFRLvgt4TSNVH
QB9cGl9az/3mqGcQOjAYPgbEYgdNHkiWY4hCu7ZTha7aL50SU8idcNnnmpi0vCHB
iOKrTUuvb9dNM2NTkC6nENi2+Q0xg6LkqeaM4xAee2u2/sFVAL9utF+56T2A+050
8b4p8ItAR6zR7JFQYviVyEYhR7L/phnJjYYzL/KgV6qtKYeBG4Je2xwOsZnfqd4q
t/d1KaJzmHAOFGVkbycroQaMk0SNM6CwBLi4uDTCRSv2B9V2UYTouGCXyyyoxSfy
NjQKWh4Dl8KdVO48ILGHH4idCtA8qi0dhAexL7AEpG9rgxqK2Zo6fjk98vd+UbGL
YZVUF6mQlLuEPWrqBmqiHTvrXMR2Qy62napScFntBc6C2b85IXE=
=8/J+
-----END PGP SIGNATURE-----

--7fhkjxtdavvca5ie--