Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp217634yba; Wed, 17 Apr 2019 23:23:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqylZgGC/MJ799lc9nkv3eFwK8P50knaIJWn5F8N+1kAI+/J6KZVkIYPUd830B2PlZmkjeYp X-Received: by 2002:a63:1003:: with SMTP id f3mr84410925pgl.227.1555568602092; Wed, 17 Apr 2019 23:23:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555568602; cv=none; d=google.com; s=arc-20160816; b=Vl5qV543JrXypW74aziZYfq6RuU1OOfXK011jd75IIqw7Yz0VoawaQZ0Z/X3cc/PoV KqQ/7gpulADVCRdIwLzFC4hifu/bd56xseLFg7vlbTgMsE3w56A3b9ct+SexzvJxisnX qFz46iTz5zLakeKUUXIic6dlIrYk/HGuoYH7yG1JU3QeSpIlOfnPIL+RJ9Dv614QVzhD S+US6VcpQLu6q2fBwB6ridi8erKzA56Gt4YHe/k7d6OKqqHLMQQRwE01Y8ZpfoNDdFyo XY7i/9+wWpfDlFbdU9wdTNYWQS/rvwYTd3fOHA9jPn5QUggNWHHhDepV1iENoT4vl0bh aqKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=v7aEJ1W5ippJXMJXUEdhavT0rDligzyh11EH6PIgT4w=; b=tsAPpixhwVs7ZhjENZPTbSy5Vihv43YEwS3+L5Wvl8LJhW3DYuumFwVRckmW2ZlE1w HxPY5I2rKpprV0FaAJyXDnqkdoboZiXLxy2QLBXrVgSJhRwqipCwkOXY2NkTjPLMcGqs 1NUuUJAgy9QDQSX/eMEoHzPoMuyB2wM5LsKnyVKVV1e/AcPTcuyICwEfDcKDitW2P6E2 zf7EZveZ3grMynhGEhIR+nTRuATJlT0cum9/L/DS+Hspq+EjYHAJ1wVO8hsAceMLH/ZT n2tD98b2b7U35f7wphLOunJ4w/PltdwtSEF6eTAlHEAjzKxCqiwXDAs+MfwwfNAV+dwc eLiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si1052589pgs.343.2019.04.17.23.23.07; Wed, 17 Apr 2019 23:23:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388046AbfDRGVD (ORCPT + 99 others); Thu, 18 Apr 2019 02:21:03 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35500 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbfDRGVD (ORCPT ); Thu, 18 Apr 2019 02:21:03 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A0CEC103CB437; Wed, 17 Apr 2019 23:21:02 -0700 (PDT) Date: Wed, 17 Apr 2019 23:21:02 -0700 (PDT) Message-Id: <20190417.232102.230088678014335132.davem@davemloft.net> To: yuehaibing@huawei.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, aaro.koskinen@nokia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH] net: stmmac: Use bfsize1 in ndesc_init_rx_desc From: David Miller In-Reply-To: <20190417014939.36656-1-yuehaibing@huawei.com> References: <20190417014939.36656-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 17 Apr 2019 23:21:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yue Haibing Date: Wed, 17 Apr 2019 09:49:39 +0800 > From: YueHaibing > > gcc warn this: > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c: In function ndesc_init_rx_desc: > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:138:6: warning: variable 'bfsize1' set but not used [-Wunused-but-set-variable] > > Like enh_desc_init_rx_desc, we should use bfsize1 > in ndesc_init_rx_desc to calculate 'p->des1' > > Fixes: 583e63614149 ("net: stmmac: use correct DMA buffer size in the RX descriptor") > Signed-off-by: YueHaibing Applied, thank you.