Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp294620yba; Thu, 18 Apr 2019 01:09:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwivCDnoE/n/6L/5+K4b3sVOrYSZ74muuhG3OVdxNLBgZ7joLhgPupAHV04jUnRyldTS3KV X-Received: by 2002:a17:902:31c3:: with SMTP id x61mr90728962plb.143.1555574993480; Thu, 18 Apr 2019 01:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555574993; cv=none; d=google.com; s=arc-20160816; b=BdATKzjPPRz5EQIMXjDevOCP/OKVOJo2Y+p6fwq2ldgTBL54kfk6CCuKW2KOplGFpa GKJ/C4AKbz8+LbV8FH/rjpv0twL5rtaVfD+tV0G+IcL0S9zC3QkOwwKE+uptStJ9cvaM Ih63P/j9eNRqp2Z3BX3272PreWDtzruy76NQbBcYjO2VYdm+bL8clsoBbh0l5f1F2zh/ UqCVzt7PEytB3T/gLhrlSLXucDFyx31KcjH6pWh17C/rBMzyLSfGowl4LEqVuHTrDPXj SMcVHlcj6cL1E2J7R1jctJoV3W604Av1FZMqeZCabhu30PSRujpZWhEHFTZUbURpd2h6 ETLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=a6N6kxg07B+EY+PPBRMX9GWuEy/seJ5aYAuiLPMm2II=; b=ja4TsUT3eXJ/WH93AA/iOBmiMqWeXAEK/xmVXmmG5euCZPhedlOafmeyx/28mJBPhB 5TuXUBoFqrc/KF58Lx9+zMqJ0P35Gyvusy7OIlB4RKe8Skoo+LQbtVGoafau/xItrbgc tFPvEiSSNxTdINHik2x7+y5ugWpkrZIm2b96ajPqc4n8W7g9F1GUQOEGVuTO+5UI8bc4 k1atjRe30CtloxP+Q20i0NiQNcLPIE7cbrPlmQSNBdh55y9hxByLXe91ZjxkmovRWwZ1 Fo4Clg346AZWo85+EEDXlaTT9X2bojZdGxaJLmc6GdrtFZhl62Ef2Qn//FoqndBt6BiX iYIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id be7si1396525plb.266.2019.04.18.01.09.38; Thu, 18 Apr 2019 01:09:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388052AbfDRIHW (ORCPT + 99 others); Thu, 18 Apr 2019 04:07:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57096 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729497AbfDRIHW (ORCPT ); Thu, 18 Apr 2019 04:07:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5C7E308A102; Thu, 18 Apr 2019 08:07:21 +0000 (UTC) Received: from localhost (holly.tpb.lab.eng.brq.redhat.com [10.43.134.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8535D1001DDE; Thu, 18 Apr 2019 08:07:20 +0000 (UTC) Date: Thu, 18 Apr 2019 10:07:10 +0200 From: Miroslav Lichvar To: Ondrej Mosnacek Cc: Linux kernel mailing list , Thomas Gleixner , John Stultz , Richard Cochran , Prarit Bhargava Subject: Re: [PATCH] ntp: Allow TAI-UTC offset to be set to zero Message-ID: <20190418080710.GE5984@localhost> References: <20190417084833.7401-1-mlichvar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 18 Apr 2019 08:07:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 17, 2019 at 11:00:23AM +0200, Ondrej Mosnacek wrote: > On Wed, Apr 17, 2019 at 10:48 AM Miroslav Lichvar wrote: > > Change the ADJ_TAI check to accept zero as a valid TAI-UTC offset in > > order to allow setting it back to the initial value. > Thanks for sending the patch! Maybe you (or the committer) could > consider adding: > > Fixes: 153b5d054ac2 ("ntp: support for TAI") To me the change looks more like an extension of the API, rather than a bug fix, so I'd leave that up to the committer. -- Miroslav Lichvar