Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp345634yba; Thu, 18 Apr 2019 02:12:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVv0oKil2kMvtWO0GMgeEt2GbW6YUonbxJ79/rXgZJK1bOOjy2B/ccwwZCxNC2VuGq7UJD X-Received: by 2002:a62:a515:: with SMTP id v21mr94817501pfm.41.1555578741553; Thu, 18 Apr 2019 02:12:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555578741; cv=none; d=google.com; s=arc-20160816; b=qLQeEBXtRhQI9ajjRWcCPie3LIiH8dM1WSY7kdLYP8xquXOFEVoOmcQiCM24mJ1Y3r 9+dCjY9IZGuZlXOKilq2+qIT03qLtEooWsqUG4b1G0c4yFK5kMawZErmE/kilmvoTjcl QE9HZIg5nHHbfSntJmhdZu3vwYrV6exiqXzsO7aELqAJiVbINr+HBzBPVhG1sXMVP4PB Kzi4frmH5VwYD4voOhE3WupEt2gW31+npjXy56SGt/L6LUJ07OjCrWl/+vFqrFn8bwVd B7Hoj0CKsElpsGvrh6pKZ2PoEQHzWvgw61/GNS6CKepvzgPf8DUEX+ss5yfk0SFY+CPJ 9Y7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=q6gVGOPr5cy4kqSTrlnr9aTYqPVhjkj+u0nkK5jJ8hY=; b=HiM/u7PH8vJbXSV2sSZotsAqZydrWLHBXo1fI7W9KOxOFmg/x/YTAI47VErseU2nFD 7gC2/LorZfg2AmAdZHnhFQ3WWO7dmJxk06Hf/MzXGh9UIv3FIu+ris9SGhAspg13fgjA UByCFh6HCZds+mDUWX4uoU6CqUHZQVMGGsIcLoEzWAQugYFBDtV14O7QDPa+KYJ0I2YM uZmSTy1v0gvXDzJE8EADeuv+4jWUvWsHa0F7rjV5BDTY38+4XeG45qTBcI3GlGrK3ISN dgpMsthq8+bdVHFnqMsfb9Yvp4/GN4vMcdm/iDzHX9zW+SJKtkCwCsg+EJKh93JMV1Wd l1AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k70si1356686pgd.75.2019.04.18.02.12.07; Thu, 18 Apr 2019 02:12:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388502AbfDRJH3 (ORCPT + 99 others); Thu, 18 Apr 2019 05:07:29 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34003 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388476AbfDRJHW (ORCPT ); Thu, 18 Apr 2019 05:07:22 -0400 Received: from pd9ef12d2.dip0.t-ipconnect.de ([217.239.18.210] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hH30q-00025T-FO; Thu, 18 Apr 2019 11:07:20 +0200 Date: Thu, 18 Apr 2019 11:07:14 +0200 (CEST) From: Thomas Gleixner To: Miroslav Lichvar cc: Ondrej Mosnacek , Linux kernel mailing list , John Stultz , Richard Cochran , Prarit Bhargava Subject: Re: [PATCH] ntp: Allow TAI-UTC offset to be set to zero In-Reply-To: <20190418080710.GE5984@localhost> Message-ID: References: <20190417084833.7401-1-mlichvar@redhat.com> <20190418080710.GE5984@localhost> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Apr 2019, Miroslav Lichvar wrote: > On Wed, Apr 17, 2019 at 11:00:23AM +0200, Ondrej Mosnacek wrote: > > On Wed, Apr 17, 2019 at 10:48 AM Miroslav Lichvar wrote: > > > Change the ADJ_TAI check to accept zero as a valid TAI-UTC offset in > > > order to allow setting it back to the initial value. > > > Thanks for sending the patch! Maybe you (or the committer) could > > consider adding: > > > > Fixes: 153b5d054ac2 ("ntp: support for TAI") > > To me the change looks more like an extension of the API, rather than > a bug fix, so I'd leave that up to the committer. I don't see why we need to backport that all the way, but I'm happy to add the tag if there is some really good reason. Thanks, tglx