Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Apr 2019 12:11:36 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Zhao Yakui <yakui.zhao@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
        Jason Chen CJ <jason.cj.chen@intel.com>
Subject: Re: [RFC PATCH v4 4/4] x86/acrn: Add hypercall for ACRN guest
Message-ID: <20190418101136.GE27160@zn.tnic>
References: <1555293657-32233-1-git-send-email-yakui.zhao@intel.com>
 <1555293657-32233-5-git-send-email-yakui.zhao@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1555293657-32233-5-git-send-email-yakui.zhao@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 15, 2019 at 10:00:57AM +0800, Zhao Yakui wrote:
> When ACRN hypervisor is detected, the hypercall is needed so that the
> ACRN guest can query/config some settings. For example: it can be used
> to query the resources in hypervisor and manage the CPU/memory/device/
> interrupt for guest operating system.
> 
> Add the hypercall so that the kernel can communicate with the low-level
> ACRN hypervisor. It is implemented with vmacll instruction.

This still has unfixed stuff from 2 review cycles ago.

Thomas corrected this in his review to:

"is implemented with the VMCALL instruction"

https://lkml.kernel.org/r/alpine.DEB.2.21.1904052110370.1802@nanos.tec.linutronix.de

You ignored it.

I reminded you about it and suggested to check and incorporate *all*
review feedback before sending another version:

https://lkml.kernel.org/r/20190408151010.GI15689@zn.tnic

You ignored it again.

Now, if you get ignored, you know why, right?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.