Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp409411yba; Thu, 18 Apr 2019 03:27:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqytmOsb5P6fqO+E5wLcbHQGrvLOk3qIsRSYrEs1qK9CUPHSB2snNBOjXE6HBfEttcFNB5gd X-Received: by 2002:a65:6210:: with SMTP id d16mr85385261pgv.110.1555583272951; Thu, 18 Apr 2019 03:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555583272; cv=none; d=google.com; s=arc-20160816; b=CN+HevFlK8njLCT0k4f3QDZWKn111X26Ep9jGRJCFjB8gZo1JYLS7DCmd56PiNb7LJ XozZxWRC1gJsFv1mZ7LqAKZhvs2lXQvpceKN3Qr8IIUbeVXkgrSo4cuKeHf9tl0vTU5z f5M86By1IbvraAA6ZaWZLZKb6n9EjKhrAUMbMoHT0kryFwrJzHpVItYH5kq0L9GP57jB C1X7yGGziuCAbFYU+w9ooQCHkNinN4fenKq8/Kb+9fo0prkfa4GoHAPv/Skr5ur6oGmk f+VTkU2v0JaOS9ETc82+520jrxV54Sf3yx+ZFq35CDr9VpJHmEl+5WNvaZ1i/I3zwHnu GQrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=LV/65aUtd9UeO3R9C90Hjzz3scp3r81sXNsJ0e5OFKo=; b=ieOSEp3DT67oYHHTovJVeWswT2SiF7aOwgFujwGruqVLPspNY4YPyWHX0wDduR56iy 4J00Dk0LWhUZoqgSJptzVFrOBfu6ztFNfgxulQHZLxWVKccQ2kD3zmMHt4xSie6w0Cb1 dZ3vCnfFNxliK7dGvnHqnJE+QTouFHwIQFNwVp9ybdieIHIcNiKphm7OV2Cs8UT6BBGs HCz6bLZwgGf4figQ9wPPrwhPhdiW+Z5qv/rtwctoi9KwsPeAu6BUdvvePOvo7a1+bo+R Y+XWCHNcm69ySlq3SZ8xqsTgBayiNdRCE0I+5xRhGZnmKbgrECfxZsWrWe/3KopbuCM6 8fGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Pa+ucECO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y9si1573479pgh.55.2019.04.18.03.27.38; Thu, 18 Apr 2019 03:27:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Pa+ucECO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388632AbfDRK0M (ORCPT + 99 others); Thu, 18 Apr 2019 06:26:12 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43786 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388415AbfDRK0L (ORCPT ); Thu, 18 Apr 2019 06:26:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=LV/65aUtd9UeO3R9C90Hjzz3scp3r81sXNsJ0e5OFKo=; b=Pa+ucECOzRT8 XBh28V1cHylYN8suYnhRZy+2R2SaXvW2J/cQcOeDtKYZ+6Xcu0k8Z9PEOQtytgpHvv09a7glNKiFK d+QWrI29PG4cGziLJEhI26mz++gjGph+MqL8ZE+ZCbrqb2XwS1TAWKWze5NSZfDg6zDALNtNPXBRK GPYAI=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1hH4F6-0001TL-8Z; Thu, 18 Apr 2019 10:26:08 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 88C6711279BC; Thu, 18 Apr 2019 11:26:07 +0100 (BST) From: Mark Brown To: Jorge Ramirez-Ortiz Cc: broonie@kernel.org, jorge.ramirez-ortiz@linaro.org, khasim.mohammed@linaro.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown Subject: Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree In-Reply-To: <20190417192443.6501-1-jorge.ramirez-ortiz@linaro.org> X-Patchwork-Hint: ignore Message-Id: <20190418102607.88C6711279BC@debutante.sirena.org.uk> Date: Thu, 18 Apr 2019 11:26:07 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: core: do not report EPROBE_DEFER as error but as debug has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 317f0111220921e87a168e4e6cec275df4e9be01 Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Wed, 17 Apr 2019 21:24:43 +0200 Subject: [PATCH] regulator: core: do not report EPROBE_DEFER as error but as debug Temporary failures to get a regulator (EPROBE_DEFER) should be logged as debug information instead of errors. Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Mark Brown --- drivers/regulator/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5a9ebcf7fe7a..08ccabe07fe3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4345,8 +4345,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers, consumers[i].supply); if (IS_ERR(consumers[i].consumer)) { ret = PTR_ERR(consumers[i].consumer); - dev_err(dev, "Failed to get supply '%s': %d\n", - consumers[i].supply, ret); consumers[i].consumer = NULL; goto err; } @@ -4355,6 +4353,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers, return 0; err: + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get supply '%s': %d\n", + consumers[i].supply, ret); + else + dev_dbg(dev, "Failed to get supply '%s', deferring\n", + consumers[i].supply); + while (--i >= 0) regulator_put(consumers[i].consumer); -- 2.20.1