Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 18 Apr 2019 12:16:47 +0000 (UTC)
From:   Michael Matz <matz@suse.de>
To:     Linus Torvalds <torvalds@linux-foundation.org>
cc:     Borislav Petkov <bp@alien8.de>, x86-ml <x86@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] asm/io: Correct output operand specification of the MMIO
 write* routines
In-Reply-To: <CAHk-=wjazpzX=Y==69hfafDpcgcrwaNcZ-XdJnoVXX8+iy3zLA@mail.gmail.com>
Message-ID: <alpine.LSU.2.21.1904181203170.8064@wotan.suse.de>
References: <20190417085008.GB20492@zn.tnic> <CAHk-=wjazpzX=Y==69hfafDpcgcrwaNcZ-XdJnoVXX8+iy3zLA@mail.gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, 17 Apr 2019, Linus Torvalds wrote:

> So I see no upside to changing it.

As long as the memory clobber stays (and it can't be removed in the 
general case, as you say) the change has no practical effect.

<outsider>
It does have a psychological upside, though: people won't continue to 
wonder why the asm doesn't precisely specify what it does, and instead 
only declares a memory-read while clearly being a memory write.  
Normally, with asms, leaving nothing to wonder about is a good thing.
</outsider>


Ciao,
Michael.