Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RFC] staging: vc04_services: handle kzalloc failure
To:     Nicholas Mc Guire <hofrat@osadl.org>, Eric Anholt <eric@anholt.net>
Cc:     devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Phil Elwell <phil@raspberrypi.org>,
        linux-kernel@vger.kernel.org,
        Tobias Buettner <tobias.buettner@fau.de>,
        Luis Chamberlain <mcgrof@kernel.org>,
        linux-rpi-kernel@lists.infradead.org,
        Dominic Braun <inf.braun@fau.de>,
        Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
        linux-arm-kernel@lists.infradead.org
References: <1555583384-15670-1-git-send-email-hofrat@osadl.org>
From:   Stefan Wahren <stefan.wahren@i2se.com>
Message-ID: <bf13c010-745d-8c0b-c73f-2dacb26e3346@i2se.com>
Date:   Thu, 18 Apr 2019 14:34:32 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1555583384-15670-1-git-send-email-hofrat@osadl.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 18.04.19 12:29, Nicholas Mc Guire wrote:
> The kzalloc here was being used without checking the return - if the
> kzalloc fails return VCHIQ_ERROR. The call-site of
> vchiq_platform_init_state() vchiq_init_state() was not responding
> to an allocation failure so checks for != VCHIQ_SUCCESS
> and pass VCHIQ_ERROR up to vchiq_platform_init() which then
> will fail with -EINVAL.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>