Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp597650yba; Thu, 18 Apr 2019 06:35:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLeqc4+nRs9fMTOFl4wMYZWVAOfc7rOwqbaQ4y5XX6PUdXdpfC2fRWnexvoEXabexgRwiU X-Received: by 2002:a65:64cf:: with SMTP id t15mr86319026pgv.322.1555594534960; Thu, 18 Apr 2019 06:35:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555594534; cv=none; d=google.com; s=arc-20160816; b=f+XpTOSPSGkVhguac7b0IRwBxYapDTjaX7VFFFePF8iQpuTrqlS+MRSPoLNQ2bK1Jo tLd2sukc+fCJGhKcEAXIlaCntNAPrPJGtyrBL43RvTegv7iBCmZFi0BGN/yZVcIXm4c+ RDegPZTc2tJhVDp59a5WqcudCT4Zw1tJ7rzg3HSgB/MPoWYVXHZRnu3PLWg/3p1/h9Cj QK3orzidfiyO5UcP1zk/t68AUa98gBAvDYzKkXta6gO2XPekbgFgf1ob9qzBua8dt2J0 zTxqCkvg0UJDmnyUKtfrnlzC6OiGVJ4AZlTTRL1/3lWzg9OYEe0nrhmtQLl0G+wwXjoy fUTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fVMDvZEZiCuGOnAjMQl6ngtpe23dJ0SmPq90J6AH18o=; b=bEmXwRvJ8LBiCa9oz+sQPQ9/WH+PRFEdl8iGklYQvxlDLGir3+C/qNqxG4+67yI5TY t3iXont8nroTNHuM0XQmElaymi3SYTKfhaZT+DjKsib8pt9xEq5a+oC0jX8zz8cXvrMA 6AaMAuDd0ogRT2NlyNHE8sRYqnLMRlS8MELpcPxAtexMccNJ12GIuZF/JJk+mFp7wE3m 3sfEZDL/JHsrnnOtExocAZ/HiusEb8rTLycF5dLQsVgapfzQ35RvIf89CmEyHhzw3JpY IiSHlYdAAkxxzlc8sR3VBZcMprdiqPAUpHWsryAfTGFHG9yIRA/2lXoi90QjwE1xl6FU UN0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=XEy5puxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p66si1312852pga.15.2019.04.18.06.35.20; Thu, 18 Apr 2019 06:35:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=XEy5puxF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389069AbfDRN0u (ORCPT + 99 others); Thu, 18 Apr 2019 09:26:50 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53372 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388302AbfDRN0u (ORCPT ); Thu, 18 Apr 2019 09:26:50 -0400 Received: from zn.tnic (p200300EC2F112E003868EF36058F9C84.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:2e00:3868:ef36:58f:9c84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 22C5D1EC0380; Thu, 18 Apr 2019 15:26:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1555594008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=fVMDvZEZiCuGOnAjMQl6ngtpe23dJ0SmPq90J6AH18o=; b=XEy5puxF3DaO4zTv5yir99OePccTPj+rhmJXehwr9d4d9njPMEh6SVgmMJEWe8PbdcuYIw D2c/oyjM3LTkOZHLqtsCriCMKxDb+j4ATCz3pW3Q/xUmrZLmSiuuYrpaf2UQyxaXLVPhXI 38RSi8h6WWFKlsh1b40XdtBwJhukkMU= Date: Thu, 18 Apr 2019 15:26:41 +0200 From: Borislav Petkov To: "Lendacky, Thomas" Cc: lijiang , "linux-kernel@vger.kernel.org" , "kexec@lists.infradead.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "akpm@linux-foundation.org" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "x86@kernel.org" , "hpa@zytor.com" , "dyoung@redhat.com" , "bhe@redhat.com" Subject: Re: [PATCH 1/2 RESEND v10] x86/mm, resource: add a new I/O resource descriptor 'IORES_DESC_RESERVED' Message-ID: <20190418132641.GJ27160@zn.tnic> References: <20190329123914.20939-1-lijiang@redhat.com> <20190329123914.20939-2-lijiang@redhat.com> <20190402090652.GD6826@zn.tnic> <20190402124328.GG6826@zn.tnic> <384ba880-1b53-8013-8be8-66f294c27100@redhat.com> <20190415154155.GH29317@zn.tnic> <60d67667-c9c4-29bd-0a8a-d3ae13022d87@redhat.com> <20190418100138.GD27160@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 01:17:03PM +0000, Lendacky, Thomas wrote: > You could probably make this unsigned int for now since you're creating > the new enum used to assign to this variable and it only uses two bits > currently. Right. > > + if (res->desc & (IORES_DESC_NONE | IORES_DESC_RESERVED)) > > + return 0; > > The IORES_DESC_xxxx enums are not bits, just sequential numbers, so you > won't be able to test them this way. You can probably get away with a > switch statement here. Ah, good catch. I thought they're BITs too. Oh well. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.