Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416150051.34092-1-yuehaibing@huawei.com> <7c9d75dd-ec67-4491-ca0c-79743211f308@arm.com>
In-Reply-To: <7c9d75dd-ec67-4491-ca0c-79743211f308@arm.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 18 Apr 2019 09:32:44 -0500
Message-ID: <CAL_Jsq+5R3WWk-CmagO9=HE2nqPyGoHJ9aankYWh2ZOSO+k=eA@mail.gmail.com>
Subject: Re: [PATCH -next] drm/panfrost: Make panfrost_gem_free_object() static
To:     Steven Price <steven.price@arm.com>
Cc:     Yue Haibing <yuehaibing@huawei.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 17, 2019 at 9:51 AM Steven Price <steven.price@arm.com> wrote:
>
> On 16/04/2019 16:00, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > Fix sparse warning:
> >
> > drivers/gpu/drm/panfrost/panfrost_gem.c:17:6:
> >  warning: symbol 'panfrost_gem_free_object' was not declared. Should it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Steven Price <steven.price@arm.com>
>
> Although while we're fixing sparse warnings, there's a few more in Panfrost:
>
> -----8<-------
> From 8aaf778262744cfbebb9b7f274ead9ba600526b0 Mon Sep 17 00:00:00 2001
> From: Steven Price <steven.price@arm.com>
> Date: Wed, 17 Apr 2019 15:47:49 +0100
> Subject: [PATCH] drm/panfrost: Add missing include
>
> Fix sparse warnings:
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:133:5:
>  warning: symbol 'panfrost_devfreq_init' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:168:6:
>  warning: symbol 'panfrost_devfreq_resume' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:182:6:
>  warning: symbol 'panfrost_devfreq_suspend' was not declared. Should it be static?
> drivers/gpu/drm/panfrost/panfrost_devfreq.c:212:6:
>  warning: symbol 'panfrost_devfreq_record_transition' was not declared. Should it be static?
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_devfreq.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.