Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp675144yba; Thu, 18 Apr 2019 07:48:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJb9i7JIZ6ztDuFLVWPx3NAS96n63Mpwg0w6mZ5jZM12Wo9NHks0NKt2CSVcbcWBCdTIFF X-Received: by 2002:a62:7591:: with SMTP id q139mr82839504pfc.14.1555598895570; Thu, 18 Apr 2019 07:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555598895; cv=none; d=google.com; s=arc-20160816; b=I/XptlzbVc/TDExajiHwtDvSpzu2xONznqSdhB/61SeNweoxcQ09r3KST/yP+OnsgJ wjzVVi7nvJvU1bpsjDF0J+VhGcDrCxZqysmL+o4jsvesebQoJNzpmyog82XkgbGNzIJV 6U0ZDKjPGT/Mxg6pdwd39YFC5YUtr8hlUbdwKnWo53t0/zs2ayjqv5onqHcWgEw2jA6d +uLLhtWOJXG7btr4qvGIxSp1h8HZZ7o+DSLMzxRY2I9z1hIaJ9GRIvxdyYKJMflon+zO zLE11zMiwHy4rJigErd4povuMQbkmnFnPoHncSyDrN+3+myyaWhYG+KKtfF6Ukpht0Z/ SEfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=a7HYmBlHd2e+527UKL+WWA5BpaWIwR/qJQj9+uE551k=; b=KkmUn1CKpkYgx1FUYuR3naIAI3ayXkxZtK5kG6/xFTB+6UnGwV3yjynQZvHXcwemJj e7kE09maLOurRvrelVv7SlPHPIdTipbqtRWNxBuX4Q/0NyLvm4val1JTpKdD445dqCnd J/FOKGcxCCLiGURART4OWmUWbfDCxXZhqMpDiblyl3HZPb5FqhBUqR6ScJhLqNpGlUtJ bBWhw6rYR7GPk+nGuCOVrzmC5FRs50YDGOroG8yysN/O60+MhsLnXeJvGIFDh6K7muNB kaWgh0PeGtbHFQ3P0qgMxXrwQ9Nwibc2Fq+BEyklgM0iQYHOo4nHyG1h/nDeZuW6JtNM 2VIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 98si2276790plb.84.2019.04.18.07.47.59; Thu, 18 Apr 2019 07:48:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389153AbfDROVV (ORCPT + 99 others); Thu, 18 Apr 2019 10:21:21 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39990 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733205AbfDROVV (ORCPT ); Thu, 18 Apr 2019 10:21:21 -0400 Received: from [123.118.215.169] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hH7ua-0008SV-Do; Thu, 18 Apr 2019 14:21:13 +0000 Subject: Re: [PATCH] nvme: determine the number of IO queues To: Keith Busch Cc: Maxim Levitsky , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, axboe@fb.com References: <1555510379-20199-1-git-send-email-aaron.ma@canonical.com> <096935354b16662eb481aeda1f48001ba489463c.camel@redhat.com> <20190418134820.GA7589@localhost.localdomain> From: Aaron Ma Openpgp: preference=signencrypt Autocrypt: addr=aaron.ma@canonical.com; prefer-encrypt=mutual; keydata= mQENBFffeLkBCACi4eE4dPsgWN6B9UDOVcAvb5QgU/hRG6yS0I1lGKQv4KA+bke0c5g8clbO 9gIlIl2bityfA9NzBsDik4Iei3AxMbFyxv9keMwcOFQBIOZF0P3f05qjxftF8P+yp9QTV4hp BkFzsXzWRgXN3r8hU8wqZybepF4B1C83sm2kQ5A5N0AUGbZli9i2G+/VscG9sWfLy8T7f4YW MjmlijCjoV6k29vsmTWQPZ7EApNpvR5BnZQPmQWzkkr0lNXlsKcyLgefQtlwg6drK4fe4wz0 ouBIHJEiXE1LWK1hUzkCUASra4WRwKk1Mv/NLLE/aJRqEvF2ukt3uVuM77RWfl7/H/v5ABEB AAG0IUFhcm9uIE1hIDxhYXJvbi5tYUBjYW5vbmljYWwuY29tPokBNwQTAQgAIQUCV994uQIb AwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRDNxCzQfVU6ntJ9B/9aVy0+RkLqF9QpLmw+ LAf1m3Fd+4ZarPTerqDqkLla3ekYhbrEtlI1mYuB5f+gtrIjmcW27gacHdslKB9YwaL8B4ZB GJKhcrntLg4YPzYUnXZkHHTv1hMw7fBYw82cBT+EbG0Djh6Po6Ihqyr3auHhfFcp1PZH4Mtq 6hN5KaDZzF/go+tRF5e4bn61Nhdue7mrhFSlfkzLG2ehHWmRV+S91ksH81YDFnazK0sRINBx V1S8ts3WJ2f1AbgmnDlbK3c/AfI5YxnIHn/x2ZdXj1P/wn7DgZHmpMy5DMuk0gN34NLUPLA/ cHeKoBAF8emugljiKecKBpMTLe8FrVOxbkrauQENBFffeLkBCACweKP3Wx+gK81+rOUpuQ00 sCyKzdtMuXXJ7oL4GzYHbLfJq+F+UHpQbytVGTn3R5+Y61v41g2zTYZooaC+Hs1+ixf+buG2 +2LZjPSELWPNzH9lsKNlCcEvu1XhyyHkBDbnFFHWlUlql3nSXMo//dOTG/XGKaEaZUxjCLUC 8ehLc16DJDvdXsPwWhHrCH/4k92F6qQ14QigBMsl75jDTDJMEYgRYEBT1D/bwxdIeoN1BfIG mYgf059RrWax4SMiJtVDSUuDOpdwoEcZ0FWesRfbFrM+k/XKiIbjMZSvLunA4FIsOdWYOob4 Hh0rsm1G+fBLYtT+bE26OWpQ/lSn4TdhABEBAAGJAR8EGAEIAAkFAlffeLkCGwwACgkQzcQs 0H1VOp6p5Af/ap5EVuP1AhFdPD3pXLNrUUt72W3cuAOjXyss43qFC2YRjGfktrizsDjQU46g VKoD6EW9XUPgvYM+k8BJEoXDLhHWnCnMKlbHP3OImxzLRhF4kdlnLicz1zKRcessQatRpJgG NIiD+eFyh0CZcWBO1BB5rWikjO/idicHao2stFdaBmIeXvhT9Xp6XNFEmzOmfHps+kKpWshY 9LDAU0ERBNsW4bekOCa/QxfqcbZYRjrVQvya0EhrPhq0bBpzkIL/7QSBMcdv6IajTlHnLARF nAIofCEKeEl7+ksiRapL5Nykcbt4dldE3sQWxIybC94SZ4inENKw6I8RNpigWm0R5w== Message-ID: Date: Thu, 18 Apr 2019 22:21:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190418134820.GA7589@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/18/19 9:48 PM, Keith Busch wrote: > It does change the default behavior. If I have a degraded controller that > can't do IO in a machine with 1000's of CPUs, I have to iterate this > non-standard behavior 1000's of times before the drive is servicable > again. We currenlty figure that out in just a single try. > > At least the quirks document *why* the driver is doing non-standard > behavior. We do the IO queue quirks for Macbooks, for example. > > But why don't you file a bug report with the device vendor instead? Surely > a firmware fix provides the best possible outcome, and would make this > device work not only in all versions of Linux, but also every standard > compliant driver for any OS. I will do it, no v2 for now. Thanks, Aaron