Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp732699yba; Thu, 18 Apr 2019 08:40:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAVe2lflQcC5+5dzSiveqPTLqWBGCECt9OyHhyV2VcTDD8EN7zvmZMjL6G6ydNva7WVu/h X-Received: by 2002:a65:518d:: with SMTP id h13mr11590724pgq.259.1555602017088; Thu, 18 Apr 2019 08:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555602017; cv=none; d=google.com; s=arc-20160816; b=XF72x5NH2zIK3UlRfr5VB11bDNUyKahVhHLDeGypz8i4pjE9VWZRn4s1CCjujWZghY Jjpvl7RyAkzLXHgb4Ckb16KjEX4ANfYUbtH8CGn5k4z+xKeL2i0DAyytf2/z5IiCpigH p/S8fmX8O5NYCKU6+J5khPFSorR+Ay5sgXn2K+rW2t727nuvuxh3oBvJLwVHDGbMYAOL LFqDq/RQHXkND9xisQm4PGGtBSHXIknlIWJG4v/F/iZ9dL8aEd0mKYV9qYLmBhNjn55l MFBJ+pUJuC6J9HSFIPC5SzgG3gYPj/wp67xH4efKl/dg9wPT3sqDuybuVUhya5eWdkYa QzCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=XodPk0tO9XZFc6dEjJ8GEO6K1zX/cqdhaYzeogsAOy0=; b=jbVIFoxtA7fCB3hsAMZZMAFtIVnqb2NdL2YGBZkTK2HB8AoO2ncu7hR8flnJ+Hyn68 B0wOIdN27uBov3I69NGoWEVohdhtRaHiz9EQjg5dy3AZCvC45eCLqWU2DcBcmSUHYEEy vSVqmHeFfvNJUxUzqhrePyWAk0eWvD8ySAG3UnNGsvNIL7zZrzUKtR8CkodqXvYIGAk8 EXKeWgZkYjlYJcVbGMK3DU7fHIPJ3d2RxfbCRRXzJXiK0nYaQq/3GkMDalYH2ZiFfTRL we41UFSn9hUrnkI1b2au1nk83tM1yPnnoDigIQI9a67G1fuS27flLNsWoQqwqXnfmXos XU5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=cp2WXtU1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2si2156501pgl.527.2019.04.18.08.40.01; Thu, 18 Apr 2019 08:40:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=cp2WXtU1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389372AbfDRPht (ORCPT + 99 others); Thu, 18 Apr 2019 11:37:49 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42382 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387519AbfDRPhs (ORCPT ); Thu, 18 Apr 2019 11:37:48 -0400 Received: by mail-lf1-f67.google.com with SMTP id w23so1963651lfc.9 for ; Thu, 18 Apr 2019 08:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XodPk0tO9XZFc6dEjJ8GEO6K1zX/cqdhaYzeogsAOy0=; b=cp2WXtU1lsKtCNNoK1F9P/xc+sX2rJfZ5ANlGelmk1WlUNeyJ0knbIKFQGhbNy+PKo 83Cg6Fmik+4cSKXhO5XSkjbAyX9KmccJgvbWbSiR6+7Fc0gAf0E39IXtkNeqrjibNkTq mP4nj4rH54HzJWtQ2p89/O5aMymCsPUurVh5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XodPk0tO9XZFc6dEjJ8GEO6K1zX/cqdhaYzeogsAOy0=; b=GCwAltoePQgvb8JzQc4fje4x/eGYanwzgXbKVTfrx1j6E+mxjX8Dder1A6W1PL8sQI ew/XkbfE/QGhDaiG2tLzuKD4hqb8U9HWTydZgSMZw5g3Asq7oMcLteoiSjybyP/t7r0O hpNeBfOlIr3xfd/EWcfAyyk7G/bsowjMvFM83ex9O6mTS5qpmt/vhUd8JmzSgS/GKn5Y 7rSBrChsdLPMn2Kc4HxH5CxcM7kHg+mIWhcLTHkS3SxUK1OGyYvZdU+Ef2hUrui11f9s 9c4LI3MKQBFJRw1380LL1IjPeMWxRini5HN/j64an6HandsY7xpVmARuA9SSOZrvq6mf 5L+w== X-Gm-Message-State: APjAAAUq3beRuYWTAbw9KebIP9uckxBl8+5iggv/g1QwkcATxZZWoRfM Lgbp3LEgtATmZq3fwzNHjCocI8AmKfg= X-Received: by 2002:ac2:5468:: with SMTP id e8mr5411356lfn.33.1555601866392; Thu, 18 Apr 2019 08:37:46 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id n23sm520588lfh.86.2019.04.18.08.37.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 08:37:45 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id v1so1978234lfg.5 for ; Thu, 18 Apr 2019 08:37:44 -0700 (PDT) X-Received: by 2002:a19:ca02:: with SMTP id a2mr22565410lfg.88.1555601864559; Thu, 18 Apr 2019 08:37:44 -0700 (PDT) MIME-Version: 1.0 References: <20190418101841.4476-1-christian@brauner.io> <20190418101841.4476-4-christian@brauner.io> In-Reply-To: <20190418101841.4476-4-christian@brauner.io> From: Linus Torvalds Date: Thu, 18 Apr 2019 08:37:28 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 3/5] signal: use fdget() since we don't allow O_PATH To: Christian Brauner Cc: Al Viro , Jann Horn , David Howells , Oleg Nesterov , Linux API , Linux List Kernel Mailing , "Serge E. Hallyn" , Andrew Lutomirski , Arnd Bergmann , "Eric W. Biederman" , Kees Cook , Thomas Gleixner , Michael Kerrisk-manpages , Andrew Morton , Aleksa Sarai , Joel Fernandes , Daniel Colascione , Jann Horn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 3:19 AM Christian Brauner wrote: > > It's just semantically correct to use fdget() > and return an error right from there instead of taking a reference and > returning an error later. I've applied this one directly, because it ends up affecting the existing code, and I'd rather just have the initial release of pidfd_send_signal() right. The other patches I consider to be "future release" material. Linus