Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp737071yba; Thu, 18 Apr 2019 08:44:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQeBTecMw6OqPEOzazDCPdnKx4PVMjlhHR+bhso1vekwmu8Mf0SPc8VYuplLhF4+7nHQzJ X-Received: by 2002:a63:5248:: with SMTP id s8mr8798706pgl.27.1555602287821; Thu, 18 Apr 2019 08:44:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555602287; cv=none; d=google.com; s=arc-20160816; b=VWS2QGoNh1xBRHVqOms/YL0jiozY4ZlQ2gbhVReRAxodFqiB2uK4pr6POUjmapCPST SszZRZrNml0/OJzgbOBAzb+ml/lgWU8QDpwmn6qEVYLUqBCliy0EHX3hQKI5jdqRafFh RzDGrYFCbyEFSCs7d6rKSpptpm8xrHOPHRMhgIRb4Bs+d9gigDc8Ibmt1GWXSmReRHLc yKzifRiTm509+/ghDLCZimqiIm9oaXNss6c+aSOnXdyysKREKIZqRUHFdx5ppCx+/HLZ LA3FOYH5YNe2muRlP72XeDMUH/nM2XuRgVUXx/0SulNwOS3A1BQ3FeYpRgmIaYhC/wFV UTfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fGBp8E9sWY2g1vA1BwsDvb6YIZTbEwMwQ8ExTOjqap0=; b=raqffPxyE8A7YfUKaCsrQY98QHoQNaoU+zKnzux5Mp6jka4XNh6k539nvKQ/S5VcFC BOu9/SBEvdqgitDvzu2u+d/OE1ROaWUUrONFKDUwlQvjRbQrUuUTUk3f8c0VnNTUayX5 fWaO3Zq/lMXFbIy2xvdi82k9f8+ciZlgVwjbMFKMtbl8Gps/IOUyNXVHo8/I/ouVSHmr kT6QEo/qrQ/GbckCWBpemUZ8C/IG6DGWOMnSENUPsC7eGBE2Kw5AeoxQyEJWhhSkP/ot w3fdS9itgXTwTtdek3WhNVJQyBlMbt3oZvwzk2y7bgNfecYCpBMcGsBBc280Z6iP9zO+ Fv7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IuxWKeZd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 36si2083898pgn.272.2019.04.18.08.44.32; Thu, 18 Apr 2019 08:44:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=IuxWKeZd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389452AbfDRPmu (ORCPT + 99 others); Thu, 18 Apr 2019 11:42:50 -0400 Received: from mail-ot1-f51.google.com ([209.85.210.51]:36440 "EHLO mail-ot1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387519AbfDRPmu (ORCPT ); Thu, 18 Apr 2019 11:42:50 -0400 Received: by mail-ot1-f51.google.com with SMTP id o74so2089073ota.3 for ; Thu, 18 Apr 2019 08:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fGBp8E9sWY2g1vA1BwsDvb6YIZTbEwMwQ8ExTOjqap0=; b=IuxWKeZdDeALJ3RVuyXqq949K7Ut5Fu1+cOgStxBLkbDhOqShMQtIq1aLshqdXfsdi 1KGf9yk8FmDxjNqaHOnYo2wWFMgzKYbFLSwoq4m4ZcMc1Z4SLACqK4n+AaqT3MWN+NnH 4XiOU749N1w3V3kqvVNLTJvKAwVSk5Gk6c7UI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fGBp8E9sWY2g1vA1BwsDvb6YIZTbEwMwQ8ExTOjqap0=; b=arRsHEtkCKSACVwTmbTTTja08sk6UcFlvo/wNGzEzPUELoVfYDJVi1eld2rOZhdZXH sNKtySDFovDHmBrlzysVCKw2Llu+HUtsAuEITPCh68vlm4q9A+VQQ79tNnX/DJBj1YEL p3/6qV7Ejsuujlg0toUKyQLGlXSQlKJQBXA3wnOXKmflTQPb1jQztefu9/AaBJcK7jiC 9/UTBUVIbueNzQZ+C3xF0ke+5kCxJL3RulKy1MClrZUL6tEDqs+1aJhfklPIS2j8wyy7 F8xHfZHFUPsggln5ytZwH8Y1Iw97pJqn0XImfofmFxka4jv0wVVse0F6dGn7iEoAeAoN E/3g== X-Gm-Message-State: APjAAAXEEMhwie+it3ITl40/RYx6W2NV9/THDl2d8Yf8UwWxPmYiVgG5 GuhTnONPgnUeFFXaWchKQJBAcp55SZ0= X-Received: by 2002:a9d:61d6:: with SMTP id h22mr56301306otk.251.1555602169435; Thu, 18 Apr 2019 08:42:49 -0700 (PDT) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id z2sm1139096ota.56.2019.04.18.08.42.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 08:42:48 -0700 (PDT) Received: by mail-ot1-f52.google.com with SMTP id s24so2048284otk.13 for ; Thu, 18 Apr 2019 08:42:48 -0700 (PDT) X-Received: by 2002:a05:6830:1497:: with SMTP id s23mr56835378otq.236.1555602167808; Thu, 18 Apr 2019 08:42:47 -0700 (PDT) MIME-Version: 1.0 References: <20190417012048.87977-1-ncrews@chromium.org> In-Reply-To: <20190417012048.87977-1-ncrews@chromium.org> From: Nick Crews Date: Thu, 18 Apr 2019 09:42:36 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support To: Enric Balletbo i Serra , Benson Leung Cc: linux-kernel , Duncan Laurie , Daniel Erat , Dmitry Torokhov , Simon Glass , bartfab@chromium.org, Oleh Lamzin , Jason Wong Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's one error that Guenter just found... > + > +int wilco_ec_add_sysfs(struct wilco_ec_device *ec) > +{ > + return sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group); > +} > + > +void wilco_ec_remove_sysfs(struct wilco_ec_device *ec) > +{ > + sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group); Should be sysfs_remove_group()