Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190416174900.GT2217@ZenIV.linux.org.uk> <20190416175340.21068-1-viro@ZenIV.linux.org.uk>
 <20190416175340.21068-49-viro@ZenIV.linux.org.uk> <20190418121620.GI28541@quack2.suse.cz>
In-Reply-To: <20190418121620.GI28541@quack2.suse.cz>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Thu, 18 Apr 2019 09:58:45 -0700
Message-ID: <CAPcyv4jomNs0V_0+VHUZyx88tbAijEF9KJfb4jDzyqkCR-ds=g@mail.gmail.com>
Subject: Re: [RFC PATCH 49/62] dax: make use of ->free_inode()
To:     Jan Kara <jack@suse.cz>
Cc:     Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 18, 2019 at 5:16 AM Jan Kara <jack@suse.cz> wrote:
>
> On Tue 16-04-19 18:53:27, Al Viro wrote:
> > From: Al Viro <viro@zeniv.linux.org.uk>
> >
> > we might want to drop ->destroy_inode() there - it's used only for
> > WARN_ON() now, and AFAICS that could be moved to ->evict_inode()
> > if we had one...
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > ---
> >  drivers/dax/super.c | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
>
> Added Dan to CC since I'm not sure how closely he follows fsdevel. The
> patch looks good to me FWIW so feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks Jan.

Acked-by: Dan Williams <dan.j.williams@intel.com>

Al, I assume you'll merge this with the other free_inode changes.