Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp874803yba; Thu, 18 Apr 2019 11:02:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRgMxnzamcSul4OIFlC+yCrp6xiraAsq3Tfia1HlJ9q8mSbU4jRNSOrZGif6AHPAAg8nKi X-Received: by 2002:a62:5185:: with SMTP id f127mr98253807pfb.199.1555610528963; Thu, 18 Apr 2019 11:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555610528; cv=none; d=google.com; s=arc-20160816; b=e3A2JgeGmsmlSwk5ZqWb2tLIXATC5cn/VYd5Rg3kQpgSfThHS2pezQPAq5m/7NTHjY 5LsdRayEu1rezzxnjFThaNw/+zBbII/ooNgkurTzmsbjsgIY7nYwG81CG1cL9/coQ2FN Ba8KK7X242F/5vDv3QkZ73NDb3K6atpjAe8FxrB6NaMYS4CXpbwAYxYx6Igp2fPooynI FbYddQNib8PULyH5xd3ltQM9xIDJej0UjkH/gjZfep+iZ0qUswbI9fHC2WGDS5+DxdlP P6Blh4GCg57i0FG2jhbxKjrdJ+gvL0fq4AEVZmKlFN1qKrq6DPdLz6xsWGl2haPkSGWf 3vaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=nNbuwg6bMzkjgSBqQP5ZFGFmP7k2xmKiggCAQG+8nik=; b=LyG4084wbSCNOKFVwFqh8AwilzSxeErtfrvyq4CrJWuvNXR1xk+M1Ns+ASRuUGJRln NN9zqSk3PkWf/vfLmg+qD8oFlOIUOzXE0N6PIMmlNjkpLt6YhzfL5Vp/Z9cnDj2oFwbz BznjzvOKmN/KihyPfssDvznsWQaBnaj2wvhpYhHNAj30OeLI4ePOeG0/h4k7U2ZioC7D Or+i2XxFebOwS1Te/WZb9okCOApSToSh2YYrm/hBIDMJkm92Wr/KI61cYe//+AtaDecL UaB2H1l9IMkeSEuIjQgmCXLo5qHzDvtUkazO/P365vh+eKC1CPpBcHL9Q9EimDG6lIK7 bdOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=huvXpRGV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si3115036pfz.73.2019.04.18.11.01.53; Thu, 18 Apr 2019 11:02:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=huvXpRGV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390348AbfDRSAV (ORCPT + 99 others); Thu, 18 Apr 2019 14:00:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:55472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390330AbfDRSAR (ORCPT ); Thu, 18 Apr 2019 14:00:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7C6F21906; Thu, 18 Apr 2019 18:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555610417; bh=FoYGazWTUMh3ahwF5W3breeDIib3wm9GfTRAwegx0UE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=huvXpRGV5F07EocVGNfmUMFClg41R1CuuOgAEXEMLv7pSV3AEl4AfNWAcL2wlOfmO YlkkcJZsioQ937RUDOfa5+Zl9VLxEuyRHsl/GpqpzKW7n5tOEu3ok2t859HsxSAZiB DauEVK5dMVtq1HNzIrMN57ABVa9WxuM07TaSuL3c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Matthew Garrett , Zhang Rui , Sasha Levin Subject: [PATCH 4.19 021/110] thermal/int340x_thermal: fix mode setting Date: Thu, 18 Apr 2019 19:56:10 +0200 Message-Id: <20190418160439.727721315@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418160437.484158340@linuxfoundation.org> References: <20190418160437.484158340@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 396ee4d0cd52c13b3f6421b8d324d65da5e7e409 ] int3400 only pushes the UUID into the firmware when the mode is flipped to "enable". The current code only exposes the mode flag if the firmware supports the PASSIVE_1 UUID, which not all machines do. Remove the restriction. Signed-off-by: Matthew Garrett Signed-off-by: Zhang Rui Signed-off-by: Sasha Levin --- drivers/thermal/int340x_thermal/int3400_thermal.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c index 51c9097eaf7a..e9d58de8b5da 100644 --- a/drivers/thermal/int340x_thermal/int3400_thermal.c +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c @@ -316,10 +316,9 @@ static int int3400_thermal_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); - if (priv->uuid_bitmap & 1 << INT3400_THERMAL_PASSIVE_1) { - int3400_thermal_ops.get_mode = int3400_thermal_get_mode; - int3400_thermal_ops.set_mode = int3400_thermal_set_mode; - } + int3400_thermal_ops.get_mode = int3400_thermal_get_mode; + int3400_thermal_ops.set_mode = int3400_thermal_set_mode; + priv->thermal = thermal_zone_device_register("INT3400 Thermal", 0, 0, priv, &int3400_thermal_ops, &int3400_thermal_params, 0, 0); -- 2.19.1