Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp884148yba; Thu, 18 Apr 2019 11:10:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqxoVaUUNMLbYc/K/+g3VjjbSHk7ih+q8fn6d+Rp1SDi1kmAcfS8pERnANZxVhzGnqkLGJsr X-Received: by 2002:a17:902:9341:: with SMTP id g1mr59925715plp.81.1555611020417; Thu, 18 Apr 2019 11:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555611020; cv=none; d=google.com; s=arc-20160816; b=v0lKb6I7eMVokQTobui/N9VP94PzgqjgWRt2hmR4Hbkc1wPeXLVmiHp1vhVnESo6kZ TW12/QxDhrf0wgqtz39KOSfDBdiVxkDSWxjwTgbxH29TBJKTFjvl/whOvZAWnz/WWdzS nl6hCp1C23OZL29xL7gbJDycrAxzQCyPUgutRDfJSc26vrGxcuxklA9YyM9LC9zZ3SR8 dvqy/9fHyrv7Mfa2RVvPcuy/castSFvucngbcaR1WUTioPlImdJJFRlrc04jtWCWXQTZ HRR1x4cGV3tEZzOoOeMSsuHn38d2gUXuxRv8UgzGvuG2gfXkDbplFYte8U0alu/jIf1B DFmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XjJfHU0GjNLDyfX9exs+JF5Waw1tQYqNAkbXYRVv3D4=; b=vE5ulrv+P8vqNFlB9+B5oycK8TVHrKyqmUYaWNCNAcvH0tNQpu46Jd4Pn6BdU2Mmqn ZcOOxjKkTnUJFdZVMO5zMM5BwyGxKHMuxzxfezPN71iaaJY1uiC0+czAmxXxDIjLwKkG ISmZYq6mqQ7hcx5G3X+V0hy8bidB5F12QEKqlIbvrX5B3uhCJpSx58evke8iyy2O/p4g 4VPNrSjlsYKLYdW62/+VGn4f9BqZvi3hO/5TfkkOzO4CSlmKt7TsOkGGLKMi/rtjvLHW JVeQcL+1dbwDgzpVE0FEiLkoLVyOZXu0iNtXW15Z7Pn8TAcU7UB2S6v4w2jR1Z5hfV8r Y40g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pmhr8hxm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si2729244plq.2.2019.04.18.11.10.05; Thu, 18 Apr 2019 11:10:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pmhr8hxm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391769AbfDRSIT (ORCPT + 99 others); Thu, 18 Apr 2019 14:08:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391734AbfDRSIR (ORCPT ); Thu, 18 Apr 2019 14:08:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 480AB218AF; Thu, 18 Apr 2019 18:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555610896; bh=vNgoQaUJX8ExcVOAWiAMsHyQeTK4uFdHyiPz0GbAR1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pmhr8hxmGbqaFSiGAHk6oYIObK/QBY8WHPjl33S07/MSQhtYEYqPNxUpC28VfLe3b zPO9ukXCibRu+IItC3DZBrZWXEboGutQ7zCqFoB+RsT7R8wZYnz0LCMG5Bi5yywOY5 6+GB2sHZlNZujE1PKIIVHOJ9yEfoKcPjzGk67NQU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Simek , Sasha Levin Subject: [PATCH 4.9 33/50] serial: uartps: console_setup() cant be placed to init section Date: Thu, 18 Apr 2019 19:57:44 +0200 Message-Id: <20190418160426.724797866@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190418160422.455656724@linuxfoundation.org> References: <20190418160422.455656724@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ] When console device is rebinded, console_setup() is called again. But marking it as __init means that function will be clear after boot is complete. If console device is binded again console_setup() is not found and error "Unable to handle kernel paging request at virtual address" is reported. Signed-off-by: Michal Simek Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index ffb474c49f0f..eb61a07fcbbc 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1261,7 +1261,7 @@ static void cdns_uart_console_write(struct console *co, const char *s, * * Return: 0 on success, negative errno otherwise. */ -static int __init cdns_uart_console_setup(struct console *co, char *options) +static int cdns_uart_console_setup(struct console *co, char *options) { struct uart_port *port = &cdns_uart_port[co->index]; int baud = 9600; -- 2.19.1